Fix rand() sort + head limit regression in PPL (issue #5114)#5128
Fix rand() sort + head limit regression in PPL (issue #5114)#5128penghuo wants to merge 2 commits into
Conversation
Signed-off-by: Peng Huo <penghuo@gmail.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds an integration YAML test for issue 5114 and two new integration tests; tightens SortExprIndexScanRule to prevent pushing non-deterministic sort expressions and restrict limit/offset pushdown to LogicalSort-backed scans. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tics Signed-off-by: Peng Huo <penghuo@gmail.com>
Description
Fix issue #5114 by preventing non-deterministic sort-expression pushdown and preserving limit semantics for non-LogicalSort nodes carrying fetch/offset.
Related Issues
#5114
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.