Skip to content

[Maintenance] Fix bc-fips jar hell by marking dependency as compileOnly #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanL1997 merged 2 commits into from
Feb 20, 2026
Merged

[Maintenance] Fix bc-fips jar hell by marking dependency as compileOnly #5158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d51d633
[maintenance] Fix bc-fips jar hell by marking dependency as compileOnly
RyanL1997 Feb 19, 2026
fc7b6ae
add fix for tests
RyanL1997 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions datasources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
* SPDX-License-Identifier: Apache-2.0
*/

import org.opensearch.gradle.info.FipsBuildParams

plugins {
id 'java-library'
id "io.freefair.lombok"
Expand All @@ -28,12 +26,10 @@ dependencies {
implementation ('com.amazonaws:aws-encryption-sdk-java:2.4.1') {
exclude group: 'org.bouncycastle', module: 'bcprov-ext-jdk18on'
}
// When building with -Pcrypto.standard=FIPS-140-3, bcFips jars are provided by OpenSearch
if (FipsBuildParams.isInFipsMode()) {
compileOnly "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"
} else {
implementation "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"
}

// bc-fips is provided by OpenSearch core at runtime since opensearch 3.6.0
compileOnly "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"
testImplementation "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"

testImplementation group: 'junit', name: 'junit', version: '4.13.2'
testImplementation('org.junit.jupiter:junit-jupiter:5.9.3')
Expand Down
Loading