Exclude AnalyticsEngineCompatIT from the main integTest task#5501
Merged
ahkcs merged 2 commits intoJun 2, 2026
Merged
Conversation
…Test task
AnalyticsEngineCompatIT (package org.opensearch.sql.plugin) is a smoke test
that only makes sense against a cluster bundling the analytics-engine plugin
stack. It is provisioned and run by the dedicated :analyticsEngineCompatIT
task (testClusters.analyticsEngineCompat), which adds arrow-base,
arrow-flight-rpc and analytics-engine.
The main integTest task selects tests by exclusion and excluded
org/opensearch/sql/security/** ("executed in another task") but never
excluded the plugin package, so the smoke test also ran against the plain
integTest/remoteCluster (neither of which has analytics-engine). There it is
useless and exposed to suite-wide infra flakiness; in a recent CI run it was
the descriptor recorded as failed after the test JVM wedged for ~4.5h.
Mirror the existing security/** exclusion for org/opensearch/sql/plugin/**.
Signed-off-by: Kai Huang <ahkcs@amazon.com>
ahkcs
requested review from
LantaoJin,
RyanL1997,
Swiddis,
acarbonetto,
anirudha,
dai-chen,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
mengweieric
previously approved these changes
Jun 2, 2026
RyanL1997
previously approved these changes
Jun 2, 2026
| // (:analyticsEngineCompatIT) against a cluster that bundles the analytics-engine plugin | ||
| // stack. Running it here against the plain integTest/remoteCluster (no analytics-engine) | ||
| // is pointless and leaves it exposed to suite-wide infra flakiness. | ||
| exclude 'org/opensearch/sql/plugin/**' |
Collaborator
There was a problem hiding this comment.
can we only exclude that test suite?
Collaborator
Author
There was a problem hiding this comment.
Good call — switched to excluding the specific AnalyticsEngineCompatIT.class instead of the package
Address review feedback: exclude the specific test class rather than the whole org/opensearch/sql/plugin/** package, matching the per-class exclude style already used in this task (e.g. legacy/ExplainIT.class). This keeps the exclusion intentional and avoids silently dropping any future test added to that package. Signed-off-by: Kai Huang <ahkcs@amazon.com>
3 tasks
ahkcs
requested review from
RyanL1997 and
mengweieric
and removed request for
mengweieric
RyanL1997
approved these changes
Jun 2, 2026
dai-chen
approved these changes
Jun 2, 2026
dai-chen
left a comment
dai-chen
left a comment
Collaborator
There was a problem hiding this comment.
AnalyticsEngineCompatIT only fails with integTest/remoteCluster but can succeed with internalCluster in SQL CI?
Collaborator
Author
Right — it's green in SQL CI (plain-HTTP, non-security cluster) and only fails in the distribution build's with-security run. It extends bare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AnalyticsEngineCompatIT(packageorg.opensearch.sql.plugin) is a smoke test that only makes sense against a cluster bundling the analytics-engine plugin stack. It is provisioned and run by its dedicated:analyticsEngineCompatITtask, whose cluster (testClusters.analyticsEngineCompat) addsarrow-base,arrow-flight-rpc, andanalytics-enginealongsideopensearch-sql.The main
integTesttask selects tests by exclusion. It already excludesorg/opensearch/sql/security/**("executed in another task"), but it never excluded the plugin package — so the smoke test also ran inside the mainintegTestsuite against the plainintegTest/remoteClusterclusters, neither of which has the analytics-engine plugin. (integTestWithSecurityis unaffected because it uses an include filter scoped toorg.opensearch.sql.security.*.)There, the test is pointless and exposed to suite-wide infra flakiness. In a recent CI run it was the descriptor recorded as the single failure after the test JVM wedged for ~4.5h (JobSweeper kept ticking for ~3.5h before the REST connection finally dropped with
ConnectionClosedException). The empty test body cannot itself hang — it was simply the last test in the order when the wedged JVM died.Fix
Mirror the existing
security/**exclusion fororg/opensearch/sql/plugin/**in the mainintegTesttask. The compat test continues to run via its dedicated:analyticsEngineCompatITtask, which correctly provisions its dependency.This is purely a test-isolation/wiring fix in
integ-test/build.gradle; no production or test source changes.Verification
./gradlew :integ-test:integTest --dry-runconfigures the full task graph successfully with the new exclusion.org/opensearch/sql/security/**exclusion.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.