Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,57 @@ public void selectExpressionWithoutFrom() {
""");
}

@Test
public void testGroupByAggregateAlias() {
givenQuery(
"""
SELECT department, SUM(age) AS total FROM catalog.employees GROUP BY department
""")
.assertPlan(
"""
LogicalProject(department=[$0], total=[$1])
LogicalAggregate(group=[{0}], SUM(age)=[SUM($1)])
LogicalProject(department=[$3], age=[$2])
LogicalTableScan(table=[[catalog, employees]])
""");
}

@Test
public void testOrderByAggregateAlias() {
givenQuery(
"""
SELECT department, COUNT(*) AS cnt FROM catalog.employees
GROUP BY department ORDER BY cnt DESC LIMIT 3
""")
.assertPlan(
"""
LogicalSort(sort0=[$1], dir0=[DESC-nulls-last])
LogicalProject(department=[$1], cnt=[$0])
LogicalSort(sort0=[$0], dir0=[DESC-nulls-last], fetch=[3])
LogicalProject(COUNT(*)=[$1], department=[$0])
LogicalAggregate(group=[{0}], COUNT(*)=[COUNT()])
LogicalProject(department=[$3])
LogicalTableScan(table=[[catalog, employees]])
""");
}

@Test
public void testAliasPreservedInOutputSchema() {
givenQuery("SELECT COUNT(*) AS cnt FROM catalog.employees").assertFields("cnt");

givenQuery("SELECT department, COUNT(*) AS cnt FROM catalog.employees GROUP BY department")
.assertFields("department", "cnt");

givenQuery("SELECT department, COUNT(*) FROM catalog.employees GROUP BY department")
.assertFields("department", "COUNT(*)");

givenQuery("SELECT MAX(age) + MIN(age) AS range_sum FROM catalog.employees")
.assertFields("range_sum");

givenQuery("SELECT id, name, age AS years, department FROM catalog.employees")
.assertFields("id", "name", "years", "department");
}

@Test
public void testHavingMaxCol() {
givenQuery(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -481,11 +481,30 @@ public RelNode visitProject(Project node, CalcitePlanContext context) {
if (!context.isResolvingSubquery()) {
context.setProjectVisited(true);
}
context.relBuilder.project(expandedFields);

// Force the projection on a rename: without it, Calcite omits the project node when the
// columns are unchanged (same fields and order), so an alias like COUNT(*) AS cnt is lost.
boolean force = isRenameFieldsProject(expandedFields, currentFields);
context.relBuilder.project(expandedFields, ImmutableList.of(), force);
}
return context.relBuilder.peek();
}

private static boolean isRenameFieldsProject(List<RexNode> fields, List<String> currentFields) {
for (RexNode r : fields) {
if (r.getKind() == AS) {
RexCall as = (RexCall) r;
if (as.getOperands().get(0) instanceof RexInputRef ref) {
String name = ((RexLiteral) as.getOperands().get(1)).getValueAs(String.class);
if (!name.equals(currentFields.get(ref.getIndex()))) {
return true;
}
}
}
}
return false;
}

private boolean isSingleAllFieldsProject(Project node) {
return node.getProjectList().size() == 1
&& node.getProjectList().getFirst() instanceof AllFields;
Expand Down
Loading