Gate analytics engine incompatible IT tests with capability matrix#5585
Draft
dai-chen wants to merge 2 commits into
Draft
Gate analytics engine incompatible IT tests with capability matrix#5585dai-chen wants to merge 2 commits into
dai-chen wants to merge 2 commits into
Conversation
Migrate the analytics-engine IT exclusions to method/class-level @RequiresCapability annotations so each test self-skips when the analytics engine is active, instead of relying on build.gradle excludes. Add coarse capabilities (backend: vector/geopoint/identifier, untyped NULL literal, filtered aggregate; frontend: response format, pagination/cursor, prepared statement, legacy method query, query error, explain format, function type compat) and reuse existing capabilities where they fit. SQLCorrectnessIT is outside the SQLIntegTestCase hierarchy, so it calls BackendCapabilities.requireCapability directly. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
added
infrastructure
Contributor
PR Reviewer Guide 🔍(Review updated until commit d92e994)Here are some key observations to aid the review process:
|
dai-chen
force-pushed
the
requirescapability-it-gating
branch
2 times, most recently
from
7e17a09 to
5476160
Compare
Contributor
|
Persistent review updated to latest commit 5476160 |
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
requirescapability-it-gating
branch
from
5476160 to
d92e994
Compare
Contributor
|
Persistent review updated to latest commit 5476160 |
Contributor
|
Persistent review updated to latest commit d92e994 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As follow-up of #5584, this PR gates analytics-engine (AE) incompatible IT tests with per-test
@RequiresCapabilityannotations so each test self-skips when the analytics engine is active and keep the gating next to the test, No production code changes, and default-engine behavior is unaffected.Related Issues
Part of #5248
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.