Merge pull request #388 from dpw13/fix/onvif-detection-params

Remove ONVIF motion recording (not ONVIF motion *detection*)

Author: matteius

.github/workflows/integration-test.yml

@@ -83,7 +83,6 @@ jobs:
             test_db_query_builder \
             test_logger_json \
             test_batch_delete_progress \
-            test_db_motion_config \
             test_db_recordings_sync \
             test_httpd_utils \
             test_zone_filter \
@@ -99,7 +98,7 @@ jobs:
         run: |
           cd build
           ctest --output-on-failure -V \
-            -R "test_storage_pressure$|test_storage_pressure_extended|test_detection_result_structures|test_storage_retention_sqlite|test_config|test_logger|test_strings|test_memory|test_request_response|test_shutdown_coordinator|test_detection_config|test_detection_model_motion|test_db_streams|test_db_recordings_extended|test_db_detections|test_db_zones|test_db_events|test_db_auth|test_db_transactions|test_db_maintenance|test_db_query_builder|test_logger_json|test_batch_delete_progress|test_db_motion_config|test_db_recordings_sync|test_httpd_utils|test_zone_filter|test_onvif_soap_fault|test_stream_manager|test_stream_state|test_packet_buffer|test_timestamp_manager"
+            -R "test_storage_pressure$|test_storage_pressure_extended|test_detection_result_structures|test_storage_retention_sqlite|test_config|test_logger|test_strings|test_memory|test_request_response|test_shutdown_coordinator|test_detection_config|test_detection_model_motion|test_db_streams|test_db_recordings_extended|test_db_detections|test_db_zones|test_db_events|test_db_auth|test_db_transactions|test_db_maintenance|test_db_query_builder|test_logger_json|test_batch_delete_progress|test_db_recordings_sync|test_httpd_utils|test_zone_filter|test_onvif_soap_fault|test_stream_manager|test_stream_state|test_packet_buffer|test_timestamp_manager"
 
       - name: Generate coverage report
         if: always()

.github/workflows/sanitizer.yml

@@ -52,7 +52,7 @@ jobs:
           cd build
           echo "Running tests with ASan + UBSan enabled..."
           ctest --output-on-failure -V \
-            -R "test_config|test_logger|test_strings|test_memory|test_request_response|test_shutdown_coordinator|test_detection_config|test_detection_model_motion|test_db_streams|test_db_recordings_extended|test_db_detections|test_db_zones|test_db_events|test_db_auth|test_db_transactions|test_db_maintenance|test_db_query_builder|test_logger_json|test_batch_delete_progress|test_db_motion_config|test_db_recordings_sync|test_httpd_utils|test_zone_filter|test_stream_manager|test_stream_state|test_packet_buffer|test_timestamp_manager|test_storage_pressure$|test_storage_pressure_extended|test_detection_result_structures|test_storage_retention_sqlite"
+            -R "test_config|test_logger|test_strings|test_memory|test_request_response|test_shutdown_coordinator|test_detection_config|test_detection_model_motion|test_db_streams|test_db_recordings_extended|test_db_detections|test_db_zones|test_db_events|test_db_auth|test_db_transactions|test_db_maintenance|test_db_query_builder|test_logger_json|test_batch_delete_progress|test_db_recordings_sync|test_httpd_utils|test_zone_filter|test_stream_manager|test_stream_state|test_packet_buffer|test_timestamp_manager|test_storage_pressure$|test_storage_pressure_extended|test_detection_result_structures|test_storage_retention_sqlite"
 
       - name: Smoke test - start and stop service
         run: |

README.md

@@ -23,7 +23,7 @@ LightNVR provides a lightweight yet powerful solution for recording and managing
 #### 🎯 Smart Detection & Recording
 - **Detection Zones**: Visual polygon-based zone editor for targeted object detection - define multiple zones per camera with custom class filters and confidence thresholds
 - **light-object-detect Integration**: Seamless integration with [light-object-detect](https://github.com/opensensor/light-object-detect) API for ONNX/TFLite-based object detection with zone filtering
-- **ONVIF Motion Recording**: Automated recording triggered by ONVIF motion detection events
+- **ONVIF Motion Events**: Automated recording triggered by ONVIF motion detection events
 - **Object Detection**: Optional SOD integration for motion and object detection (supports both RealNet and CNN models)
 
 #### 📺 Streaming & Playback
@@ -451,7 +451,6 @@ The configuration files will persist across container restarts and updates.
 - [go2rtc Integration](docs/GO2RTC_INTEGRATION.md)
 - [MQTT Integration](docs/MQTT_INTEGRATION.md)
 - [ONVIF Detection](docs/ONVIF_DETECTION.md)
-- [ONVIF Motion Recording](docs/ONVIF_MOTION_RECORDING.md)
 - [Motion Buffer System](docs/MOTION_BUFFER.md)
 - [SOD Integration](docs/SOD_INTEGRATION.md)
 

docs/API.md

@@ -716,30 +716,6 @@ Returns available detection models.
 
 ### Motion Recording
 
-#### Get Motion Config
-
-```
-GET /api/motion/config/{stream_name}
-```
-
-Returns motion recording configuration for a stream.
-
-#### Set Motion Config
-
-```
-POST /api/motion/config/{stream_name}
-```
-
-Creates or updates motion recording configuration.
-
-#### Delete Motion Config
-
-```
-DELETE /api/motion/config/{stream_name}
-```
-
-Deletes motion recording configuration for a stream.
-
 #### Test Motion Event
 
 ```
@@ -748,46 +724,6 @@ POST /api/motion/test/{stream_name}
 
 Triggers a test motion event for debugging.
 
-#### Get Motion Stats
-
-```
-GET /api/motion/stats/{stream_name}
-```
-
-Returns motion recording statistics.
-
-#### List Motion Recordings
-
-```
-GET /api/motion/recordings/{stream_name}
-```
-
-Returns motion-triggered recordings.
-
-#### Delete Motion Recording
-
-```
-DELETE /api/motion/recordings/{recording_id}
-```
-
-Deletes a motion recording.
-
-#### Motion Cleanup
-
-```
-POST /api/motion/cleanup
-```
-
-Triggers cleanup of expired motion recordings.
-
-#### Motion Storage
-
-```
-GET /api/motion/storage
-```
-
-Returns motion recording storage usage.
-
 ### HLS Streaming
 
 #### Direct HLS Request

docs/ARCHITECTURE.md

@@ -168,7 +168,6 @@ Key files:
 - `src/video/sod_integration.c`: SOD library integration
 - `src/video/sod_realnet.c`: SOD RealNet face detection
 - `src/video/onvif_detection.c`: ONVIF event-based detection
-- `src/video/onvif_detection_integration.c`: ONVIF detection integration layer
 - `src/video/onvif_motion_recording.c`: ONVIF motion-triggered recording
 - `src/video/motion_detection.c`: Motion detection processing
 - `src/video/motion_storage_manager.c`: Motion recording storage management

docs/MOTION_BUFFER.md

@@ -175,20 +175,6 @@ The system handles overlapping motion events intelligently:
 
 ## Configuration
 
-### Per-Stream Configuration
-
-```c
-motion_recording_config_t config = {
-    .enabled = true,
-    .pre_buffer_seconds = 10,    // 10 seconds of pre-event video
-    .post_buffer_seconds = 15,   // 15 seconds after motion ends
-    .max_file_duration = 600,    // Max 10 minutes per file
-    .retention_days = 30
-};
-
-enable_motion_recording("camera_name", &config);
-```
-
 ### Buffer Modes
 
 - **BUFFER_MODE_MEMORY**: Store packets in RAM (default)

docs/ONVIF_DETECTION.md

@@ -66,9 +66,7 @@ Some cameras don't require authentication for ONVIF events. For these cameras, y
 The ONVIF detection feature is implemented in the following files:
 
 - `include/video/onvif_detection.h`: Header file for ONVIF detection
-- `include/video/onvif_detection_integration.h`: Header file for ONVIF detection integration
 - `src/video/onvif_detection.c`: Implementation of ONVIF detection
-- `src/video/onvif_detection_integration.c`: Integration with the detection system
 
 The implementation uses the following components: