refactor: rename onvif_motion_recording to cross_stream_motion_trigger + drop /api/motion/test (#374)

The onvif_motion_recording module has been reduced to a single function
(process_motion_event) whose only job is to fan a motion event out to
streams linked via motion_trigger_source -- the actual "motion recording"
machinery (per-camera config, buffers, retention) was deleted in
878d3f3 along with the corresponding UI section. The filename no
longer matches what the module does; cross-stream motion trigger
propagation is what remained, so rename accordingly.

- git-mv onvif_motion_recording.{c,h} to cross_stream_motion_trigger.{c,h}
- Update header guard LIGHTNVR_ONVIF_MOTION_RECORDING_H ->
  LIGHTNVR_CROSS_STREAM_MOTION_TRIGGER_H
- Refresh the file-level doc comment in both files to describe what the
  module actually does now, with a one-line note on the rename for grep
  archaeology
- Update the six #include sites: main.c, onvif_detection.c,
  detection_integration.c, db_motion_config.h, the test file, and the
  deleted api_handlers_motion.c

Also delete the /api/motion/test/<stream> endpoint. It's unreachable
from the current UI (the Trigger Test Motion button was removed along
with the Motion Recording section) and nothing else calls it -- the
whole api_handlers_motion.{c,h} pair existed solely for this one route.
Removed files + the route registration + the include in
libuv_api_handlers.c.

No behavior change for running installations. The cross-stream motion
trigger tests continue to pass (5/5).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: matteius

include/database/db_motion_config.h

@@ -3,7 +3,7 @@
 
 #include <stdint.h>
 #include <stdbool.h>
-#include "video/onvif_motion_recording.h"
+#include "video/cross_stream_motion_trigger.h"
 
 /**
  * Motion Recording Configuration Database Module

include/video/onvif_motion_recording.h …lude/video/cross_stream_motion_trigger.hinclude/video/onvif_motion_recording.h renamed to include/video/cross_stream_motion_trigger.h include/video/onvif_motion_recording.h renamed to include/video/cross_stream_motion_trigger.h

@@ -1,5 +1,5 @@
-#ifndef LIGHTNVR_ONVIF_MOTION_RECORDING_H
-#define LIGHTNVR_ONVIF_MOTION_RECORDING_H
+#ifndef LIGHTNVR_CROSS_STREAM_MOTION_TRIGGER_H
+#define LIGHTNVR_CROSS_STREAM_MOTION_TRIGGER_H
 
 #include <stdint.h>
 #include <stdbool.h>
@@ -10,13 +10,18 @@
 #include "video/packet_buffer.h"
 
 /**
- * ONVIF Motion Detection Recording Module
- * 
- * This module implements automated recording triggered by ONVIF motion detection events.
- * It provides:
- * - Event-based recording triggered by ONVIF motion events
- * - Configurable pre/post-event buffer recording
- * - Integration with existing LightNVR detection framework
+ * Cross-Stream Motion Trigger Module
+ *
+ * Fans an incoming motion event out to any streams linked via the
+ * `motion_trigger_source` configuration, so a silent PTZ lens can start
+ * recording when its paired wide-angle lens fires a motion event, and
+ * vice-versa for dual-lens devices that share a single ONVIF endpoint.
+ *
+ * This used to be onvif_motion_recording.{c,h}; the bulk of that module
+ * (per-camera motion recording configuration with its own buffers and
+ * retention) was removed along with the separate "Motion Recording (ONVIF)"
+ * UI section. What remained was just the cross-stream propagation hook,
+ * hence the rename.
  */
 
 // Maximum number of motion events in queue
@@ -43,5 +48,5 @@ typedef struct {
  */
 int process_motion_event(const char *stream_name, bool motion_detected, time_t timestamp, bool is_propagated);
 
-#endif /* LIGHTNVR_ONVIF_MOTION_RECORDING_H */
+#endif /* LIGHTNVR_CROSS_STREAM_MOTION_TRIGGER_H */
 

include/web/api_handlers_motion.h

@@ -44,7 +44,7 @@
 #include "video/timestamp_manager.h"
 #include "video/onvif_discovery.h"
 #include "video/ffmpeg_leak_detector.h"
-#include "video/onvif_motion_recording.h"
+#include "video/cross_stream_motion_trigger.h"
 #include "telemetry/stream_metrics.h"
 #include "telemetry/player_telemetry.h"
 

src/core/main.c

@@ -1,7 +1,9 @@
 /**
- * ONVIF Motion Detection Recording Implementation
- * 
- * This module implements automated recording triggered by ONVIF motion detection events.
+ * Cross-Stream Motion Trigger Implementation
+ *
+ * Propagates a motion event from one stream to any linked streams via the
+ * `motion_trigger_source` configuration. See cross_stream_motion_trigger.h
+ * for the module-level rationale.
  */
 
 #include <stdio.h>
@@ -13,7 +15,7 @@
 #include <sys/stat.h>
 #include <errno.h>
 
-#include "video/onvif_motion_recording.h"
+#include "video/cross_stream_motion_trigger.h"
 #include "video/streams.h"
 #include "video/stream_manager.h"
 #include "video/unified_detection_thread.h"

src/video/onvif_motion_recording.c src/video/cross_stream_motion_trigger.csrc/video/onvif_motion_recording.c renamed to src/video/cross_stream_motion_trigger.c

@@ -23,7 +23,7 @@
 #include "video/sod_integration.h"
 #include "video/api_detection.h"
 #include "video/onvif_detection.h"
-#include "video/onvif_motion_recording.h"
+#include "video/cross_stream_motion_trigger.h"
 #include "utils/memory.h"
 
 // Include our new modules

src/video/detection_integration.c

@@ -19,7 +19,7 @@
 #include "video/onvif_detection.h"
 #include "video/onvif_soap.h"
 #include "video/detection_result.h"
-#include "video/onvif_motion_recording.h"
+#include "video/cross_stream_motion_trigger.h"
 #include "video/zone_filter.h"
 #include "database/db_detections.h"
 #include "ezxml.h"

src/video/onvif_detection.c

@@ -17,7 +17,6 @@
 #include "web/api_handlers_settings.h"
 #include "web/api_handlers_system.h"
 #include "web/api_handlers_zones.h"
-#include "web/api_handlers_motion.h"
 #include "web/api_handlers_ptz.h"
 #include "web/api_handlers_detection.h"
 #include "web/api_handlers_recordings_playback.h"
@@ -134,9 +133,6 @@ int register_all_libuv_handlers(http_server_handle_t server) {
     http_server_register_handler(server, "/api/detection/results/#", "GET", handle_get_detection_results);
     http_server_register_handler(server, "/api/detection/models", "GET", handle_get_detection_models);
 
-    // Motion Recording API
-    http_server_register_handler(server, "/api/motion/test/#", "POST", handle_test_motion_event);
-
     // Storage Management API
     http_server_register_handler(server, "/api/storage/health", "GET", handle_get_storage_health);
     http_server_register_handler(server, "/api/storage/cleanup", "POST", handle_post_storage_cleanup);

src/web/api_handlers_motion.c

@@ -2,13 +2,14 @@
  * @file test_cross_stream_motion_trigger.c
  * @brief Layer 3 Unity tests for cross-stream motion trigger feature
  *
- * Tests the process_motion_event() cross-stream propagation logic added in
- * src/video/onvif_motion_recording.c.  The feature allows a "silent" stream
- * (e.g. PTZ lens) to have its recording triggered by motion events from a
- * different "source" stream (e.g. fixed wide-angle lens with ONVIF support).
+ * Tests the process_motion_event() cross-stream propagation logic in
+ * src/video/cross_stream_motion_trigger.c.  The feature allows a "silent"
+ * stream (e.g. PTZ lens) to have its recording triggered by motion events
+ * from a different "source" stream (e.g. fixed wide-angle lens with ONVIF
+ * support).
  *
- * Layer 3: requires lightnvr_lib + FFmpeg (for onvif_motion_recording.c which
- * includes libavformat/avformat.h).
+ * Layer 3: requires lightnvr_lib + FFmpeg (the module header pulls in
+ * libavformat/avformat.h transitively).
  */
 
 #define _POSIX_C_SOURCE 200809L
@@ -23,7 +24,7 @@
 #include "unity.h"
 #include "database/db_core.h"
 #include "database/db_streams.h"
-#include "video/onvif_motion_recording.h"
+#include "video/cross_stream_motion_trigger.h"
 #include "core/config.h"
 #include "core/logger.h"
 #include "utils/strings.h"