chore: clean up legacy motion-recording debris (#374)

Followup on 878d3f3, which removed the separate "Motion Recording
(ONVIF)" section from the stream config modal in favor of the unified
AI Detection path (detection_model=onvif). That commit left a trail of
orphans that were still showing up to users on v0.33.2 and causing
"why are there two places to enable this?" confusion (titro in #374
before upgrading). Strictly a sweep — no functional change.

- en.json + pt-BR.json: drop 19 translation keys that no longer
  resolve to any t() call: motionRecordingOnvif,
  enableOnvifMotionRecording, onvifMotionRecordingHelp,
  pre/postEventBufferSeconds/Help, maxFileDuration*, retentionPeriod*,
  recordingQuality, triggerTestMotionEvent, motionConfigSaveFailed,
  and the five streams.testMotionEvent*/errorTriggeringTestMotion
  strings that were only used by the dead triggerTestMotionEvent
  handler.

- api_handlers_streams_get.c: stop emitting the `motion_config` field
  (the comment already called it "obsolete"; it was always null and
  nothing consumed it).

- StreamsView.jsx: drop the two dead `const motion = data.motion_config
  || null` lines (unused local) and the `triggerTestMotionEvent`
  async handler that was wired to a button the modal no longer
  renders.

- StreamConfigModal.jsx: drop the `onTestMotion` prop it never read.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: matteius

src/web/api_handlers_streams_get.c

@@ -580,9 +580,6 @@ void handle_get_stream_full(const http_request_t *req, http_response_t *res) {
     }
     cJSON_AddItemToObject(response, "stream", stream_obj);
 
-    // Add obsolete motion config
-    cJSON_AddNullToObject(response, "motion_config");
-
     char *json_str = cJSON_PrintUnformatted(response);
     if (!json_str) {
         cJSON_Delete(response);

web/js/components/preact/StreamConfigModal.jsx

@@ -287,7 +287,6 @@ export function StreamConfigModal({
   onInputChange,
   onThresholdChange,
   onTestConnection,
-  onTestMotion,
   onSave,
   onClose,
   onRefreshModels,

web/js/components/preact/StreamsView.jsx

@@ -641,33 +641,6 @@ export function StreamsView() {
     });
   };
 
-  // Trigger a simulated ONVIF motion event for the current stream
-  const triggerTestMotionEvent = async () => {
-    if (!currentStream?.name) {
-      showStatusMessage(t('streams.setStreamNameAndSaveBeforeTestingMotion'), 'error', 5000);
-      return;
-    }
-    if (!currentStream?.isOnvif) {
-      showStatusMessage(t('streams.enableOnvifCameraFirst'), 'error', 5000);
-      return;
-    }
-    try {
-      // Now fire the test motion event
-      const data = await fetchJSON(`/api/motion/test/${encodeURIComponent(currentStream.name)}`, {
-        method: 'POST',
-        timeout: 15000
-      });
-      if (data?.success) {
-        showStatusMessage(t('streams.testMotionEventTriggeredSuccessfully'), 'success', 3000);
-      } else {
-        showStatusMessage(t('streams.testMotionEventFailed', { message: data?.message || t('common.unknown') }), 'error', 5000);
-      }
-    } catch (err) {
-      showStatusMessage(t('streams.errorTriggeringTestMotion', { message: err.message }), 'error', 5000);
-    }
-  };
-
-
   // Open delete modal
   const openDeleteModal = (stream) => {
     setStreamToDelete(stream);
@@ -746,7 +719,6 @@ export function StreamsView() {
         staleTime: 0 // Always fetch fresh when opening modal
       });
       const stream = data.stream || {};
-      const motion = data.motion_config || null;
 
       setCurrentStream({
         ...stream,
@@ -825,7 +797,6 @@ export function StreamsView() {
         staleTime: 0
       });
       const stream = data.stream || {};
-      const motion = data.motion_config || null;
 
       setCurrentStream({
         ...stream,
@@ -1530,7 +1501,6 @@ export function StreamsView() {
           onInputChange={handleInputChange}
           onThresholdChange={handleThresholdChange}
           onTestConnection={testStreamConnection}
-          onTestMotion={triggerTestMotionEvent}
           onSave={handleSubmit}
           onClose={closeModal}
           onRefreshModels={loadDetectionModels}

web/public/locales/en.json

@@ -854,20 +854,7 @@
   "streamsConfig.zoneTipDrawPolygons": "Draw polygons by clicking points on the image",
   "streamsConfig.zoneTipIgnoreAreas": "Use zones to ignore areas like trees, roads, or sky",
   "streamsConfig.zoneTipMultipleZones": "Multiple zones can be configured for different areas",
-  "streamsConfig.motionRecordingOnvif": "Motion Recording (ONVIF)",
   "streamsConfig.onvifOnly": "ONVIF Only",
-  "streamsConfig.enableOnvifMotionRecording": "Enable ONVIF Motion Recording",
-  "streamsConfig.onvifMotionRecordingHelp": "Record when the camera's built-in motion detection triggers. Uses ONVIF events from the camera.",
-  "streamsConfig.preEventBufferSeconds": "Pre-Event Buffer (seconds)",
-  "streamsConfig.preEventBufferHelp": "Video before motion event (0-30s)",
-  "streamsConfig.postEventBufferSeconds": "Post-Event Buffer (seconds)",
-  "streamsConfig.postEventBufferHelp": "Continue recording after motion (0-60s)",
-  "streamsConfig.maxFileDurationSeconds": "Max File Duration (seconds)",
-  "streamsConfig.maxFileDurationHelp": "Max duration per file (60-3600s)",
-  "streamsConfig.retentionPeriodDays": "Retention Period (days)",
-  "streamsConfig.retentionPeriodHelp": "Auto-delete after N days (1-365)",
-  "streamsConfig.recordingQuality": "Recording Quality",
-  "streamsConfig.triggerTestMotionEvent": "Trigger Test Motion Event",
   "streamsConfig.enablePtzControl": "Enable PTZ Control",
   "streamsConfig.enablePtzControlHelp": "Enable pan-tilt-zoom controls for this camera via ONVIF PTZ protocol",
   "streamsConfig.maxPanX": "Max Pan (X)",
@@ -910,12 +897,6 @@
   "streamsConfig.noRecording": "No recording",
   "streamsConfig.recordingActive": "Recording active",
   "streamsConfig.clickHeadersOrDragCells": "Click headers or drag cells",
-  "streams.motionConfigSaveFailed": "Motion config save failed: {message}",
-  "streams.setStreamNameAndSaveBeforeTestingMotion": "Please set a stream name and save before testing motion.",
-  "streams.enableOnvifCameraFirst": "Enable \"ONVIF Camera\" in Basic Settings first.",
-  "streams.testMotionEventTriggeredSuccessfully": "Test motion event triggered successfully.",
-  "streams.testMotionEventFailed": "Test motion event failed: {message}",
-  "streams.errorTriggeringTestMotion": "Error triggering test motion: {message}",
   "streams.errorLoadingStreamDetails": "Error loading stream details: {message}",
   "streams.errorDiscoveringOnvifDevices": "Error discovering ONVIF devices: {message}",
   "streams.errorLoadingDeviceProfiles": "Error loading device profiles: {message}",

web/public/locales/pt-BR.json

@@ -808,20 +808,7 @@
   "streamsConfig.zoneTipDrawPolygons": "Desenhe polígonos clicando em pontos na imagem",
   "streamsConfig.zoneTipIgnoreAreas": "Use zonas para ignorar áreas como árvores, estradas ou céu",
   "streamsConfig.zoneTipMultipleZones": "Múltiplas zonas podem ser configuradas para áreas diferentes",
-  "streamsConfig.motionRecordingOnvif": "Gravação por movimento (ONVIF)",
   "streamsConfig.onvifOnly": "Somente ONVIF",
-  "streamsConfig.enableOnvifMotionRecording": "Ativar gravação por movimento ONVIF",
-  "streamsConfig.onvifMotionRecordingHelp": "Grave quando a detecção de movimento embutida da câmera for acionada. Usa eventos ONVIF da câmera.",
-  "streamsConfig.preEventBufferSeconds": "Buffer pré-evento (segundos)",
-  "streamsConfig.preEventBufferHelp": "Vídeo antes do evento de movimento (0-30s)",
-  "streamsConfig.postEventBufferSeconds": "Buffer pós-evento (segundos)",
-  "streamsConfig.postEventBufferHelp": "Continuar gravando após o movimento (0-60s)",
-  "streamsConfig.maxFileDurationSeconds": "Duração máxima do arquivo (segundos)",
-  "streamsConfig.maxFileDurationHelp": "Duração máxima por arquivo (60-3600s)",
-  "streamsConfig.retentionPeriodDays": "Período de retenção (dias)",
-  "streamsConfig.retentionPeriodHelp": "Excluir automaticamente após N dias (1-365)",
-  "streamsConfig.recordingQuality": "Qualidade da gravação",
-  "streamsConfig.triggerTestMotionEvent": "Acionar evento de movimento de teste",
   "streamsConfig.enablePtzControl": "Ativar controle PTZ",
   "streamsConfig.enablePtzControlHelp": "Ativa controles de pan-tilt-zoom para esta câmera via protocolo PTZ ONVIF",
   "streamsConfig.maxPanX": "Pan máximo (X)",
@@ -864,12 +851,6 @@
   "streamsConfig.noRecording": "Sem gravação",
   "streamsConfig.recordingActive": "Gravação ativa",
   "streamsConfig.clickHeadersOrDragCells": "Clique nos cabeçalhos ou arraste as células",
-  "streams.motionConfigSaveFailed": "Falha ao salvar a configuração de movimento: {message}",
-  "streams.setStreamNameAndSaveBeforeTestingMotion": "Defina um nome para o stream e salve antes de testar o movimento.",
-  "streams.enableOnvifCameraFirst": "Ative \"Câmera ONVIF\" nas configurações básicas primeiro.",
-  "streams.testMotionEventTriggeredSuccessfully": "Evento de movimento de teste acionado com sucesso.",
-  "streams.testMotionEventFailed": "Falha no evento de movimento de teste: {message}",
-  "streams.errorTriggeringTestMotion": "Erro ao acionar o movimento de teste: {message}",
   "streams.errorLoadingStreamDetails": "Erro ao carregar os detalhes do stream: {message}",
   "streams.errorDiscoveringOnvifDevices": "Erro ao descobrir dispositivos ONVIF: {message}",
   "streams.errorLoadingDeviceProfiles": "Erro ao carregar perfis do dispositivo: {message}",