[CSAPI] Log response write errors thrown in sendError or

handleAuthException only at trace level

Author: alexrobin

common.gradle

@@ -1,6 +1,6 @@
 import java.nio.file.*;
 
-ext.oshCoreVersion = '2.0.0'
+ext.oshCoreVersion = '2.0.1'
 
 
 buildscript {

sensorhub-service-consys/src/main/java/org/sensorhub/impl/service/consys/RestApiServlet.java

@@ -30,6 +30,7 @@
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import org.eclipse.jetty.io.EofException;
 import org.eclipse.jetty.websocket.api.WebSocketBehavior;
 import org.eclipse.jetty.websocket.api.WebSocketPolicy;
 import org.eclipse.jetty.websocket.server.WebSocketServerFactory;
@@ -448,8 +449,11 @@ protected void logRequestInfo(HttpServletRequest req, Throwable error)
         if (req.getQueryString() != null)
             query = "?" + req.getQueryString();
 
-        if (error != null)
-            log.error(INTERNAL_ERROR_LOG_MSG, method, url, query, ip, user, error);
+        if (error != null) {
+            // log EofException (closed by client) only if trace level is enabled
+            if (!(error instanceof EofException) || log.isTraceEnabled())
+                log.error(INTERNAL_ERROR_LOG_MSG, method, url, query, ip, user, error);
+        }
         else
             log.info(LOG_REQUEST_MSG, method, url, query, ip, user);
     }
@@ -485,7 +489,8 @@ public void sendError(int code, String msg, HttpServletRequest req, HttpServletR
         }
         catch (IOException e)
         {
-            log.error("Could not send error response", e);
+            if (getLogger().isTraceEnabled())
+                log.error("Could not send error response", e);
         }
     }
 
@@ -528,7 +533,7 @@ protected void handleAuthException(HttpServletRequest req, HttpServletResponse r
     {
         try
         {
-            log.debug("Not authorized: {}", e.getMessage());
+            log.warn("Not authorized: {}", e.getMessage());
 
             if (req != null && resp != null)
             {
@@ -540,7 +545,8 @@ protected void handleAuthException(HttpServletRequest req, HttpServletResponse r
         }
         catch (Exception e1)
         {
-            getLogger().error("Could not send authentication request", e1);
+            if (getLogger().isTraceEnabled())
+                getLogger().error("Could not send authentication request", e1);
         }
     }