Skip to content

Fix elliott create cli#1615

Merged
locriandev merged 1 commit into
openshift-eng:mainfrom
locriandev:fix-elliott
May 15, 2025
Merged

Fix elliott create cli#1615
locriandev merged 1 commit into
openshift-eng:mainfrom
locriandev:fix-elliott

Conversation

@locriandev
Copy link
Copy Markdown
Contributor

@locriandev locriandev commented May 15, 2025 •
edited
Loading

Pinning click until pallets/click#2912 gets merged (ref. pallets/click#2897)

joepvd
joepvd approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@joepvd
Copy link
Copy Markdown
Contributor

joepvd commented May 15, 2025

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2025

New changes are detected. LGTM label has been removed.

@locriandev
Copy link
Copy Markdown
Contributor Author

locriandev commented May 15, 2025

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2025

@locriandev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2d7db28 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@locriandev locriandev merged commit 770d2c5 into openshift-eng:main May 15, 2025
1 of 3 checks passed
@locriandev locriandev deleted the fix-elliott branch May 15, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joepvd joepvd joepvd approved these changes

Assignees

@joepvd joepvd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@locriandev @joepvd