add comment handler#63
Open
neha037 wants to merge 4 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neha037 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 tasks
- Add resolved-thread filtering via GraphQL (skip already-resolved threads) - Add pure-acknowledgment filtering (skip LGTM, Thanks, +1 etc.) - Add PR commit messages to Claude's prompt for better context - Batch all pushes into single push after all threads processed - Add post-push SHA verification - Fix fork-based PRs: push to head repo (fork), not upstream - Add rebase before push with force-with-lease fallback - Add "reject invalid requests" guidance to SKILL.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
neha037
force-pushed
the
oape-review-handler
branch
from
2d47cb4 to
e019678
Compare
- C2: Added check_review_summary() function to check_replied.py that correctly checks for bot replies after a review submission (using REST API timestamps instead of mismatched GraphQL node IDs). Updated build_threads.py type_map to use the new review_summary type.
- C1: Kept -p flag (it works correctly for CI — tools still execute), updated docs to accurately describe print mode with tool use.
- C3: Removed all --max-turns 20 references from docs (flag doesn't exist in Claude CLI).
Important fixes:
- I1: Aligned SKILL.md exit code 2 handling with build_threads.py — both now treat it as "proceed with caution".
- I2: Fixed null-unsafe comment["user"]["login"] at two locations in check_replied.py to use .get() chains.
- I3: Replaced --force-with-lease fallback with safe failure — logs warning and exits instead of risking overwrite of concurrent commits.
- I4: Fork-based PRs now use a separate fork remote for push, keeping origin pointed at upstream so origin/${BASE_BRANCH} diffs still work.
Minor fixes:
- M1: Updated stale docs (push batching, allowed tools list, post-commit guardrails).
- M2: Changed missing python3 from exit 0 to exit 1 (it's a hard requirement).
- M3: Moved local tid out of the while loop body to function scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.