fix: remove obsolete SKIP_CONFIG_SYNC from doctor.sh

config-folder's sync refactor moved the sync call from common.sh
module scope to a Makefile prerequisite. SKIP_CONFIG_SYNC is now a
no-op — remove it. Cluster-type sync prerequisites are scoped to the
else branch so 'make doctor <type>' doesn't trigger them.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: fonta-rh

deploy/Makefile

@@ -77,7 +77,6 @@ inventory:
 
 # Sync config/ files to canonical locations before targets that consume them.
 create init redeploy-cluster \
-fencing-ipi fencing-agent arbiter-ipi arbiter-agent arbiter-kcli fencing-kcli sno-ipi sno-agent fencing-assisted \
 baremetal-adopt baremetal-fencing-agent: sync-config
 
 sync-config:
@@ -91,6 +90,7 @@ ifeq (doctor,$(firstword $(MAKECMDGOALS)))
 $(VALID_CLUSTER_TYPES):
 	@:
 else
+$(VALID_CLUSTER_TYPES): sync-config
 fencing-ipi:
 	@./openshift-clusters/scripts/deploy-cluster.sh --topology fencing --method ipi
 
@@ -163,7 +163,7 @@ help:
 	@echo "  keep-instance        - Tag instance with keep-N retention (default: 2, max: 5)"
 	@echo "                         Usage: make keep-instance or make keep-instance DAYS=5"
 	@echo "  sync-config          - Sync files from config/ to their canonical locations"
-	@echo "                         (runs automatically before deploy and lifecycle targets)"
+	@echo "                         (runs automatically before deploy and cluster targets)"
 	@echo ""
 	@echo "OpenShift Cluster Deployment:"
 	@echo "  fencing-ipi          - Deploy fencing IPI cluster (non-interactive)"

deploy/openshift-clusters/scripts/doctor.sh

@@ -19,10 +19,8 @@ REPO_ROOT="$(cd "${DEPLOY_DIR}/.." && pwd)"
 CONFIG_DIR="${REPO_ROOT}/config"
 INSTANCE_ENV="${DEPLOY_DIR}/aws-hypervisor/instance.env"
 
-# SKIP_CONFIG_SYNC: doctor is read-only — suppress the automatic config sync.
-# SKIP_INSTANCE_ENV_WARNING: doctor has its own instance.env section with
-# better guidance, so suppress the generic warning from common.sh.
-export SKIP_CONFIG_SYNC=1
+# Suppress the generic instance.env warning from common.sh — doctor has its
+# own instance.env section with better guidance.
 export SKIP_INSTANCE_ENV_WARNING=1
 # shellcheck source=/dev/null
 source "${DEPLOY_DIR}/common.sh"