HYPERFLEET-1141 - docs: polish code-review standards#149
Conversation
…aden ERR-03 Add exception for read-only defer close (resp.Body.Close(), rows.Close()) where error is not actionable — MAY use bare defer without blank identifier. Resolves unresolved PR openshift-hyperfleet#147 nit from pnguyen44. Broaden ERR-03 from stdlib-only (http.Error, w.WriteHeader) to framework-agnostic principle covering any error-response write.
Restructure CONC-03 so Go 1.22+ skip is the first thing reviewers see, not buried in a Note after the MUST. Go 1.22 introduced per-iteration scoping that eliminates loop variable capture bugs.
…ches Document that all repos use test/integration/ directory, some additionally use //go:build integration build tags. Both patterns valid. Reviewers MUST NOT flag one approach when the project consistently uses the other.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThis PR updates three HyperFleet Go code review standard documents. The concurrency standard clarifies that CONC-03 (loop variable capture) does not apply to Go 1.22+ projects and requires reviewers to verify Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
/retest |
1 participant
Summary
Test Plan
make test-allpassesmake lintpassesmake test-helm(if applicable)