HYPERFLEET-1017 - fix: use ConditionTypeLastKnownReconciled in sticky-break test

rafabene · rafabene · commit 90028f801f6c · 2026-05-08T16:31:00.000-03:00
The test was using ConditionTypeAvailable in prevConds, but
parsePrevConditions looks for ConditionTypeLastKnownReconciled.
Without this fix the test passed incidentally but didn't exercise
the sticky-break logic.
diff --git a/pkg/services/aggregation_test.go b/pkg/services/aggregation_test.go
@@ -1209,7 +1209,7 @@ func TestAggregateResourceStatus(t *testing.T) {
 		required := []string{"a", "b"}
 		prevConds := encodePrev(
 			api.ResourceCondition{
-				Type: api.ConditionTypeAvailable, Status: api.ConditionTrue, ObservedGeneration: 1,
+				Type: api.ConditionTypeLastKnownReconciled, Status: api.ConditionTrue, ObservedGeneration: 1,
 				CreatedTime: aggT0, LastUpdatedTime: aggT0, LastTransitionTime: aggT0,
 			},
 		)

Original file line number	Diff line number	Diff line change
`@@ -1209,7 +1209,7 @@ func TestAggregateResourceStatus(t *testing.T) {`
`1209`	`1209`	`required := []string{"a", "b"}`
`1210`	`1210`	`prevConds := encodePrev(`
`1211`	`1211`	`api.ResourceCondition{`
`1212`		`- Type: api.ConditionTypeAvailable, Status: api.ConditionTrue, ObservedGeneration: 1,`
	`1212`	`+ Type: api.ConditionTypeLastKnownReconciled, Status: api.ConditionTrue, ObservedGeneration: 1,`
`1213`	`1213`	`CreatedTime: aggT0, LastUpdatedTime: aggT0, LastTransitionTime: aggT0,`
`1214`	`1214`	`},`
`1215`	`1215`	`)`