HYPERFLEET-1017 - refactor: rename aggregated Available condition to LastKnownReconciled

Co-Authored-By: Claude <noreply@anthropic.com>

Author: rafabene

openapi/openapi.yaml

@@ -50,7 +50,7 @@ paths:
 
         **Note**: The `status` object in the response is read-only and computed by the service.
         It is NOT part of the request body. Initially,
-        status.conditions will include mandatory "Available", "Ready" and "Reconciled" conditions.
+        status.conditions will include mandatory "LastKnownReconciled", "Ready" and "Reconciled" conditions.
       parameters: []
       responses:
         '201':
@@ -189,7 +189,7 @@ paths:
                       created_time: '2021-01-01T10:00:00Z'
                       last_updated_time: '2021-01-01T10:00:00Z'
                       last_transition_time: '2021-01-01T10:00:00Z'
-                    - type: Available
+                    - type: LastKnownReconciled
                       status: 'True'
                       reason: All adapters reported Available True for the same generation
                       message: All adapters reported Available True for the same generation
@@ -394,7 +394,7 @@ paths:
                       created_time: '2021-01-01T10:00:00Z'
                       last_updated_time: '2021-01-01T10:00:00Z'
                       last_transition_time: '2021-01-01T10:00:00Z'
-                    - type: Available
+                    - type: LastKnownReconciled
                       status: 'True'
                       reason: All adapters reported Available True for the same generation
                       message: All adapters reported Available True for the same generation
@@ -1075,7 +1075,7 @@ components:
               created_time: '2021-01-01T10:00:00Z'
               last_updated_time: '2021-01-01T10:00:00Z'
               last_transition_time: '2021-01-01T10:00:00Z'
-            - type: Available
+            - type: LastKnownReconciled
               status: 'True'
               reason: All adapters reported Available True for the same generation
               message: All adapters reported Available True for the same generation
@@ -1199,7 +1199,7 @@ components:
             **Mandatory conditions**: 
             - `type: "Ready"` *(deprecated — use Reconciled)*: Whether all adapters report successfully at the current generation.
             - `type: "Reconciled"`: Whether the resource's desired state has been fully reconciled by all adapters at the current generation.
-            - `type: "Available"`: Aggregated adapter result for a common observed_generation.   
+            - `type: "LastKnownReconciled"`: Aggregated adapter result for a common observed_generation. Sticky — stays True as long as all required adapters were reconciled at a common observed generation, even if a new generation is being processed.
 
             These conditions are present immediately upon resource creation.
       description: |-
@@ -1374,7 +1374,7 @@ components:
               created_time: '2021-01-01T10:00:00Z'
               last_updated_time: '2021-01-01T10:00:00Z'
               last_transition_time: '2021-01-01T10:00:00Z'
-            - type: Available
+            - type: LastKnownReconciled
               status: 'True'
               reason: All adapters reported Available True for the same generation
               message: All adapters reported Available True for the same generation
@@ -1565,7 +1565,7 @@ components:
             **Mandatory conditions**: 
             - `type: "Ready"` *(deprecated — use Reconciled)*: Whether all adapters report successfully at the current generation.
             - `type: "Reconciled"`: Whether the resource's desired state has been fully reconciled by all adapters at the current generation.
-            - `type: "Available"`: Aggregated adapter result for a common observed_generation.   
+            - `type: "LastKnownReconciled"`: Aggregated adapter result for a common observed_generation. Sticky — stays True as long as all required adapters were reconciled at a common observed generation, even if a new generation is being processed.
 
             These conditions are present immediately upon resource creation.
       description: |-

pkg/api/status_types.go

@@ -28,12 +28,13 @@ func (s AdapterConditionStatus) IsValid() bool {
 
 // Condition type constants
 const (
-	ConditionTypeAvailable  = "Available"
-	ConditionTypeApplied    = "Applied"
-	ConditionTypeHealth     = "Health"
-	ConditionTypeReady      = "Ready"
-	ConditionTypeReconciled = "Reconciled"
-	ConditionTypeFinalized  = "Finalized"
+	ConditionTypeAvailable           = "Available"
+	ConditionTypeLastKnownReconciled = "LastKnownReconciled"
+	ConditionTypeApplied             = "Applied"
+	ConditionTypeHealth              = "Health"
+	ConditionTypeReady               = "Ready"
+	ConditionTypeReconciled          = "Reconciled"
+	ConditionTypeFinalized           = "Finalized"
 )
 
 // ResourceCondition represents a condition of a resource

pkg/services/aggregation.go

@@ -25,7 +25,7 @@ const (
 )
 
 // fixedConditionCount is the number of top-level conditions always present in resource status:
-// Ready (deprecated), Reconciled, and Available.
+// Ready (deprecated), Reconciled, and LastKnownReconciled.
 const fixedConditionCount = 3
 
 // reasonMissingRequiredAdapters is the reason code for the Ready condition when one or more
@@ -52,7 +52,7 @@ func ValidateMandatoryConditions(conditions []api.AdapterCondition) (errorType,
 	return "", ""
 }
 
-// --- Aggregated Ready / Available -------------------------------------------------
+// --- Aggregated Reconciled / LastKnownReconciled ----------------------------------
 
 // adapterConditionSuffixMap allows overriding the default suffix for specific adapters (reserved).
 var adapterConditionSuffixMap = map[string]string{}
@@ -107,7 +107,7 @@ func AdapterObservedTime(as *api.AdapterStatus) time.Time {
 	return as.LastReportTime
 }
 
-// AggregateResourceStatus computes Reconciled, Available, and per-adapter conditions from stored adapter
+// AggregateResourceStatus computes Reconciled, LastKnownReconciled, and per-adapter conditions from stored adapter
 // rows and previous conditions. It does not use wall clock.
 //
 // The returned adapterConditions slice contains one entry per required adapter that has reported,
@@ -128,7 +128,7 @@ func AggregateResourceStatus(ctx context.Context, in AggregateResourceStatusInpu
 		reports,
 		in.HasChildResources,
 	)
-	available = computeAvailable(
+	available = computeLastKnownReconciled(
 		in.RefTime,
 		prevAvail,
 		in.RequiredAdapters,
@@ -163,6 +163,11 @@ func parsePrevConditions(ctx context.Context, raw []byte) (
 		case api.ConditionTypeReconciled:
 			prevReconciled = &c
 		case api.ConditionTypeAvailable:
+			// Migration: legacy records stored this as "Available"
+			if prevAvail == nil {
+				prevAvail = &c
+			}
+		case api.ConditionTypeLastKnownReconciled:
 			prevAvail = &c
 		default:
 			prevAdapterByType[c.Type] = &c
@@ -423,14 +428,14 @@ func computeReadyLastTransitionTime(
 	return newLastUpdated
 }
 
-// computeAvailableStatus decides the Available condition status from normalized adapter snapshots.
+// computeLastKnownReconciledStatus decides the LastKnownReconciled condition status from normalized adapter snapshots.
 //
 // Rules (in order):
 //  1. No required adapters, or any required adapter has not yet reported → False.
 //  2. All adapters True at a uniform generation, or mixed-gen but aggregate was already True → True.
 //  3. Some adapter is False, but aggregate was True and no False is at the tracked generation → True (sticky).
 //  4. Otherwise → False.
-func computeAvailableStatus(
+func computeLastKnownReconciledStatus(
 	prev *api.ResourceCondition,
 	required []string,
 	byAdapter map[string]adapterAvailableSnapshot,
@@ -469,18 +474,18 @@ func computeAvailableStatus(
 	return api.ConditionTrue
 }
 
-func computeAvailable(
+func computeLastKnownReconciled(
 	refTime time.Time,
 	prev *api.ResourceCondition,
 	required []string,
 	byAdapter map[string]adapterAvailableSnapshot,
 ) api.ResourceCondition {
 	allTrue, commonGen, mixed := sameGenerationAllTrue(required, byAdapter)
-	status := computeAvailableStatus(prev, required, byAdapter, allTrue, mixed)
+	status := computeLastKnownReconciledStatus(prev, required, byAdapter, allTrue, mixed)
 
-	obsGen := computeAvailableObservedGeneration(status, prev, required, byAdapter, allTrue, commonGen, mixed)
+	obsGen := computeLastKnownReconciledObservedGeneration(status, prev, required, byAdapter, allTrue, commonGen, mixed)
 
-	lastUpdated := computeAvailableLastUpdatedTime(
+	lastUpdated := computeLastKnownReconciledLastUpdatedTime(
 		status, prev, refTime, required, byAdapter, obsGen, allTrue, mixed,
 	)
 	lastTransition := computeGenericLastTransitionTime(prev, status, lastUpdated)
@@ -498,7 +503,7 @@ func computeAvailable(
 	}
 
 	return api.ResourceCondition{
-		Type:               api.ConditionTypeAvailable,
+		Type:               api.ConditionTypeLastKnownReconciled,
 		Status:             status,
 		ObservedGeneration: obsGen,
 		Reason:             strPtr(reason),
@@ -533,7 +538,7 @@ func sameGenerationAllTrue(
 	return true, *g, mixed
 }
 
-func computeAvailableObservedGeneration(
+func computeLastKnownReconciledObservedGeneration(
 	status api.ResourceConditionStatus,
 	prev *api.ResourceCondition,
 	required []string,
@@ -576,7 +581,7 @@ func computeAvailableObservedGeneration(
 	return maxG
 }
 
-func computeAvailableLastUpdatedTime(
+func computeLastKnownReconciledLastUpdatedTime(
 	status api.ResourceConditionStatus,
 	prev *api.ResourceCondition,
 	refTime time.Time,