HYPERFLEET-930 - docs: rewrite CLAUDE.md as AGENTS.md#42
Conversation
Audit and rewrite agent instructions. CLAUDE.md now imports AGENTS.md. Fixes incorrect defaults (REGISTRY, IMAGE_TAG), wrong validation command, removes redundant sections, adds verified gotchas and source-of-truth table.
Add .pre-commit-config.yaml with hyperfleet-commitlint hook matching sentinel/api/adapter repos. Add install-hooks and fmt Makefile targets.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR establishes a complete developer environment setup for the HyperFleet infrastructure repository. It introduces Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 452-454: Update the Makefile so the install-hooks target depends
on a new check-pre-commit prerequisite: add "check-pre-commit" as a prerequisite
of install-hooks and implement a check-pre-commit target that verifies the
external tool "pre-commit" is available (e.g., using a shell check like command
-v pre-commit and failing with a clear message if missing). Reference the
Makefile target names install-hooks and check-pre-commit when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 70d2e303-728a-4a46-b3c9-f586bbb3a8df
📒 Files selected for processing (4)
.pre-commit-config.yamlAGENTS.mdCLAUDE.mdMakefile
…dation
Adapter chart v2.0.0 requires broker.rabbitmq.{url,queue,exchange,routingKey}
when broker type is rabbitmq. ci-dry-run validates both broker types but
never passed these fields for adapters, breaking helm template rendering.
Summary
Test Plan
make test-allpassesmake lintpassesmake test-helm(if applicable)