HYPERFLEET-1017 - refactor: update tests and mocks for LastKnownReconciled rename

The HyperFleet API renamed the aggregated Available condition to
LastKnownReconciled. Update all test fixtures, CEL expressions,
and the mock API server to match.

Author: rafabene

internal/client/client_test.go

@@ -41,7 +41,7 @@ func createMockCluster(id string) map[string]interface{} {
 					"observed_generation":  5,
 				},
 				{
-					"type":                 "Available",
+					"type":                 "LastKnownReconciled",
 					"status":               "True",
 					"created_time":         "2025-01-01T09:00:00Z",
 					"last_transition_time": "2025-01-01T10:00:00Z",
@@ -587,7 +587,7 @@ func TestFetchResources_NodePools(t *testing.T) {
 								"observed_generation":  3,
 							},
 							{
-								"type":                 "Available",
+								"type":                 "LastKnownReconciled",
 								"status":               "True",
 								"created_time":         "2025-01-01T09:00:00Z",
 								"last_transition_time": "2025-01-01T10:00:00Z",

internal/config/config_test.go

@@ -590,7 +590,7 @@ func TestTopologicalSort_NoDependencies(t *testing.T) {
 	md := &MessageDecisionConfig{
 		Params: map[string]string{
 			"a": `condition("Ready").status`,
-			"b": `condition("Available").status`,
+			"b": `condition("LastKnownReconciled").status`,
 		},
 		Result: "a == b",
 	}

internal/engine/decision_test.go

@@ -338,7 +338,7 @@ func TestDecisionEngine_Evaluate_CustomExpressions(t *testing.T) {
 	t.Run("condition function with custom condition name", func(t *testing.T) {
 		cfg := &config.MessageDecisionConfig{
 			Params: map[string]string{
-				"is_available": `condition("Available").status == "True"`,
+				"is_available": `condition("LastKnownReconciled").status == "True"`,
 			},
 			Result: "is_available",
 		}
@@ -353,17 +353,17 @@ func TestDecisionEngine_Evaluate_CustomExpressions(t *testing.T) {
 			Generation: 1,
 			Status: client.ResourceStatus{
 				Conditions: []client.Condition{
-					{Type: "Available", Status: "True", LastUpdatedTime: now},
+					{Type: "LastKnownReconciled", Status: "True", LastUpdatedTime: now},
 				},
 			},
 		}
 
 		decision := engine.Evaluate(resource, now)
 		if !decision.ShouldPublish {
-			t.Error("expected ShouldPublish=true for Available=True condition")
+			t.Error("expected ShouldPublish=true for LastKnownReconciled=True condition")
 		}
 
-		// Missing Available condition → zero-value → status="" → false
+		// Missing LastKnownReconciled condition → zero-value → status="" → false
 		resource2 := &client.Resource{
 			ID:         testResourceID,
 			Kind:       testResourceKind,
@@ -377,7 +377,7 @@ func TestDecisionEngine_Evaluate_CustomExpressions(t *testing.T) {
 
 		decision2 := engine.Evaluate(resource2, now)
 		if decision2.ShouldPublish {
-			t.Error("expected ShouldPublish=false when Available condition is missing")
+			t.Error("expected ShouldPublish=false when LastKnownReconciled condition is missing")
 		}
 	})
 }
@@ -466,7 +466,7 @@ func TestBuildConditionsLookup(t *testing.T) {
 			ObservedGeneration: 3,
 		},
 		{
-			Type:               "Available",
+			Type:               "LastKnownReconciled",
 			Status:             "False",
 			LastUpdatedTime:    now.Add(-5 * time.Minute),
 			LastTransitionTime: now.Add(-10 * time.Minute),
@@ -491,12 +491,12 @@ func TestBuildConditionsLookup(t *testing.T) {
 		t.Errorf("Ready observed_generation = %v, want 3", ready["observed_generation"])
 	}
 
-	avail, ok := lookup["Available"]
+	avail, ok := lookup["LastKnownReconciled"]
 	if !ok {
-		t.Fatal("missing Available condition")
+		t.Fatal("missing LastKnownReconciled condition")
 	}
 	if avail["status"] != "False" {
-		t.Errorf("Available status = %v, want False", avail["status"])
+		t.Errorf("LastKnownReconciled status = %v, want False", avail["status"])
 	}
 }
 

test/integration/integration_test.go

@@ -86,7 +86,7 @@ func createMockClusterWithLabels(id string, generation int, observedGeneration i
 			"conditions": []map[string]interface{}{
 				readyCondition,
 				{
-					"type":                 "Available",
+					"type":                 "LastKnownReconciled",
 					"status":               readyStatus,
 					"created_time":         "2025-01-01T09:00:00Z",
 					"last_transition_time": "2025-01-01T10:00:00Z",

test/mock-hyperfleet-api/main.go

@@ -269,7 +269,7 @@ func buildConditions(generation int32) []map[string]any {
 	conditions := []map[string]any{
 		makeCondition("Ready", "True", "AllAdaptersReady",
 			"All adapters reported Ready True for the current generation"),
-		makeCondition("Available", "True", "AllAdaptersAvailable",
+		makeCondition("LastKnownReconciled", "True", "AllAdaptersAvailable",
 			"All adapters reported Available True for the same generation"),
 	}