cnf-tests: Remove metallb-operator submodule and all metallb references#4027
Open
sshnaidm wants to merge 1 commit into
Open
cnf-tests: Remove metallb-operator submodule and all metallb references#4027sshnaidm wants to merge 1 commit into
sshnaidm wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sshnaidm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughRemoves MetalLB operator support: deletes the git submodule and operator manifests, omits metallb from default FEATURES and build/index flows, updates init and CI scripts, removes MetalLB test namespaces and reporter entries, and updates docs and test infra references. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cnf-tests/README.md (1)
18-29:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix stale env-var count in release guidance.
Line 28 says “all three,” but only two variables are now listed. This is a confusing docs mismatch.
Suggested doc fix
-And to set all three of them to a specfic release, use `TARGET_RELEASE`. +And to set both of them to a specific release, use `TARGET_RELEASE`.As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cnf-tests/README.md` around lines 18 - 29, The README text incorrectly says “all three” when only two environment variables (SRIOV_NETWORK_OPERATOR_TARGET_COMMIT and CLUSTER_NODE_TUNING_OPERATOR_TARGET_COMMIT) are listed; update the sentence referencing TARGET_RELEASE to say it sets both of these variables (or “both” instead of “all three”) and ensure the wording matches the two variable names shown (e.g., "And to set both of them to a specific release, use TARGET_RELEASE.").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@cnf-tests/README.md`:
- Around line 18-29: The README text incorrectly says “all three” when only two
environment variables (SRIOV_NETWORK_OPERATOR_TARGET_COMMIT and
CLUSTER_NODE_TUNING_OPERATOR_TARGET_COMMIT) are listed; update the sentence
referencing TARGET_RELEASE to say it sets both of these variables (or “both”
instead of “all three”) and ensure the wording matches the two variable names
shown (e.g., "And to set both of them to a specific release, use
TARGET_RELEASE.").
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: e77e8907-0fe5-4a66-88cd-aa43b73ea36e
📒 Files selected for processing (18)
.gitmodulesMakefilecnf-tests/README.mdcnf-tests/hack/init-git-submodules.shcnf-tests/submodules/metallb-operatorcnf-tests/testsuites/pkg/namespaces/namespaces.gocnf-tests/testsuites/pkg/utils/reporter.gofeature-configs/ci/metallb/kustomization.yamlfeature-configs/ci/metallb/operator_subscription.yamlfeature-configs/deploy/metallb/kustomization.yamlfeature-configs/deploy/metallb/operator_namespace.yamlfeature-configs/deploy/metallb/operator_operatorgroup.yamlfeature-configs/deploy/metallb/operator_subscription.yamlfeature-configs/hypershift-ci/metallb/kustomization.yamlfeature-configs/hypershift-ci/metallb/operator_subscription.yamlhack/common.shhack/run-functests.shhack/setup-build-index-image.sh
💤 Files with no reviewable changes (13)
- cnf-tests/testsuites/pkg/namespaces/namespaces.go
- feature-configs/ci/metallb/operator_subscription.yaml
- feature-configs/ci/metallb/kustomization.yaml
- feature-configs/deploy/metallb/kustomization.yaml
- feature-configs/hypershift-ci/metallb/kustomization.yaml
- cnf-tests/testsuites/pkg/utils/reporter.go
- feature-configs/deploy/metallb/operator_operatorgroup.yaml
- .gitmodules
- feature-configs/hypershift-ci/metallb/operator_subscription.yaml
- feature-configs/deploy/metallb/operator_subscription.yaml
- hack/common.sh
- feature-configs/deploy/metallb/operator_namespace.yaml
- cnf-tests/submodules/metallb-operator
MetalLB is no longer needed in this repository. This removes the git submodule, feature-configs, test paths, namespace variables, and all related script/documentation references.
sshnaidm
changed the title
Contributor
Author
|
/retest |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetalLB is no longer needed in this repository. This removes the git submodule, feature-configs, test paths, namespace variables, and all related script/documentation references.