OCPBUGS-12988: controller: nrop: force degraded status if ExporterImage is set

ExporterImage is an escape hatch we had from day0 but which we never
really leveraged. It made on the stable API and we can't deprecate
it anytime soon, but we can at least narrow down
the perimeter and make it obvious and loud it should not be used.

Force the status to Degraded if the ExporterImage is set by the user.

Signed-off-by: Francesco Romani <fromani@redhat.com>

Author: ffromani

internal/controller/numaresourcesoperator_controller.go

@@ -189,6 +189,10 @@ func (r *NUMAResourcesOperatorReconciler) Reconcile(ctx context.Context, req ctr
 		return r.degradeStatus(ctx, initialInstance, instance, tolerable.Reason, tolerable.Error)
 	}
 
+	if step.Done() && instance.Spec.ExporterImage != "" {
+		return r.degradeStatusf(ctx, initialInstance, instance, status.ConditionTypeCustomUserImage, "custom operand image set: %s", instance.Spec.ExporterImage)
+	}
+
 	if err := r.Client.Status().Patch(ctx, instance, client.MergeFrom(initialInstance)); err != nil {
 		klog.InfoS("Failed to update numaresources-operator status", "error", err)
 		return ctrl.Result{}, err

internal/controller/numaresourcesoperator_controller_test.go

@@ -192,6 +192,31 @@ var _ = Describe("Test NUMAResourcesOperator Reconcile", func() {
 			})
 		})
 
+		Context("with custom ExporterImage set", func() {
+			It("should update the CR condition to degraded", func(ctx context.Context) {
+				pn := "test"
+				ng := nropv1.NodeGroup{
+					PoolName: &pn,
+				}
+				nro := testobjs.NewNUMAResourcesOperator(objectnames.DefaultNUMAResourcesOperatorCrName, ng)
+				nro.Spec.ExporterImage = "quay.io/custom/image:latest"
+
+				labSel := &metav1.LabelSelector{
+					MatchLabels: map[string]string{pn: pn},
+				}
+				mcp := testobjs.NewMachineConfigPool(pn, labSel.MatchLabels, labSel, labSel)
+
+				reconciler, err := NewFakeNUMAResourcesOperatorReconciler(platf, defaultOCPVersion, nro, mcp)
+				Expect(err).ToNot(HaveOccurred())
+
+				key := client.ObjectKeyFromObject(nro)
+				Expect(reconciler.Reconcile(ctx, reconcile.Request{NamespacedName: key})).ToNot(CauseRequeue())
+
+				Expect(reconciler.Client.Get(ctx, key, nro)).ToNot(HaveOccurred())
+				Expect(nro).To(BeDegradedWithReason(status.ConditionTypeCustomUserImage))
+			})
+		})
+
 		Context("with default RTE SELinux and PoolName set", func() {
 			Context("with correct NRO and more than one NodeGroup", func() {
 				var nro *nropv1.NUMAResourcesOperator

pkg/status/status.go

@@ -54,6 +54,7 @@ const (
 
 const (
 	ConditionTypeIncorrectNUMAResourcesOperatorResourceName = "IncorrectNUMAResourcesOperatorResourceName"
+	ConditionTypeCustomUserImage                            = "CustomUserImage"
 )
 
 const (