release-4.20: status: set ObservedGeneration in all status conds#2722
Conversation
openshift-ci
Bot
added
the
approved
ffromani
force-pushed
the
remove-owned-by-4.20
branch
from
83d698d to
9aa0430
Compare
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
xref: #2732 |
The NUMAResourcesScheduler (sic: 4.20 note: we actually change NUMAResourcesOperator) object status condition never reports ObservedGeneration in any status conditions, unlike the scheduler object. Likewise the scheduler change, let's expose it in all the relevant conditions, doing some minimal internal refactoring along the way. Note that we can't test this change using controller tests due both the unique requirements of the operator and the way we (mis)use the controller tests Note: this is a release-4.20-specific backport of commit d223bda We intentionally avoid any e2e change, stripping them from this commit, and we add the `operobsgen` topic among the actives. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
remove-owned-by-4.20
branch
from
9aa0430 to
65cb95c
Compare
|
/retest |
|
/hold cancel it seems we prefer this over #2732 |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
keep backport to 4.18? |
yes, we can still move forward with that |
|
/cherry-pick release-4.19 |
|
@ffromani: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ffromani: new pull request created: #4029 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
The NUMAResourcesScheduler (sic: 4.20 note: we actually change NUMAResourcesOperator) object status condition never reports ObservedGeneration in any status conditions, unlike the scheduler object.
Likewise the scheduler change, let's expose it in all the relevant conditions, doing some minimal internal refactoring along the way.
Note that we can't test this change using controller tests due both the unique requirements of the operator and the way we (mis)use the controller tests; we should add checks in (existing?) e2e tests, but we postpone this to a later change.
Note: this is a release-4.20-specific backport of
commit d223bda