WIP: serial: enhance TMScope tests to support compact cluster resources#2733
Open
shajmakh wants to merge 2 commits into
Open
WIP: serial: enhance TMScope tests to support compact cluster resources#2733shajmakh wants to merge 2 commits into
shajmakh wants to merge 2 commits into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
shajmakh
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Some set of the serial suite expects to have the resources set on the node in a specific way ahead of running the suite. The tests are various and are configured requesting specific amount of resources to be available on the cluster node before running the test worloads. The values of the amounts are hardcoded and that is by design. The problem with this is mainly the baseload (consumed node resources that do not relate to the test). On compact clusters the baseload is normally greater than on regular MNO. And when the test runs with old hardcoded resources values, it considers a greater baseload than usually is on regular MNO (initiialy tests were built depending on this kind of clusters), and that affects the amount of free resources that should be left free on the node(s), causing to shake the "working" hardcoded values. This results in tests failing due to unexpected behavior on compact clusters. In this commit we consolidate tests that run on diffirent TM scopes but they both expect same results (single container does not make a difference). Also we adjust the hardcoded values to ensure high enough gap to keep the test stable. Having a ratios of current node resources is problamatic because it needs to be rounded and doesn't eventually turn out to fit into the node and in many cases messes up the intented scenario. The best we can do while still have full control over the requested resources and the padding resources is tweak the resources amounts to the minimum but stable as possible so that it can fit to run on compact clusters. We prefer to have full control with logs over having automatically computed resources especially when the cases and resources are very diverse, which is good and makes a better coverage and that we want to keep. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
shajmakh
force-pushed
the
enhance-serial-nov2025
branch
from
a48e446 to
8a992cd
Compare
Signed-off-by: Shereen Haj <shajmakh@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD