Skip to content

[release-4.14] Makefile: bump setup-envtest to release-0.19#3682

Open
yanirq wants to merge 1 commit into
openshift-kni:release-4.14from
yanirq:bump_setup-envtest_4.14
Open

[release-4.14] Makefile: bump setup-envtest to release-0.19#3682
yanirq wants to merge 1 commit into
openshift-kni:release-4.14from
yanirq:bump_setup-envtest_4.14

Conversation

@yanirq

@yanirq yanirq commented Apr 20, 2026

Copy link
Copy Markdown
Member

Manual cherrypick of #3270

The GCS bucket (storage.googleapis.com/kubebuilder-tools) used by setup-envtest release-0.18 to download envtest binaries is deprecated and now returns 401 Unauthorized, causing controller tests to fail.

Release-0.19 downloads binaries from the new location (GitHub releases) as recommended by the kubebuilder maintainers.

Ref: kubernetes-sigs/kubebuilder#4082

The GCS bucket (storage.googleapis.com/kubebuilder-tools) used by
setup-envtest release-0.18 to download envtest binaries is deprecated
and now returns 401 Unauthorized, causing controller tests to fail.

Release-0.19 downloads binaries from the new location (GitHub releases)
as recommended by the kubebuilder maintainers.

Ref: kubernetes-sigs/kubebuilder#4082

Signed-off-by: Yanir Quinn <yquinn@redhat.com>
@openshift-ci
openshift-ci Bot requested review from shajmakh and swatisehgal April 20, 2026 10:59
@openshift-ci

openshift-ci Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026
@yanirq

yanirq commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

/cc @ffromani

@openshift-ci
openshift-ci Bot requested a review from ffromani April 20, 2026 11:00
@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d5dad09-3a74-4f0a-ac96-6fd85b0c3a28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@yanirq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-unit 6f430c2 link true /test ci-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@ffromani

Copy link
Copy Markdown
Member

the unit test failure is real: go: sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.19 (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20250308055145-5fe7bb3edc86): go.mod:3: invalid go version '1.22.0': must match format 1.23

meaning we need to update our toolchain if we want to consume this change

@yanirq

yanirq commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants