[release-4.14] Makefile: bump setup-envtest to release-0.19#3682
Conversation
The GCS bucket (storage.googleapis.com/kubebuilder-tools) used by setup-envtest release-0.18 to download envtest binaries is deprecated and now returns 401 Unauthorized, causing controller tests to fail. Release-0.19 downloads binaries from the new location (GitHub releases) as recommended by the kubebuilder maintainers. Ref: kubernetes-sigs/kubebuilder#4082 Signed-off-by: Yanir Quinn <yquinn@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @ffromani |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@yanirq: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
the unit test failure is real: go: sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.19 (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20250308055145-5fe7bb3edc86): go.mod:3: invalid go version '1.22.0': must match format 1.23 meaning we need to update our toolchain if we want to consume this change |
|
/hold |
Manual cherrypick of #3270
The GCS bucket (storage.googleapis.com/kubebuilder-tools) used by setup-envtest release-0.18 to download envtest binaries is deprecated and now returns 401 Unauthorized, causing controller tests to fail.
Release-0.19 downloads binaries from the new location (GitHub releases) as recommended by the kubebuilder maintainers.
Ref: kubernetes-sigs/kubebuilder#4082