Skip to content

Commit b846cb2

Browse files
committed
Remove CA issuer reference CRs per review feedback
ACME remains the reference recommendation. CA issuer (and other issuer types) are noted as allowable alternatives, but no reference CRs are shipped for non-ACME issuers. Users may configure their own. Hub-spoke trust (KlusterletConfig, CA ConfigMap), root CA expiration monitoring, and kubeconfig trust documentation are retained — these are issuer-agnostic.
1 parent 644fd05 commit b846cb2

12 files changed

Lines changed: 18 additions & 101 deletions

File tree

telco-core/configuration/reference-crs-kube-compare/compare_ignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,3 @@ custom-manifests/subscription-validator.yaml
3939
# This is an object-template-raw used only to validate pre-caching state
4040
custom-manifests/precache-validator.yaml
4141

42-
# cert-manager config CRs (user-specific)
43-
optional/cert-manager/certManagerClusterIssuerCA.yaml

telco-core/configuration/reference-crs-kube-compare/optional/cert-manager/certManagerClusterIssuerCA.yaml

Lines changed: 0 additions & 8 deletions
This file was deleted.

telco-core/configuration/reference-crs/optional/cert-manager/README.md

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ Cert-manager automates the management and issuance of TLS certificates from vari
1818

1919
### Certificate Issuers
2020

21-
Two ClusterIssuer types are available. Choose one based on your environment:
22-
23-
- `certManagerClusterIssuer.yaml` - **ACME issuer** using Let's Encrypt with DNS-01 challenge (requires internet connectivity)
24-
- `certManagerClusterIssuerCA.yaml` - **CA issuer** using an internal certificate authority (disconnected environments with existing PKI)
21+
- `certManagerClusterIssuer.yaml` - **ACME issuer** using Let's Encrypt with DNS-01 challenge (reference recommendation)
2522

2623
### Certificate Resources
2724
- `apiServerCertificate.yaml` - Creates a certificate for the API Server endpoint
@@ -35,18 +32,13 @@ Two ClusterIssuer types are available. Choose one based on your environment:
3532

3633
Before applying these configurations, you must customize the following:
3734

38-
1. **ClusterIssuer** — choose one of the following issuer configurations:
39-
40-
**Option A: ACME issuer** (`certManagerClusterIssuer.yaml`) — for connected environments:
35+
1. **ClusterIssuer** (`certManagerClusterIssuer.yaml`):
4136
- Update `email` with your contact email
4237
- Configure the appropriate DNS provider for DNS-01 challenge (example shows Route53)
4338
- Reference pre-created Secrets for DNS provider credentials via `secretRef` — do not commit credentials in manifests
4439

45-
**Option B: Existing internal CA** (disconnected environments with existing PKI):
46-
- This issuer does **not** generate its own CA — it requires a pre-existing CA from your organization's PKI
47-
- Create a Secret named `root-ca-secret` in the `cert-manager` namespace containing your CA's `tls.crt` and `tls.key`
48-
- Deploy only `certManagerClusterIssuerCA.yaml`
49-
- Update the Certificate resources to reference `ca-issuer` in the `issuerRef` field
40+
> **Note:** Other issuer types (e.g., CA issuer for disconnected environments with existing PKI) are allowable.
41+
> Users may configure their own ClusterIssuer; no reference CR is provided for non-ACME issuers.
5042
5143
2. **Certificates** (`apiServerCertificate.yaml` and `ingressCertificate.yaml`):
5244
- Update `commonName` and `dnsNames` to match your cluster's domain
@@ -63,7 +55,7 @@ Before applying these configurations, you must customize the following:
6355
3. Deploy the ClusterIssuer
6456
4. Deploy the Certificate resources
6557
5. Wait for certificates to be issued and secrets created
66-
6. **(Option B only)** Update kubeconfig to trust the new root CA (see "Kubeconfig Trust" section below)
58+
6. **(Custom CA only)** Update kubeconfig to trust the new root CA (see "Kubeconfig Trust" section below)
6759
7. Apply the APIServer and IngressController configurations
6860

6961
## Certificate Verification
@@ -76,7 +68,7 @@ After applying these configurations, verify that:
7668

7769
## Important: Kubeconfig Trust After API Server Cert Replacement
7870

79-
> **Note:** For Option B (Existing internal CA), you must complete this kubeconfig update
71+
> **Note:** When using a custom CA issuer, you must complete this kubeconfig update
8072
> *before* applying the APIServer configuration (step 7 in the deployment order above).
8173
> Applying the APIServer configuration first will lock you out.
8274

telco-core/configuration/reference-crs/optional/cert-manager/certManagerClusterIssuerCA.yaml

Lines changed: 0 additions & 10 deletions
This file was deleted.

telco-hub/configuration/reference-crs-kube-compare/compare_ignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ required/gitops/addPluginsPolicy.yaml
3434
required/acm/observabilityRoutePolicy.yaml
3535

3636
# cert-manager config CRs (user-specific, and policies with hub-side templating)
37-
optional/cert-manager/certManagerClusterIssuerCA.yaml
3837
optional/cert-manager/certManagerRootCAExpirationPolicy.yaml
3938
optional/cert-manager/certManagerRootCAExpirationPolicyPlacement.yaml
4039
optional/cert-manager/certManagerRootCAExpirationPolicyPlacementBinding.yaml

telco-hub/configuration/reference-crs-kube-compare/optional/cert-manager/certManagerClusterIssuerCA.yaml

Lines changed: 0 additions & 11 deletions
This file was deleted.

telco-hub/configuration/reference-crs/optional/cert-manager/README.md

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ Cert-manager automates the management and issuance of TLS certificates from vari
1818

1919
### Certificate Issuers
2020

21-
Two ClusterIssuer types are available. Choose one based on your environment:
22-
23-
- `certManagerClusterIssuer.yaml` - **ACME issuer** using Let's Encrypt with DNS-01 challenge (requires internet connectivity)
24-
- `certManagerClusterIssuerCA.yaml` - **CA issuer** using an internal certificate authority (disconnected environments with existing PKI)
21+
- `certManagerClusterIssuer.yaml` - **ACME issuer** using Let's Encrypt with DNS-01 challenge (reference recommendation)
2522

2623
### Certificate Resources
2724
- `apiServerCertificate.yaml` - Creates a certificate for the API Server endpoint
@@ -35,18 +32,13 @@ Two ClusterIssuer types are available. Choose one based on your environment:
3532

3633
Before applying these configurations, you must customize the following:
3734

38-
1. **ClusterIssuer** — choose one of the following issuer configurations:
39-
40-
**Option A: ACME issuer** (`certManagerClusterIssuer.yaml`) — for connected environments:
35+
1. **ClusterIssuer** (`certManagerClusterIssuer.yaml`):
4136
- Update `email` with your contact email
4237
- Configure the appropriate DNS provider for DNS-01 challenge (example shows Route53)
4338
- Reference pre-created Secrets for DNS provider credentials via `secretRef` — do not commit credentials in manifests
4439

45-
**Option B: Existing internal CA** (disconnected environments with existing PKI):
46-
- This issuer does **not** generate its own CA — it requires a pre-existing CA from your organization's PKI
47-
- Create a Secret named `root-ca-secret` in the `cert-manager` namespace containing your CA's `tls.crt` and `tls.key`
48-
- Deploy only `certManagerClusterIssuerCA.yaml`
49-
- Update the Certificate resources to reference `ca-issuer` in the `issuerRef` field
40+
> **Note:** Other issuer types (e.g., CA issuer for disconnected environments with existing PKI) are allowable.
41+
> Users may configure their own ClusterIssuer; no reference CR is provided for non-ACME issuers.
5042
5143
2. **Certificates** (`apiServerCertificate.yaml` and `ingressCertificate.yaml`):
5244
- Update `commonName` and `dnsNames` to match your cluster's domain
@@ -63,7 +55,7 @@ Before applying these configurations, you must customize the following:
6355
3. Deploy the ClusterIssuer
6456
4. Deploy the Certificate resources
6557
5. Wait for certificates to be issued and secrets created
66-
6. **(Option B only)** Update kubeconfig to trust the new root CA (see "Kubeconfig Trust" section below)
58+
6. **(Custom CA only)** Update kubeconfig to trust the new root CA (see "Kubeconfig Trust" section below)
6759
7. Apply the APIServer and IngressController configurations
6860

6961
## Certificate Verification
@@ -76,7 +68,7 @@ After applying these configurations, verify that:
7668

7769
## Important: Kubeconfig Trust After API Server Cert Replacement
7870

79-
> **Note:** For Option B (Existing internal CA), you must complete this kubeconfig update
71+
> **Note:** When using a custom CA issuer, you must complete this kubeconfig update
8072
> *before* applying the APIServer configuration (step 7 in the deployment order above).
8173
> Applying the APIServer configuration first will lock you out.
8274

telco-hub/configuration/reference-crs/optional/cert-manager/certManagerClusterIssuerCA.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.

telco-hub/configuration/reference-crs/optional/cert-manager/kustomization.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ resources:
66
- certManagerOperatorgroup.yaml
77
- certManagerSubscription.yaml
88
- certManagerClusterIssuer.yaml
9-
# Alternative issuer for environments with existing PKI (comment out ACME issuer above):
10-
# - certManagerClusterIssuerCA.yaml
119
- ingressCertificate.yaml
1210
- ingressControllerConfig.yaml
1311
- apiServerCertificate.yaml

telco-ran/configuration/kube-compare-reference/hack/compare_ignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ storage-lso/StorageOperatorStatus.yaml
4040
cert-manager/apiServerCertificate.yaml
4141
cert-manager/apiServerConfig.yaml
4242
cert-manager/certManagerClusterIssuer.yaml
43-
cert-manager/certManagerClusterIssuerCA.yaml
4443
cert-manager/ingressCertificate.yaml
4544
cert-manager/ingressControllerConfig.yaml
4645

0 commit comments

Comments
 (0)