Merge pull request #744 from sebrandon1/cnf-23578/add-yamllint-telco-ran

CNF-23578: Add yamllint coverage for telco-ran configuration

Author: openshift-merge-bot[bot]

.yamllint.yaml

@@ -3,6 +3,16 @@
 
 extends: default
 
+ignore: |
+  # Go-templated kube-compare reference directories — not valid YAML
+  telco-core/configuration/reference-crs-kube-compare/
+  telco-hub/configuration/reference-crs-kube-compare/
+  telco-ran/configuration/kube-compare-reference/
+  # Generated MachineConfig CRs with base64 ignition data exceeding line limits
+  telco-ran/configuration/source-crs/extra-manifest/
+  # Generated PolicyGenTemplate output with mixed indentation from the toolchain
+  telco-ran/configuration/argocd/example/policygentemplates/group-du-clo5-cleanup-policy.yaml
+
 rules:
   # Allow for whitespace in [] lists for readability, eg [ value, value ]
   brackets:

Makefile

@@ -56,17 +56,9 @@ check-deps:
 
 # Basic lint checking
 lintCheck:
-	# The configuration is done piece-wise in order to skip the
-	# kube-compare reference tree. Those yamls are augmented with
-	# golang templating and are not expected to be legal yaml.
-	yamllint -c .yamllint.yaml telco-core/configuration/*yaml
-	yamllint -c .yamllint.yaml telco-core/configuration/reference-crs
-	yamllint -c .yamllint.yaml telco-core/configuration/template-values
-	yamllint -c .yamllint.yaml telco-core/install/
-	yamllint -c .yamllint.yaml telco-hub/configuration/*yaml
-	yamllint -c .yamllint.yaml telco-hub/configuration/reference-crs
-	yamllint -c .yamllint.yaml telco-hub/configuration/example-overlays-config
-	yamllint -c .yamllint.yaml telco-hub/install/
+	yamllint -c .yamllint.yaml telco-core/
+	yamllint -c .yamllint.yaml telco-hub/
+	yamllint -c .yamllint.yaml telco-ran/
 
 # markdownlint rules, following: https://github.com/openshift/enhancements/blob/master/Makefile
 .PHONY: markdownlint-image

telco-ran/configuration/argocd/example/acmpolicygenerator/acm-common-mno-ranGen.yaml

@@ -2,35 +2,35 @@
 apiVersion: policy.open-cluster-management.io/v1
 kind: PolicyGenerator
 metadata:
-    name: common-mno-latest
+  name: common-mno-latest
 placementBindingDefaults:
-    name: common-mno-latest-placement-binding
+  name: common-mno-latest-placement-binding
 policyDefaults:
-    namespace: ztp-common
-    placement:
-        labelSelector:
-            matchExpressions:
-                - key: common
-                  operator: In
-                  values:
-                    - "true"
-                - key: du-profile
-                  operator: In
-                  values:
-                    - latest
-    remediationAction: inform
-    severity: low
-    namespaceSelector:
-        exclude:
-            - kube-*
-        include:
-            - '*'
-    evaluationInterval:
-        compliant: 10m
-        noncompliant: 10s
+  namespace: ztp-common
+  placement:
+    labelSelector:
+      matchExpressions:
+        - key: common
+          operator: In
+          values:
+            - "true"
+        - key: du-profile
+          operator: In
+          values:
+            - latest
+  remediationAction: inform
+  severity: low
+  namespaceSelector:
+    exclude:
+      - kube-*
+    include:
+      - '*'
+  evaluationInterval:
+    compliant: 10m
+    noncompliant: 10s
 policies:
-    - name: common-mno-latest-config-policy
-      policyAnnotations:
-        ran.openshift.io/ztp-deploy-wave: "1"
-      manifests:
-        - path: source-crs/cluster-tuning/operator-hub/OperatorHub.yaml
+  - name: common-mno-latest-config-policy
+    policyAnnotations:
+      ran.openshift.io/ztp-deploy-wave: "1"
+    manifests:
+      - path: source-crs/cluster-tuning/operator-hub/OperatorHub.yaml

telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-3node-ranGen.yaml

@@ -47,9 +47,9 @@ policies:
       openapi:
         path: schema.openapi
     - path: source-crs/sriov-operator/SriovOperatorConfig-SetSelector.yaml
-      # For existing clusters with node selector set as "master", 
+      # For existing clusters with node selector set as "master",
       # change the complianceType to "mustonlyhave".
-      # After complying with the policy, the complianceType can 
+      # After complying with the policy, the complianceType can
       # be reverted to "musthave"
       complianceType: musthave
       patches:

telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-clo5-cleanup.yaml

@@ -34,4 +34,3 @@ policies:
     ran.openshift.io/ztp-deploy-wave: "11"
   manifests:
     - path: source-crs/cluster-logging/ClusterLogging5Cleanup.yaml
-

telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-sno-ranGen.yaml

@@ -49,9 +49,9 @@ policies:
       openapi:
         path: schema.openapi
     ## The setting below overrides the default "worker" selector predefined in
-    ## the source-crs. The change is recommended on SNOs configured with PTP 
+    ## the source-crs. The change is recommended on SNOs configured with PTP
     ## event notification for forward compatibility with possible SNO expansion.
-    ## When the default setting is left intact, then in case of an SNO 
+    ## When the default setting is left intact, then in case of an SNO
     ## expansion with one or more workers, PTP operator
     ## would not create linuxptp-daemon containers on the worker node(s). Any
     ## attempt to change the daemonsetNodeSelector will result in ptp daemon
@@ -80,9 +80,9 @@ policies:
       openapi:
         path: schema.openapi
     - path: source-crs/sriov-operator/SriovOperatorConfig-SetSelector.yaml
-      ## For existing clusters with node selector set as "master", 
+      ## For existing clusters with node selector set as "master",
       ## change the complianceType to "mustonlyhave".
-      ## After complying with the policy, the complianceType can 
+      ## After complying with the policy, the complianceType can
       ## be reverted to "musthave"
       complianceType: musthave
       patches:

telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-standard-ranGen.yaml

@@ -52,9 +52,9 @@ policies:
       openapi:
         path: schema.openapi
     - path: source-crs/sriov-operator/SriovOperatorConfig-SetSelector.yaml
-      # For existing clusters with node selector set as "master", 
+      # For existing clusters with node selector set as "master",
       # change the complianceType to "mustonlyhave".
-      # After complying with the policy, the complianceType can 
+      # After complying with the policy, the complianceType can
       # be reverted to "musthave"
       complianceType: musthave
       patches:
@@ -85,6 +85,6 @@ policies:
           - machineConfigLabels:
               machineconfiguration.openshift.io/role: "worker"
             priority: 18
-            profile: ran-du-performance 
+            profile: ran-du-performance
     - path: source-crs/optional-extra-manifest/enable-crun-master.yaml
     - path: source-crs/optional-extra-manifest/enable-crun-worker.yaml

telco-ran/configuration/argocd/example/acmpolicygenerator/hub-side-templating/acm-group-du-3node-ranGen-templated.yaml

@@ -52,9 +52,9 @@ policies:
       openapi:
         path: schema.openapi
     - path: source-crs/sriov-operator/SriovOperatorConfig-SetSelector.yaml
-      # For existing clusters with node selector set as "master", 
+      # For existing clusters with node selector set as "master",
       # change the complianceType to "mustonlyhave".
-      # After complying with the policy, the complianceType can 
+      # After complying with the policy, the complianceType can
       # be reverted to "musthave"
       complianceType: musthave
       patches:
@@ -85,6 +85,6 @@ policies:
           - machineConfigLabels:
               machineconfiguration.openshift.io/role: "master"
             priority: 18
-            profile: ran-du-performance 
+            profile: ran-du-performance
     - path: source-crs/optional-extra-manifest/enable-crun-master.yaml
     - path: source-crs/optional-extra-manifest/enable-crun-worker.yaml

telco-ran/configuration/argocd/example/acmpolicygenerator/hub-side-templating/acm-group-du-sno-ranGen-templated.yaml

@@ -1,5 +1,5 @@
 # For this PGT, we've considered an SNO managed cluster with the following labels:
-#   group-du-sno-zone: zone-1 
+#   group-du-sno-zone: zone-1
 #   hardware-type: hw-type-platform-1
 # ConfigMaps used:
 #   group-hardware-types-configmap.yaml: group-hardware-types-configmap
@@ -54,9 +54,9 @@ policies:
       openapi:
         path: schema.openapi
     ## The setting below overrides the default "worker" selector predefined in
-    ## the source-crs. The change is recommended on SNOs configured with PTP 
+    ## the source-crs. The change is recommended on SNOs configured with PTP
     ## event notification for forward compatibility with possible SNO expansion.
-    ## When the default setting is left intact, then in case of an SNO 
+    ## When the default setting is left intact, then in case of an SNO
     ## expansion with one or more workers, PTP operator
     ## would not create linuxptp-daemon containers on the worker node(s). Any
     ## attempt to change the daemonsetNodeSelector will result in ptp daemon
@@ -144,7 +144,7 @@ policies:
           - machineConfigLabels:
               machineconfiguration.openshift.io/role: "master"
             priority: 18
-            profile: ran-du-performance 
+            profile: ran-du-performance
     - path: source-crs/optional-extra-manifest/enable-crun-master.yaml
     - path: source-crs/optional-extra-manifest/enable-crun-worker.yaml
 #    - path: source-crs/storage-lso/StorageClass.yaml

telco-ran/configuration/argocd/example/acmpolicygenerator/hub-side-templating/acm-group-du-standard-ranGen-templated.yaml

@@ -57,9 +57,9 @@ policies:
       openapi:
         path: schema.openapi
     - path: source-crs/sriov-operator/SriovOperatorConfig-SetSelector.yaml
-      # For existing clusters with node selector set as "master", 
+      # For existing clusters with node selector set as "master",
       # change the complianceType to "mustonlyhave".
-      # After complying with the policy, the complianceType can 
+      # After complying with the policy, the complianceType can
       # be reverted to "musthave"
       complianceType: musthave
       patches:
@@ -90,6 +90,6 @@ policies:
           - machineConfigLabels:
               machineconfiguration.openshift.io/role: "worker"
             priority: 18
-            profile: ran-du-performance 
+            profile: ran-du-performance
     - path: source-crs/optional-extra-manifest/enable-crun-master.yaml
     - path: source-crs/optional-extra-manifest/enable-crun-worker.yaml