Add sh linter; improve Makefile(s)

[sebrandon1]

Notable changes:

• Adding a Github Actions workflow for linting shell scripts in this repo.
• Ran shfmt -w against the shell scripts in this repo so they pass the linter.
• Added some Makefile lint paths.

Shell Formatting Enhancements:

• .github/workflows/pre-main.yml: Added a new GitHub Actions workflow named "Shell Format Check" to validate shell script formatting using shfmt on pull requests and pushes to the main branch.

Makefile Updates:

• telco-ran/configuration/Makefile: Introduced a new lint target to check shell script formatting with shfmt.
• telco-ran/configuration/extra-manifests-builder/Makefile: Added a lint target for shell formatting checks and updated .PHONY to include lint. [1] [2]

Code Style Improvements:

• telco-ran/configuration/extra-manifests-builder/08-set-rcu-normal/test.sh: Adjusted indentation and spacing for better readability and consistency.
• telco-ran/configuration/Makefile: Simplified and standardized conditional checks in the checkSourceCRsAnnotation target.

These changes collectively aim to improve code quality, enforce consistent formatting, and streamline development workflows.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[imiller0]

Can we consider shfmt -w -i 2? With tabs the lines display in reviews (here in github) with a significant amount of whitespace which can lead to lines running off the screen.

[openshift-ci]

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/lintcheck	05e8c9b	link	true	/test lintcheck

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.