telco-core: configure kdump.service on the cluster

[yprokule]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yprokule
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 74a374ac-ee55-4094-90ce-b094ed7094ef

📥 Commits

Reviewing files that changed from the base of the PR and between 76c32a2 and 8b78b6b.

📒 Files selected for processing (1)

• telco-core/configuration/core-baseline.yaml

---

📝 Walkthrough

Walkthrough

Two optional kdump manifest paths are added to the core-cluster-config-4.22 policy generator in the core baseline configuration file. No policy logic, patches, or control-flow changes are introduced.

Changes

Cohort / File(s)	Summary
Configuration Update telco-core/configuration/core-baseline.yaml	Added two optional manifest references (kdump-master.yaml and kdump-worker.yaml) to the policy generator configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, so the description cannot be evaluated against the changeset.	Add a pull request description that explains the purpose, rationale, or context for configuring kdump.service on the cluster.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding kdump.service configuration through manifest references in the core-baseline.yaml policy generator.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[yprokule]

/assign @imiller0

[yprokule]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[imiller0]

These CRs exist in the extra-manifests directory and will be automatically managed by the Hub cluster policy which keeps the cluster aligned with those install manifests at day-N
Hub policy: https://github.com/openshift-kni/telco-reference/blob/main/telco-hub/configuration/reference-crs/required/gitops/ztp-policies/extra-manifests-policy.yaml
Installation manifests for Core: https://github.com/openshift-kni/telco-reference/tree/main/telco-core/install/extra-manifests

I suggest we close this PR.

[yprokule]

These CRs exist in the extra-manifests directory and will be automatically managed by the Hub cluster policy which keeps the cluster aligned with those install manifests at day-N Hub policy: https://github.com/openshift-kni/telco-reference/blob/main/telco-hub/configuration/reference-crs/required/gitops/ztp-policies/extra-manifests-policy.yaml Installation manifests for Core: https://github.com/openshift-kni/telco-reference/tree/main/telco-core/install/extra-manifests

I suggest we close this PR.

Does this mean that RDS Core configuration relies on the Hub policy(ies) and cannot be used standalone? In that case it must be clearly stated and all relevant CRs must be removed from the reference-crs folder.

[imiller0]

Moving of MachineConfigs from the reference-crs to install extra manifests is being done under #761. The reference can be applied without hub cluster but must include these manifests from the install phase (can be applied using the installer of choice) and configuration under reference-crs.