Skip to content

CNF-23793 RAN: accept net.userLevelNetworking as optional variation in PerformanceProfile#834

Open
kchennag wants to merge 1 commit into
openshift-kni:mainfrom
kchennag:cnf-23793-userLevelNetworking
Open

CNF-23793 RAN: accept net.userLevelNetworking as optional variation in PerformanceProfile#834
kchennag wants to merge 1 commit into
openshift-kni:mainfrom
kchennag:cnf-23793-userLevelNetworking

Conversation

@kchennag

Copy link
Copy Markdown
Contributor

…n PerformanceProfile

@openshift-ci openshift-ci Bot requested review from MarSik and fedepaol June 29, 2026 18:49
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kchennag
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown

Hi @kchennag. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: fad61fa5-09d7-4271-b7e2-84aa0ae59751

📥 Commits

Reviewing files that changed from the base of the PR and between 78962de and 075a349.

📒 Files selected for processing (5)
  • telco-ran/configuration/kube-compare-reference/node-tuning-operator/PerformanceProfile.yaml
  • telco-ran/configuration/source-crs/node-tuning-operator/aarch64/PerformanceProfile-SetSelector.yaml
  • telco-ran/configuration/source-crs/node-tuning-operator/aarch64/PerformanceProfile.yaml
  • telco-ran/configuration/source-crs/node-tuning-operator/x86_64/PerformanceProfile-SetSelector.yaml
  • telco-ran/configuration/source-crs/node-tuning-operator/x86_64/PerformanceProfile.yaml

📝 Walkthrough

Walkthrough

The kube-compare PerformanceProfile template gains a conditional spec.net block that emits userLevelNetworking and devices only when those fields are present. Four source-crs PerformanceProfile YAML files (aarch64 and x86_64, both standard and SetSelector variants) receive commented-out documentation blocks describing the same net.userLevelNetworking and devices fields.

Changes

PerformanceProfile net/userLevelNetworking Support

Layer / File(s) Summary
kube-compare template conditional net block
telco-ran/configuration/kube-compare-reference/node-tuning-operator/PerformanceProfile.yaml
Adds a conditional spec.net section; emits userLevelNetworking when present and renders devices via toYaml; omits the block entirely when .spec.net is absent.
Source-crs commented net documentation
telco-ran/configuration/source-crs/node-tuning-operator/aarch64/PerformanceProfile*.yaml, telco-ran/configuration/source-crs/node-tuning-operator/x86_64/PerformanceProfile*.yaml
Adds commented-out net.userLevelNetworking and devices example blocks with operational warnings (node drain/reboot, NIC driver compatibility) to all four PerformanceProfile source-crs variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: making net.userLevelNetworking optional in PerformanceProfile.
Description check ✅ Passed The description is related to the change, referencing PerformanceProfile and net.userLevelNetworking, even though it is very brief.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kchennag kchennag changed the title CNF-23793 RAN: accept net.userLevelNetworking as optional variation i… CNF-23793 RAN: accept net.userLevelNetworking as optional variation in PerformanceProfile Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant