Skip to content

Commit 885ba4c

Browse files
committed
Fix coderabbit nits
1 parent c1727b7 commit 885ba4c

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

tests/crd_filter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ func versionsFrom(annotations map[string]string) sets.Set[uint64] {
158158

159159
versions := sets.New[uint64]()
160160
for _, version := range strings.Split(versionString, ",") {
161-
versionInt, err := strconv.ParseUint(version, 10, 64)
161+
versionInt, err := strconv.ParseUint(strings.TrimSpace(version), 10, 64)
162162
if err != nil {
163163
continue
164164
}

tools/codegen/pkg/manifestmerge/filters.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -293,16 +293,16 @@ func AllKnownVersions(payloadFeatureGatePath string) ([]uint64, error) {
293293
return nil, err
294294
}
295295

296-
versionSet := sets.NewInt()
296+
versionSet := sets.New[uint64]()
297297
for _, vfs := range allVersioned {
298298
for _, version := range vfs.VersionRange {
299-
versionSet.Insert(int(version))
299+
versionSet.Insert(version)
300300
}
301301
}
302302

303303
versions := make([]uint64, 0, versionSet.Len())
304304
for _, v := range versionSet.UnsortedList() {
305-
versions = append(versions, uint64(v))
305+
versions = append(versions, v)
306306
}
307307

308308
sort.Slice(versions, func(i, j int) bool {
@@ -594,7 +594,7 @@ func (f *VersionFilter) UseCRD(metadata crdForFeatureSet) bool {
594594
}
595595

596596
func (f *VersionFilter) String() string {
597-
return fmt.Sprintf("version=%d", f.targetVersion)
597+
return fmt.Sprintf("version=%v", f.targetVersion.UnsortedList())
598598
}
599599

600600
type AndManifestFilter struct {

0 commit comments

Comments
 (0)