[release-4.21] OCPBUGS-88295, OCPBUGS-88297, OCPBUGS-82146, OCPBUGS-78330, OCPBUGS-85550: NE-2480: Promote GatewayAPIWithoutOLM feature gate to Default#2865
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
Hello @gcs278! Some important instructions when contributing to openshift/api: |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
3c851d6 to
5157959
Compare
|
@gcs278: This pull request references NE-2480 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f9a88c4 to
e4c98af
Compare
|
@gcs278: This PR was included in a payload test run from openshift/origin#31232
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6689b0c0-603c-11f1-940d-a9e7c33d49a1-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#31232
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8f447a90-603c-11f1-97f7-e6703f146ba4-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#31232
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6b82790-604c-11f1-8cfa-10e8e0b0bde5-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#31232
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9d4f79a0-6069-11f1-8253-78c971bcc8c1-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#31232
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9301480-6069-11f1-94ef-707e0daebf2d-0 |
|
@gcs278: This pull request references Jira Issue OCPBUGS-88295, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-88297, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-82146, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-78330, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-85550, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
The verify-feature-promotion will never past because we do not support Gateway API on IPV6 or dual - same on 4.22 GA #2772. Will need override as @JoelSpeed did on #2772 (comment) |
|
/lgtm SBAR was approved for this backport, CI requirements are also met for supported platforms /override ci/prow/verify-feature-promotion |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Unrelated failure |
|
Created a bug for e2e-upgrade-out-of-change failure: https://redhat.atlassian.net/browse/OCPBUGS-91956 It's a simple fix (openshift/origin#31329) and test-only bug that I'll pre-test with |
|
/testwith openshift/api/release-4.21/e2e-upgrade-out-of-change openshift/origin#31331 |
|
I don't know if
My goal was to merge before the next 4.21 z-stream cutoff tomorrow (6/24). The test failure doesn't reflect a code quality issue: the CIO behavior is correct, and I have a proven fix incoming for the test itself. @JoelSpeed would it be a bad idea to override these? It'd be nice to merge, but I can understand waiting for the fix. |
|
/override ci/prow/e2e-upgrade-out-of-change Out of change tests help us check for downgrade issues, though we don't support downgrades, this occassionally catches issues that might bite us. There's no release blocking jobs that match this so merging this PR without it passing should not affect our nightly builds /test e2e-aws-ovn-techpreview Want to run this one once more |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-upgrade-out-of-change DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Checked the PR with clusterbot /verified by @mjoseph |
|
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws-ovn-techpreview |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-techpreview DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
876752f
into
openshift:release-4.21
|
@gcs278: Jira Issue Verification Checks: Jira Issue OCPBUGS-88295 Jira Issue OCPBUGS-88295 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 Jira Issue Verification Checks: Jira Issue OCPBUGS-88297 Jira Issue OCPBUGS-88297 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 Jira Issue Verification Checks: Jira Issue OCPBUGS-82146 Jira Issue OCPBUGS-82146 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 Jira Issue Verification Checks: Jira Issue OCPBUGS-78330 Jira Issue OCPBUGS-78330 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 Jira Issue Verification Checks: Jira Issue OCPBUGS-85550 Jira Issue OCPBUGS-85550 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 4.21.0-0.nightly-2026-06-24-210838 |
Summary
Promote the
GatewayAPIWithoutOLMfeature gate to Default (GA) on release-4.21. This is the final PR needed to activate the no-OLM path for Gateway API on 4.21 — once merged, the Sail Library installation path replaces OLM-based Istio management in the next z-stream.This is part of an approved SBAR to backport the Sail Library (noOLM) from 4.22 to 4.19–4.21.
Backport of #2772 (originally landed in 4.22).
Background
Gateway API on OCP 4.19–4.21 uses the Cluster Ingress Operator (CIO) to install Istio via OLM (OSSM operator). This path has several critical bugs:
In OCP 4.22, NE-2286 replaced OLM with the Sail Library — CIO now installs Istio directly via embedded Helm charts. This feature shipped as GA behind the
GatewayAPIWithoutOLMfeature gate.Rollout Plan
Phase 1 — Land code (gate OFF) ✅
Phase 2 — TechPreview soak ✅
Phase 3 — GA promotion
Follow-up