Skip to content

Commit 78e872e

Browse files
Arun Mauryacursoragent
andcommitted
fix(e2e): set runAsUser on Vault Helm installer pod
Also tidy test/go.mod after removing direct library-go import and gofmt deployment_tls_override_test.go for verify. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 74c7ec7 commit 78e872e

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

pkg/controller/certmanager/deployment_tls_override_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ func TestUnsupportedConfigOverridesWinOverClusterTLSProfile(t *testing.T) {
109109
},
110110
},
111111
wantTLSArgs: map[string]string{
112-
"--tls-min-version": "VersionTLS10",
113-
"--tls-cipher-suites": "CUSTOM_MAIN",
114-
"--metrics-tls-min-version": "VersionTLS10",
112+
"--tls-min-version": "VersionTLS10",
113+
"--tls-cipher-suites": "CUSTOM_MAIN",
114+
"--metrics-tls-min-version": "VersionTLS10",
115115
"--metrics-tls-cipher-suites": "CUSTOM_METRICS",
116116
},
117117
},
@@ -167,7 +167,7 @@ func TestUnsupportedConfigOverridesWinOverClusterTLSProfile(t *testing.T) {
167167
wantTLSArgs: map[string]string{
168168
"--tls-min-version": "VersionTLS13",
169169
"--metrics-tls-min-version": "VersionTLS13",
170-
"--tls-cipher-suites": "CUSTOM_MAIN",
170+
"--tls-cipher-suites": "CUSTOM_MAIN",
171171
"--metrics-tls-cipher-suites": "CUSTOM_METRICS",
172172
},
173173
},

test/e2e/utils_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1968,6 +1968,7 @@ func setupVaultServer(ctx context.Context, cfg *rest.Config, loader library.Dyna
19681968

19691969
allowPrivilegeEscalation := false
19701970
runAsNonRoot := true
1971+
runAsUser := int64(1001)
19711972
privileged := false
19721973
installerPodName := "vault-installer"
19731974
helmPod := &corev1.Pod{
@@ -1993,6 +1994,7 @@ func setupVaultServer(ctx context.Context, cfg *rest.Config, loader library.Dyna
19931994
SecurityContext: &corev1.SecurityContext{
19941995
AllowPrivilegeEscalation: &allowPrivilegeEscalation,
19951996
RunAsNonRoot: &runAsNonRoot,
1997+
RunAsUser: &runAsUser,
19961998
Privileged: &privileged,
19971999
Capabilities: &corev1.Capabilities{
19982000
Drop: []corev1.Capability{"ALL"},

test/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ require (
2222
github.com/openshift/api v0.0.0-20260423140559-e9fad7d4cba1
2323
github.com/openshift/cert-manager-operator v0.0.0-00010101000000-000000000000
2424
github.com/openshift/client-go v0.0.0-20260330134249-7e1499aaacd7
25-
github.com/openshift/library-go v0.0.0-20260429151228-ecbc792a4313
2625
github.com/stretchr/testify v1.11.1
2726
github.com/tidwall/gjson v1.18.0
2827
github.com/vmware-archive/yaml-patch v0.0.11
@@ -102,6 +101,7 @@ require (
102101
github.com/nxadm/tail v1.4.11 // indirect
103102
github.com/onsi/ginkgo v1.16.5 // indirect
104103
github.com/opencontainers/go-digest v1.0.0 // indirect
104+
github.com/openshift/library-go v0.0.0-20260429151228-ecbc792a4313 // indirect
105105
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
106106
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
107107
github.com/prometheus/client_golang v1.23.2 // indirect

0 commit comments

Comments
 (0)