OCPBUGS-87285: Updating ose-openstack-cinder-csi-driver-container image to be consistent with ART for 5.0#402
Conversation
openshift-bot
force-pushed
the
art-consistency-openshift-5.0-ose-openstack-cinder-csi-driver
branch
from
e6a7606 to
1e62012
Compare
|
Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fsync-ci-images/201 |
WalkthroughThe pull request updates the CI operator build configuration to downgrade the Go version used in the build root image from 1.26 to 1.25. This affects the release/openshift namespace's container image tag in the CI build pipeline. ChangesGo version update in CI configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-bot
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
jira/valid-reference
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87285, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87285, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.ci-operator.yaml:
- Line 4: The CI build_root Go version is out of sync: update the tag value
currently set as "rhel-9-release-golang-1.25-openshift-5.0" to a Go 1.26-aligned
image (e.g., switch to the rhel-9-release image that uses Go 1.26) or else make
go.mod and Docker/hack/make.sh all consistently target Go 1.25; specifically
edit the tag string in .ci-operator.yaml to match the Go toolchain declared in
go.mod (go 1.26.0) and update any Docker build args or references in
hack/make.sh to the same 1.26.x version so all CI/build assets use the same Go
version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 32e60a0d-5912-4249-ba1a-6fee67665196
📒 Files selected for processing (1)
.ci-operator.yaml
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.26-openshift-5.0 | ||
| tag: rhel-9-release-golang-1.25-openshift-5.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go.mod go directive =="
fd -a '^go\.mod$' --exec sed -n '1,20p' {}
echo
echo "== CI build root image tag(s) =="
fd -a '^\.ci-operator\.yaml$' --exec sed -n '1,80p' {}
echo
echo "== Other pinned Go versions in repo (for consistency check) =="
rg -n --no-heading -e 'go 1\.[0-9]+' -e 'golang:1\.[0-9]+' -e 'golang-1\.[0-9]+' Dockerfile go.mod hack/make.sh images/**/Dockerfile 2>/dev/null || trueRepository: openshift/cloud-provider-openstack
Length of output: 1039
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Locate .ci-operator.yaml =="
fd -a --hidden '^\.ci-operator\.yaml$' -t f . || true
echo
echo "== .ci-operator.yaml first 30 lines =="
# Try printing the located file(s) if present
paths=$(fd -a --hidden '^\.ci-operator\.yaml$' -t f . || true)
if [ -n "${paths}" ]; then
for p in $paths; do
echo "--- ${p} ---"
sed -n '1,30p' "$p"
done
else
echo "No .ci-operator.yaml found."
fi
echo
echo "== go.mod go directive (top 25 lines) =="
sed -n '1,25p' go.mod
echo
echo "== Other pinned Go versions in repo (consistency check) =="
rg -n --no-heading \
-e 'go 1\.[0-9]+' \
-e 'golang:1\.[0-9]+' \
-e 'golang-1\.[0-9]+' \
-S Dockerfile go.mod hack/make.sh images/**/Dockerfile 2>/dev/null || trueRepository: openshift/cloud-provider-openstack
Length of output: 1733
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go.mod go directive =="
fd -a '^go\.mod$' --exec sed -n '1,20p' {}
echo
echo "== CI build root image tag(s) =="
fd -a --hidden '^\.ci-operator\.yaml$' --exec sed -n '1,80p' {}
echo
echo "== Other pinned Go versions in repo (consistency check) =="
rg -n --no-heading \
-e 'go 1\.[0-9]+' \
-e 'golang:1\.[0-9]+' \
-e 'golang-1\.[0-9]+' \
-S Dockerfile go.mod hack/make.sh .ci-operator.yaml --glob 'images/**/Dockerfile' 2>/dev/null || trueRepository: openshift/cloud-provider-openstack
Length of output: 1147
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go.mod go directive =="
fd -a '^go\.mod$' --exec sed -n '1,20p' {}
echo
echo "== CI build root image tag(s) =="
fd -a --hidden '^\.ci-operator\.yaml$' --exec sed -n '1,80p' {}
echo
echo "== Other pinned Go versions in repo =="
rg -n --no-heading \
-e 'go 1\.[0-9]+' \
-e 'golang:1\.[0-9]+' \
-e 'golang-1\.[0-9]+' \
-S --glob 'images/**/Dockerfile' \
Dockerfile go.mod hack/make.sh .ci-operator.yaml 2>/dev/null || trueRepository: openshift/cloud-provider-openstack
Length of output: 1127
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go.mod =="
sed -n '1,10p' go.mod
echo
echo "== .ci-operator.yaml build_root_image.tag =="
sed -n '1,15p' .ci-operator.yaml | sed -n '1,10p'
echo
echo "== hack/make.sh golang:1.xx references =="
sed -n '1,60p' hack/make.sh | rg -n 'golang:1\.[0-9]+' || true
echo
echo "== root Dockerfile GOLANG_IMAGE =="
sed -n '1,40p' DockerfileRepository: openshift/cloud-provider-openstack
Length of output: 2611
Align CI build-root Go version with go.mod (1.26.0)
.ci-operator.yaml sets build_root_image.tag: rhel-9-release-golang-1.25-openshift-5.0, but go.mod declares go 1.26.0 (and repo Docker build args/images are on Go 1.26.2; hack/make.sh still references golang:1.25). Align these toolchain versions (either move CI/build assets to 1.26, or downgrade consistently to 1.25).
tag: rhel-9-release-golang-1.25-openshift-5.0🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.ci-operator.yaml at line 4, The CI build_root Go version is out of sync:
update the tag value currently set as "rhel-9-release-golang-1.25-openshift-5.0"
to a Go 1.26-aligned image (e.g., switch to the rhel-9-release image that uses
Go 1.26) or else make go.mod and Docker/hack/make.sh all consistently target Go
1.25; specifically edit the tag string in .ci-operator.yaml to match the Go
toolchain declared in go.mod (go 1.26.0) and update any Docker build args or
references in hack/make.sh to the same 1.26.x version so all CI/build assets use
the same Go version.
|
@openshift-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
ART wants to connect issue OCPBUGS-87600 to this PR, but found it is currently hooked up to ['OCPBUGS-87285']. Please consult with #forum-ocp-art if it is not clear what there is to do. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87285. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2 participants
Updating ose-openstack-cinder-csi-driver-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request:
ose-openstack-cinder-csi-driver.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.
Roles & Responsibilities:
tests OR that necessary metadata changes are reported to the ART team
in
#forum-ocp-arton Slack. If necessary, the changes required by this pull request can beintroduced with a separate PR opened by the component team. Once the repository is aligned,
this PR will be closed automatically.
verify-depsis complaining. In that case, please opena new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
any required labels to ensure the PR merges once tests are passing. In cases where ART config is
canonical, downstream builds are already being built with these changes, and merging this PR
only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
a grace period for the component team to align their CI with ART's configuration before it becomes
canonical in product builds.
ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
To do so, open a PR to set the
auto_labelattribute in the image configuration. ExampleUPSTREAM: <carry>:. An example.If you have any questions about this pull request, please reach out in the
#forum-ocp-artSlack channel.