Skip to content

OCPBUGS-87285: Updating ose-openstack-cinder-csi-driver-container image to be consistent with ART for 5.0 #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
openshift-bot wants to merge 1 commit into from
+1 −1
Closed

OCPBUGS-87285: Updating ose-openstack-cinder-csi-driver-container image to be consistent with ART for 5.0 #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
build_root_image:
name: release
namespace: openshift
tag: rhel-9-release-golang-1.26-openshift-5.0
tag: rhel-9-release-golang-1.25-openshift-5.0

@coderabbitai coderabbitai Bot Jun 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== go.mod go directive =="
fd -a '^go\.mod$' --exec sed -n '1,20p' {}

echo
echo "== CI build root image tag(s) =="
fd -a '^\.ci-operator\.yaml$' --exec sed -n '1,80p' {}

echo
echo "== Other pinned Go versions in repo (for consistency check) =="
rg -n --no-heading -e 'go 1\.[0-9]+' -e 'golang:1\.[0-9]+' -e 'golang-1\.[0-9]+' Dockerfile go.mod hack/make.sh images/**/Dockerfile 2>/dev/null || true

Repository: openshift/cloud-provider-openstack

Length of output: 1039

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Locate .ci-operator.yaml =="
fd -a --hidden '^\.ci-operator\.yaml$' -t f . || true

echo
echo "== .ci-operator.yaml first 30 lines =="
# Try printing the located file(s) if present
paths=$(fd -a --hidden '^\.ci-operator\.yaml$' -t f . || true)
if [ -n "${paths}" ]; then
  for p in $paths; do
    echo "--- ${p} ---"
    sed -n '1,30p' "$p"
  done
else
  echo "No .ci-operator.yaml found."
fi

echo
echo "== go.mod go directive (top 25 lines) =="
sed -n '1,25p' go.mod

echo
echo "== Other pinned Go versions in repo (consistency check) =="
rg -n --no-heading \
  -e 'go 1\.[0-9]+' \
  -e 'golang:1\.[0-9]+' \
  -e 'golang-1\.[0-9]+' \
  -S Dockerfile go.mod hack/make.sh images/**/Dockerfile 2>/dev/null || true

Repository: openshift/cloud-provider-openstack

Length of output: 1733

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== go.mod go directive =="
fd -a '^go\.mod$' --exec sed -n '1,20p' {}

echo
echo "== CI build root image tag(s) =="
fd -a --hidden '^\.ci-operator\.yaml$' --exec sed -n '1,80p' {}

echo
echo "== Other pinned Go versions in repo (consistency check) =="
rg -n --no-heading \
  -e 'go 1\.[0-9]+' \
  -e 'golang:1\.[0-9]+' \
  -e 'golang-1\.[0-9]+' \
  -S Dockerfile go.mod hack/make.sh .ci-operator.yaml --glob 'images/**/Dockerfile' 2>/dev/null || true

Repository: openshift/cloud-provider-openstack

Length of output: 1147

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== go.mod go directive =="
fd -a '^go\.mod$' --exec sed -n '1,20p' {}

echo
echo "== CI build root image tag(s) =="
fd -a --hidden '^\.ci-operator\.yaml$' --exec sed -n '1,80p' {}

echo
echo "== Other pinned Go versions in repo =="
rg -n --no-heading \
  -e 'go 1\.[0-9]+' \
  -e 'golang:1\.[0-9]+' \
  -e 'golang-1\.[0-9]+' \
  -S --glob 'images/**/Dockerfile' \
  Dockerfile go.mod hack/make.sh .ci-operator.yaml 2>/dev/null || true

Repository: openshift/cloud-provider-openstack

Length of output: 1127

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== go.mod =="
sed -n '1,10p' go.mod

echo
echo "== .ci-operator.yaml build_root_image.tag =="
sed -n '1,15p' .ci-operator.yaml | sed -n '1,10p'

echo
echo "== hack/make.sh golang:1.xx references =="
sed -n '1,60p' hack/make.sh | rg -n 'golang:1\.[0-9]+' || true

echo
echo "== root Dockerfile GOLANG_IMAGE =="
sed -n '1,40p' Dockerfile

Repository: openshift/cloud-provider-openstack

Length of output: 2611

Align CI build-root Go version with go.mod (1.26.0)

.ci-operator.yaml sets build_root_image.tag: rhel-9-release-golang-1.25-openshift-5.0, but go.mod declares go 1.26.0 (and repo Docker build args/images are on Go 1.26.2; hack/make.sh still references golang:1.25). Align these toolchain versions (either move CI/build assets to 1.26, or downgrade consistently to 1.25).

  tag: rhel-9-release-golang-1.25-openshift-5.0
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.ci-operator.yaml at line 4, The CI build_root Go version is out of sync:
update the tag value currently set as "rhel-9-release-golang-1.25-openshift-5.0"
to a Go 1.26-aligned image (e.g., switch to the rhel-9-release image that uses
Go 1.26) or else make go.mod and Docker/hack/make.sh all consistently target Go
1.25; specifically edit the tag string in .ci-operator.yaml to match the Go
toolchain declared in go.mod (go 1.26.0) and update any Docker build args or
references in hack/make.sh to the same 1.26.x version so all CI/build assets use
the same Go version.