Skip to content

OCPBUGS-87330: Updating csi-driver-manila-container image to be consistent with ART for 5.0 #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
openshift-bot wants to merge 1 commit into from
Closed

OCPBUGS-87330: Updating csi-driver-manila-container image to be consistent with ART for 5.0 #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
build_root_image:
name: release
namespace: openshift
tag: rhel-9-release-golang-1.26-openshift-5.0
tag: rhel-9-release-golang-1.25-openshift-5.0

@coderabbitai coderabbitai Bot Jun 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the build root image tag against ART's ocp-build-data configuration.
# Expected: The tag should match what's defined in images/csi-driver-manila.yml at commit 7691ed4d.

# Check if ocp-build-data repo is accessible and fetch the specific commit
if gh repo view openshift-eng/ocp-build-data &>/dev/null; then
  echo "Fetching ART configuration from ocp-build-data..."
  gh api repos/openshift-eng/ocp-build-data/contents/images/csi-driver-manila.yml?ref=7691ed4d \
    --jq '.content' | base64 -d | grep -A5 -B5 "golang\|build_root\|builder"
else
  echo "Unable to access ocp-build-data repo. Please verify manually."
  echo "Check: https://github.com/openshift-eng/ocp-build-data/blob/7691ed4d/images/csi-driver-manila.yml"
fi

# Also check if there are any references to Go version requirements in the codebase
echo -e "\n--- Checking for Go version requirements in codebase ---"
rg -i "go\s+(1\.2[56]|>=?\s*1\.2[56])" --type=go --type=yaml --type=toml -C2

Repository: openshift/cloud-provider-openstack

Length of output: 5565

Fix build-root Go tag to match ART (Go 1.26, not 1.25)

./.ci-operator.yaml line 4 downgrades the build-root tag from rhel-9-release-golang-1.26-openshift-5.0 to rhel-9-release-golang-1.25-openshift-5.0, but openshift-eng/ocp-build-data commit 7691ed4d (images/csi-driver-manila.yml) shows from.builder.stream: rhel-9-golang-1.26. Align the tag with ART’s configured stream.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.ci-operator.yaml at line 4, The build-root Go tag was incorrectly set to
rhel-9-release-golang-1.25-openshift-5.0; update the tag value in the CI config
to rhel-9-release-golang-1.26-openshift-5.0 so it matches ART’s configured
stream (change the tag string on the line containing "tag:
rhel-9-release-golang-1.25-openshift-5.0" to
"rhel-9-release-golang-1.26-openshift-5.0").