Skip to content

NO-ISSUE: Update github.com/openshift/assisted-service/models digest to aa192af#1008

Open
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest
Open

NO-ISSUE: Update github.com/openshift/assisted-service/models digest to aa192af#1008
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented May 20, 2026

Copy link
Copy Markdown

This PR contains the following updates:

Package Type Update Change
github.com/openshift/assisted-service/models replace digest 9f306c7aa192af

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@red-hat-konflux[bot]: This pull request explicitly references no jira issue.

Details

In response to this:

This PR contains the following updates:

Package Type Update Change
github.com/openshift/assisted-service/models replace digest 9f306c7c7a06a1

[!WARNING]
Some dependencies could not be looked up. Check the warning logs for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Updates the go.mod replace directive for github.com/openshift/assisted-service/models to v0.0.0-20260526130046-c10b73dfdd09 (was v0.0.0-20260519145307-9f306c73663e).

Changes

Dependency Update

Layer / File(s) Summary
Assisted-service models replace update
go.mod
The replace directive for github.com/openshift/assisted-service/models is updated from v0.0.0-20260519145307-9f306c73663e to v0.0.0-20260526130046-c10b73dfdd09.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

ok-to-test, approved, lgtm

Suggested reviewers

  • adriengentil
🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Ginkgo tests lack assertion messages throughout the codebase: 0 of 91 Expect calls in agentcluster_controller_test.go include diagnostic messages, making failures difficult to diagnose. Add descriptive messages to all Expect assertions, e.g., Expect(err).To(BeNil(), "failed to create test pod") to improve test failure diagnostics.
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning New Ginkgo tests contain hardcoded IPv4 addresses (12 instances) and URLs without IPv6 alternatives or dynamic IP family detection, failing IPv6-only disconnected CI compatibility. Add IPv6-compatible CIDR/address variants or use dynamic IP family detection (GetIPAddressFamily/correctCIDRFamily). Mark IPv4-only tests with [Skipped:Disconnected].
✅ Passed checks (10 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All 47 Ginkgo test names in the PR are stable and deterministic, using descriptive static strings without dynamic identifiers, timestamps, UUIDs, or generated suffixes.
Microshift Test Compatibility ✅ Passed PR only updates go.mod dependency version; no new Ginkgo e2e tests added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates go.mod dependency digest; does not add new Ginkgo e2e tests. Existing tests are unit tests using fake clients, not infrastructure-dependent e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates go.mod dependency version; no deployment manifests, operator code, or controllers with scheduling constraints are added or modified.
Ote Binary Stdout Contract ✅ Passed Not applicable: PR modifies only go.mod dependency; repository is a controller, not an OTE test binary requiring stdout JSON contract.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title specifically references updating the github.com/openshift/assisted-service/models digest, which directly aligns with the main change in go.mod updating the module's replace directive.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2026
@openshift-ci openshift-ci Bot requested review from adriengentil and carbonin May 20, 2026 00:24
@openshift-ci

openshift-ci Bot commented May 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign eranco74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2026
@openshift-ci

openshift-ci Bot commented May 20, 2026

Copy link
Copy Markdown

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 0ee207f to ffdbce1 Compare May 20, 2026 15:19
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to c7a06a1 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 21da507 May 20, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from ffdbce1 to 143f303 Compare May 25, 2026 16:49
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 21da507 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 23f6191 May 25, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 136: go.mod references pseudo-version 23f6191fb619 but the PR title and
robot digests differ—reconcile the intended assisted-service commit and verify
HostStatus constants compatibility. Update go.mod to point to the exact
commit/digest you intend (e.g., replace 23f6191fb619 with the correct
pseudo-version corresponding to PR digest 21da507 or robot digest c7a06a1), then
run go get && go mod tidy to refresh modules; diff the models package between
commits 9f306c73663e and 23f6191fb619 (focus on the files defining HostStatus*
constants) and confirm that models.HostStatus* symbols used in
controllers/agentmachine_controller.go (the HostStatus checks around the
HostStatus* usages) are present and unchanged—if any renames/removals are found,
update the controller code to use the new constant names or adjust the
dependency target so semantics remain compatible.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 67eb8c32-f57a-4685-8d5f-458349663663

📥 Commits

Reviewing files that changed from the base of the PR and between ffdbce1 and 143f303.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod Outdated
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 143f303 to 6af4058 Compare May 25, 2026 22:32
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 23f6191 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 974f740 May 25, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 6af4058 to cc0e519 Compare May 26, 2026 16:51
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 974f740 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to c10b73d May 26, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from cc0e519 to 909f60b Compare May 26, 2026 23:02
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to c10b73d NO-ISSUE: Update github.com/openshift/assisted-service/models digest to a776f1a May 26, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 909f60b to 7a99d10 Compare May 27, 2026 08:42
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to a776f1a NO-ISSUE: Update github.com/openshift/assisted-service/models digest to b0d34e8 May 27, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 7a99d10 to fc78955 Compare May 28, 2026 12:25
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to b0d34e8 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to e2aaa3e May 28, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from fc78955 to cc320fe Compare May 28, 2026 16:28
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to e2aaa3e NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 3b239e5 May 28, 2026
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from cc320fe to a700019 Compare June 2, 2026 17:56
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 3b239e5 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 837202f Jun 2, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from a700019 to 76d52ae Compare June 2, 2026 21:30
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 837202f NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 0555e95 Jun 2, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 76d52ae to f42fa18 Compare June 3, 2026 00:27
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 0555e95 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to d6fe4f5 Jun 3, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from f42fa18 to 680c77f Compare June 3, 2026 16:20
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to d6fe4f5 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to eeb25a6 Jun 3, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch 2 times, most recently from 699f2bd to 1c12d54 Compare June 5, 2026 16:18
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to eeb25a6 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 53ff031 Jun 5, 2026
…to aa192af

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 1c12d54 to 7fd9ae2 Compare June 15, 2026 16:06
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 53ff031 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to aa192af Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant