-
Notifications
You must be signed in to change notification settings - Fork 25
NO-ISSUE: Update module sigs.k8s.io/controller-runtime to v0.24.1 #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| module github.com/openshift/cluster-api-provider-agent/api | ||
|
|
||
| go 1.25.7 | ||
| go 1.26.0 | ||
|
|
||
| require ( | ||
| github.com/openshift/api v0.0.0-20240830023148-b7d0481c9094 | ||
| k8s.io/apimachinery v0.34.2 | ||
| k8s.io/client-go v0.34.2 | ||
| k8s.io/apimachinery v0.36.0 | ||
| k8s.io/client-go v0.36.0 | ||
| sigs.k8s.io/cluster-api v1.11.0 | ||
| sigs.k8s.io/controller-runtime v0.22.4 | ||
| sigs.k8s.io/controller-runtime v0.24.1 | ||
|
Comment on lines
+7
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: For Cluster API v1.11.0, the supported Kubernetes versions range from v1.28.x to v1.33.x [1]. Cluster API v1.11 is not compatible with Kubernetes v1.36; support for Kubernetes v1.36 in the v1.11 minor release line is only available starting from v1.11.8 [2]. Regarding controller-runtime, Cluster API v1.11.0 was released with controller-runtime v0.21.0 [1]. It is not compatible with controller-runtime v0.24.1, which is explicitly tied to Kubernetes v1.36 and higher [3][4]. The Cluster API project maintains specific minor versions of controller-runtime for its releases and does not support arbitrary upgrades to newer, incompatible controller-runtime versions [2][4]. In summary, neither Kubernetes v1.36 nor controller-runtime v0.24.1 are officially supported by Cluster API v1.11.0 [1][2][3]. To use Kubernetes v1.36, you must use a newer version of Cluster API that supports it (such as v1.12.8 or v1.13.1) [2]. Citations:
Resolve version incompatibilities: cluster-api v1.11.0 does not support Kubernetes v0.36.0 or controller-runtime v0.24.1. Cluster API v1.11.0 officially supports only Kubernetes v1.28–v1.33 and was released with controller-runtime v0.21.0. For Kubernetes 1.36 support, upgrade to Cluster API v1.12.8, v1.13.1, or later. 🤖 Prompt for AI Agents |
||
| ) | ||
|
|
||
| require ( | ||
|
|
@@ -28,32 +28,29 @@ require ( | |
| github.com/go-openapi/swag/stringutils v0.25.3 // indirect | ||
| github.com/go-openapi/swag/typeutils v0.25.3 // indirect | ||
| github.com/go-openapi/swag/yamlutils v0.25.3 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/google/gnostic-models v0.7.1 // indirect | ||
| github.com/google/go-cmp v0.7.0 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect | ||
| github.com/onsi/gomega v1.38.2 // indirect | ||
| github.com/onsi/gomega v1.39.0 // indirect | ||
| github.com/pkg/errors v0.9.1 // indirect | ||
| github.com/spf13/pflag v1.0.10 // indirect | ||
| github.com/stretchr/testify v1.11.1 // indirect | ||
| github.com/x448/float16 v0.8.4 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.3 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| golang.org/x/net v0.47.0 // indirect | ||
| golang.org/x/text v0.31.0 // indirect | ||
| golang.org/x/tools v0.39.0 // indirect | ||
| google.golang.org/protobuf v1.36.10 // indirect | ||
| golang.org/x/net v0.49.0 // indirect | ||
| golang.org/x/text v0.33.0 // indirect | ||
| google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| k8s.io/api v0.34.2 // indirect | ||
| k8s.io/apiextensions-apiserver v0.34.2 // indirect | ||
| k8s.io/klog/v2 v2.130.1 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20251125145642-4e65d59e963e // indirect | ||
| k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 // indirect | ||
| k8s.io/api v0.36.0 // indirect | ||
| k8s.io/apiextensions-apiserver v0.36.0 // indirect | ||
| k8s.io/klog/v2 v2.140.0 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260317180543-43fb72c5454a // indirect | ||
| k8s.io/utils v0.0.0-20260210185600-b8788abfbbc2 // indirect | ||
| sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect | ||
| sigs.k8s.io/randfill v1.0.0 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v6 v6.3.1 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v6 v6.3.2 // indirect | ||
| sigs.k8s.io/yaml v1.6.0 // indirect | ||
| ) | ||
|
|
||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 1068
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 111
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 123
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 62
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 108
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 1713
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 814
🏁 Script executed:
Repository: openshift/cluster-api-provider-agent
Length of output: 1490
🏁 Script executed:
cat -n Makefile | head -100Repository: openshift/cluster-api-provider-agent
Length of output: 5850
Update GitHub Actions, Dockerfile, and Dockerfile.rhtap to use Go 1.26.0.
The
api/go.moddeclaresgo 1.26.0but CI/build toolchains are pinned to older versions:.github/workflows/build.yaml:go-version: '1.17.3'Dockerfile:ubi9/go-toolset:1.25Dockerfile.rhtap:rhel_9_1.25These mismatches will cause build failures. Update all three to Go 1.26.0.
🤖 Prompt for AI Agents