Add OpenShift Tests Extension (OTE) for baremetal E2E tests

Implements OTE framework to migrate baremetal E2E tests from
openshift-tests-private to cluster-baremetal-operator repository.

Changes:
- Add cmd/cluster-baremetal-tests-ext/main.go: OTE binary entry point
  that registers as openshift:payload:cluster-baremetal extension
- Add test/e2e/baremetal/deployment_sanity.go: 6 migrated baremetal tests
  * Cluster operators running check (OCP-29146)
  * Nodes running check (OCP-29147)
  * Deployment availability check (OCP-29148)
  * Worker node validation (OCP-29149)
  * CPU usage check (OCP-29150)
  * Memory check (OCP-29151)
- Add test/e2e/baremetal/utils.go: Helper functions using compat_otp
- Update go.mod: Add OTE dependencies and OpenShift kubernetes replaces
- Update Makefile: Add build-tests target with -mod=mod approach
- Remove vendor/: Use Go module cache instead of vendoring (10k+ files)

Tests use platform=="baremetal" selector and run under origin CI.
Binary: cluster-baremetal-tests-ext (payload test extension)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: jadhaj

.gitignore

@@ -15,7 +15,8 @@ bin
 
 # Kubernetes Generated files - skip generated files, except for vendored files
 
-!vendor/**/zz_generated.*
+# Use -mod=mod instead of vendoring for OTE dependencies
+vendor/
 
 # editor and IDE paraphernalia
 .idea

Makefile

@@ -10,9 +10,9 @@ CONTAINER_TOOL ?= docker
 # Image URL to use all building/pushing image targets
 IMG ?= controller:latest
 
-CONTROLLER_GEN ?= go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go
+CONTROLLER_GEN ?= go run sigs.k8s.io/controller-tools/cmd/controller-gen
 CRD_OPTIONS="crd:crdVersions=v1"
-GOLANGCI_LINT ?= GOLANGCI_LINT_CACHE=$(GOLANGCI_LINT_CACHE) go run vendor/github.com/golangci/golangci-lint/v2/cmd/golangci-lint/main.go
+GOLANGCI_LINT ?= GOLANGCI_LINT_CACHE=$(GOLANGCI_LINT_CACHE) go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint
 KUSTOMIZE ?= go run sigs.k8s.io/kustomize/kustomize/v4
 MANIFEST_PROFILE ?= default
 TMP_DIR := $(shell mktemp -d -t manifests-$(date +%Y-%m-%d-%H-%M-%S)-XXXXXXXXXX)
@@ -35,6 +35,12 @@ test: generate lint manifests unit
 build:
 	go build -o bin/cluster-baremetal-operator main.go
 
+# Build OTE test extension binary
+build-tests:
+	GONOSUMDB="github.com/openshift/origin" CGO_ENABLED=0 GO_COMPLIANCE_POLICY="exempt_all" \
+	go build -mod=mod -o bin/cluster-baremetal-tests-ext ./cmd/cluster-baremetal-tests-ext
+	gzip -f bin/cluster-baremetal-tests-ext
+
 # Run against the configured Kubernetes cluster in ~/.kube/config
 run: generate manifests
 	go run ./main.go -images-json $(IMAGES_JSON)

cmd/cluster-baremetal-tests-ext/main.go

@@ -0,0 +1,62 @@
+package main
+
+import (
+	"fmt"
+	"os"
+
+	"github.com/spf13/cobra"
+	extcmd "github.com/openshift-eng/openshift-tests-extension/pkg/cmd"
+	e "github.com/openshift-eng/openshift-tests-extension/pkg/extension"
+	et "github.com/openshift-eng/openshift-tests-extension/pkg/extension/extensiontests"
+	g "github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo"
+
+	// Import test packages to register Ginkgo specs
+	_ "github.com/openshift/cluster-baremetal-operator/test/e2e/baremetal"
+)
+
+func main() {
+	// Extension registry
+	registry := e.NewRegistry()
+
+	// Create extension
+	ext := e.NewExtension(
+		"openshift",           // product
+		"payload",             // type
+		"cluster-baremetal",   // component name
+	)
+
+	// Add suites to the extension
+	ext.AddSuite(e.Suite{
+		Name:    "cluster-baremetal/all",
+		Parents: []string{"openshift/conformance/parallel"},
+	})
+
+	// Build test specs from Ginkgo tests automatically
+	specs, err := g.BuildExtensionTestSpecsFromOpenShiftGinkgoSuite()
+	if err != nil {
+		panic(fmt.Sprintf("couldn't build extension test specs from ginkgo: %+v", err.Error()))
+	}
+
+	// Apply environment selectors - baremetal platform only
+	// All tests should only run on baremetal platform
+	specs.Select(et.NameContains("")).
+		Include(et.PlatformEquals("baremetal"))
+
+	// Add specs to extension
+	ext.AddSpecs(specs)
+	registry.Register(ext)
+
+	// Create root command
+	rootCmd := &cobra.Command{
+		Use:   "cluster-baremetal-tests-ext",
+		Short: "Cluster BareMetal Operator Test Extension",
+		Long:  "OpenShift Tests Extension for Cluster BareMetal Operator E2E Tests",
+	}
+
+	// Register OTE subcommands (info, list, run-test, run-suite, etc.)
+	rootCmd.AddCommand(extcmd.DefaultExtensionCommands(registry)...)
+
+	if err := rootCmd.Execute(); err != nil {
+		os.Exit(1)
+	}
+}

go.mod

@@ -0,0 +1,202 @@
+package baremetal
+
+import (
+	"fmt"
+	"strings"
+
+	g "github.com/onsi/ginkgo/v2"
+	o "github.com/onsi/gomega"
+	compat_otp "github.com/openshift/origin/test/extended/util/compat_otp"
+	e2e "k8s.io/kubernetes/test/e2e/framework"
+)
+
+// var _ = g.Describe("[sig-baremetal] INSTALLER UPI for INSTALLER_GENERAL job on BareMetal", func() {
+// 	defer g.GinkgoRecover()
+// 	var (
+// 		oc           = compat_otp.NewCLI("baremetal-deployment-sanity")
+
+// 	)
+// 	g.BeforeEach(func() {
+
+// 	})
+
+// 	g.AfterEach(func() {
+
+// 	})
+
+// 	// author: sgoveas@redhat.com
+// 	g.It("Author:sgoveas--Medium-12345-example case", func() {
+
+// 	})
+
+// })
+
+// var _ = g.Describe("[sig-baremetal] INSTALLER UPI for INSTALLER_DEDICATED job on BareMetal", func() {
+// 	defer g.GinkgoRecover()
+// 	var (
+// 		oc           = compat_otp.NewCLI("baremetal-deployment-sanity")
+
+// 	)
+// 	g.BeforeEach(func() {
+
+// 	})
+
+// 	g.AfterEach(func() {
+
+// 	})
+
+// 	// author: sgoveas@redhat.com
+// 	g.It("Author:sgoveas--Medium-12345-example case", func() {
+
+// 	})
+
+// })
+
+var _ = g.Describe("[sig-baremetal] INSTALLER IPI for INSTALLER_GENERAL job on BareMetal", func() {
+	defer g.GinkgoRecover()
+	var (
+		oc           = compat_otp.NewCLI("baremetal-deployment-sanity", compat_otp.KubeConfigPath())
+		iaasPlatform string
+	)
+	g.BeforeEach(func() {
+		compat_otp.SkipForSNOCluster(oc)
+		iaasPlatform = compat_otp.CheckPlatform(oc)
+		if !(iaasPlatform == "baremetal") {
+			e2e.Logf("Cluster is: %s", iaasPlatform)
+			g.Skip("For Non-baremetal cluster , this is not supported!")
+		}
+	})
+	// author: jhajyahy@redhat.com
+	// port=yes - 99.7% pass rate (724 runs last 60 days)
+	g.It("Author:jhajyahy-Medium-29146-Verify that all clusteroperators are Available", func() {
+		g.By("Running oc get clusteroperators")
+		res, _ := checkOperatorsRunning(oc)
+		o.Expect(res).To(o.BeTrue())
+	})
+
+	// author: jhajyahy@redhat.com
+	// port=yes - 100.0% pass rate (724 runs last 60 days)
+	g.It("Author:jhajyahy-Medium-29719-Verify that all nodes are up and running", func() {
+		g.By("Running oc get nodes")
+		res, _ := checkNodesRunning(oc)
+		o.Expect(res).To(o.BeTrue())
+
+	})
+
+	// author: jhajyahy@redhat.com
+	// port=yes - 99.7% pass rate (724 runs last 60 days)
+	g.It("Author:jhajyahy-Medium-32361-Verify that deployment exists and is not empty", func() {
+		g.By("Create new namespace")
+		oc.SetupProject()
+		ns32361 := oc.Namespace()
+
+		g.By("Create deployment")
+		deployCreationErr := oc.Run("create").Args("deployment", "deploy32361", "-n", ns32361, "--image", "quay.io/openshifttest/hello-openshift@sha256:4200f438cf2e9446f6bcff9d67ceea1f69ed07a2f83363b7fb52529f7ddd8a83").Execute()
+		o.Expect(deployCreationErr).NotTo(o.HaveOccurred())
+
+		g.By("Check deployment status is available")
+		waitForDeployStatus(oc, "deploy32361", ns32361, "True")
+		status, err := oc.AsAdmin().Run("get").Args("deployment", "-n", ns32361, "deploy32361", "-o=jsonpath={.status.conditions[?(@.type=='Available')].status}").Output()
+		o.Expect(err).NotTo(o.HaveOccurred())
+		e2e.Logf("\nDeployment %s Status is %s\n", "deploy32361", status)
+		o.Expect(status).To(o.Equal("True"))
+
+		g.By("Check pod is in Running state")
+		podName := getPodName(oc, ns32361)
+		podStatus := getPodStatus(oc, ns32361, podName)
+		o.Expect(podStatus).To(o.Equal("Running"))
+	})
+
+	// author: jhajyahy@redhat.com
+	// port=yes - 99.9% pass rate (724 runs last 60 days)
+	g.It("Author:jhajyahy-Medium-34195-Verify all pods replicas are running on workers only", func() {
+		g.By("Create new namespace")
+		oc.SetupProject()
+		ns34195 := oc.Namespace()
+
+		g.By("Create deployment with num of workers + 1 replicas")
+		workerNodes, err := compat_otp.GetClusterNodesBy(oc, "worker")
+		o.Expect(err).NotTo(o.HaveOccurred())
+		replicasNum := len(workerNodes) + 1
+		deployCreationErr := oc.Run("create").Args("deployment", "deploy34195", "-n", ns34195, fmt.Sprintf("--replicas=%d", replicasNum), "--image", "quay.io/openshifttest/hello-openshift@sha256:4200f438cf2e9446f6bcff9d67ceea1f69ed07a2f83363b7fb52529f7ddd8a83").Execute()
+		o.Expect(deployCreationErr).NotTo(o.HaveOccurred())
+		waitForDeployStatus(oc, "deploy34195", ns34195, "True")
+
+		g.By("Check deployed pods number is as expected")
+		pods, err := oc.AsAdmin().Run("get").Args("pods", "-n", ns34195, "--field-selector=status.phase=Running", "-o=jsonpath={.items[*].metadata.name}").Output()
+		o.Expect(err).NotTo(o.HaveOccurred())
+		podList := strings.Fields(pods)
+		o.Expect(len(podList)).To(o.Equal(replicasNum))
+
+		g.By("Check pods are deployed on worker nodes only")
+		for _, pod := range podList {
+			podNodeName, err := compat_otp.GetPodNodeName(oc, ns34195, pod)
+			o.Expect(err).NotTo(o.HaveOccurred())
+			res := compat_otp.IsWorkerNode(oc, podNodeName)
+			if !res {
+				e2e.Logf("\nPod %s was deployed on non worker node  %s\n", pod, podNodeName)
+			}
+			o.Expect(res).To(o.BeTrue())
+		}
+	})
+
+	// author: jhajyahy@redhat.com
+	// port=yes - 99.7% pass rate (724 runs last 60 days)
+	g.It("Author:jhajyahy-Medium-39126-Verify maximum CPU usage limit hasn't reached on each of the nodes", func() {
+		g.By("Running oc get nodes")
+		cpuExceededNodes := []string{}
+		sampling_time, err := getClusterUptime(oc)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		nodeNames, nodeErr := oc.AsAdmin().WithoutNamespace().Run("get").Args("nodes", "-o=jsonpath={.items[*].metadata.name}").Output()
+		o.Expect(nodeErr).NotTo(o.HaveOccurred(), "Failed to execute oc get nodes")
+		nodes := strings.Fields(nodeNames)
+		for _, node := range nodes {
+			cpuUsage := getNodeCpuUsage(oc, node, sampling_time)
+			if cpuUsage > maxCpuUsageAllowed {
+				cpuExceededNodes = append(cpuExceededNodes, node)
+				e2e.Logf("\ncpu usage of exceeded node: %s is %.2f%%", node, cpuUsage)
+			}
+		}
+		o.Expect(cpuExceededNodes).Should(o.BeEmpty(), "These nodes exceed max CPU usage allowed: %s", cpuExceededNodes)
+	})
+
+	// author: jhajyahy@redhat.com
+	// port=yes - 99.6% pass rate (724 runs last 60 days)
+	g.It("Author:jhajyahy-Medium-39125-Verify that every node memory is sufficient", func() {
+		g.By("Running oc get nodes")
+		outOfMemoryNodes := []string{}
+		nodeNames, nodeErr := oc.AsAdmin().WithoutNamespace().Run("get").Args("nodes", "-o=jsonpath={.items[*].metadata.name}").Output()
+		o.Expect(nodeErr).NotTo(o.HaveOccurred(), "Failed to execute oc get nodes")
+		nodes := strings.Fields(nodeNames)
+		for _, node := range nodes {
+			availMem := getNodeavailMem(oc, node)
+			e2e.Logf("\nAvailable mem of Node %s is %d", node, availMem)
+			if availMem < minRequiredMemoryInBytes {
+				outOfMemoryNodes = append(outOfMemoryNodes, node)
+				e2e.Logf("\nNode %s does not meet minimum required memory %s Bytes ", node, minRequiredMemoryInBytes)
+			}
+		}
+		o.Expect(outOfMemoryNodes).Should(o.BeEmpty(), "These nodes does not meet minimum required memory: %s", outOfMemoryNodes)
+	})
+})
+
+// var _ = g.Describe("[sig-baremetal] INSTALLER IPI for INSTALLER_DEDICATED job on BareMetal", func() {
+// 	defer g.GinkgoRecover()
+// 	var (
+// 		oc           = compat_otp.NewCLI("baremetal-deployment-sanity")
+
+// 	)
+// 	g.BeforeEach(func() {
+
+// 	})
+
+// 	g.AfterEach(func() {
+
+// 	})
+
+// 	// author: sgoveas@redhat.com
+// 	g.It("Author:sgoveas--Medium-12345-example case", func() {
+
+// 	})
+
+// })