Adding annotations to manifests for CVO to identify#588
Open
miyadav wants to merge 3 commits into
Open
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci
Bot
added
the
do-not-merge/hold
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (44)
✅ Files skipped from review due to trivial changes (31)
🚧 Files skipped from review as they are similar to previous changes (9)
WalkthroughThe PR adds ChangesCompatibilityRequirements annotations
ClusterAPI annotations
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
manifests/0000_20_crd-compatibility-checker_08_deployment.yaml (1)
38-87: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winAdd explicit securityContext to the container spec.
The container lacks explicit
securityContextsettings. While the pod template annotation referencesrestricted-v3SCC, the coding guidelines require explicit security settings in the manifest itself.As per coding guidelines, Kubernetes manifests should include:
runAsNonRoot: truereadOnlyRootFilesystem: trueallowPrivilegeEscalation: false- Drop ALL capabilities and add only required ones
🔒 Proposed securityContext addition
- name: compatibility-requirements-controllers image: registry.ci.openshift.org/openshift:cluster-capi-operator command: - ./crd-compatibility-checker args: - --diagnostics-address=:8443 + securityContext: + runAsNonRoot: true + allowPrivilegeEscalation: false + readOnlyRootFilesystem: true + capabilities: + drop: + - ALL env:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@manifests/0000_20_crd-compatibility-checker_08_deployment.yaml` around lines 38 - 87, Add an explicit securityContext to the container spec for the container named compatibility-requirements-controllers: set runAsNonRoot: true, readOnlyRootFilesystem: true, allowPrivilegeEscalation: false, and configure capabilities to drop ["ALL"] (and only add any specific capabilities if truly required). Update the container block that contains ports/volumeMounts/readinessProbe/livenessProbe to include this securityContext so the manifest no longer relies solely on the pod SCC annotation.Source: Coding guidelines
🧹 Nitpick comments (1)
manifests/0000_20_crd-compatibility-checker_08_deployment.yaml (1)
76-79: ⚡ Quick winConsider adding resource limits to complement requests.
The container defines resource requests but no limits. As per coding guidelines, resource limits (cpu, memory) should be set on every container to prevent resource exhaustion and ensure predictable scheduling behavior.
📊 Proposed resource limits addition
resources: requests: cpu: 10m memory: 50Mi + limits: + cpu: 100m + memory: 200Mi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@manifests/0000_20_crd-compatibility-checker_08_deployment.yaml` around lines 76 - 79, The container resource spec currently only sets requests (cpu: 10m, memory: 50Mi) in the resources block; add corresponding resource limits to prevent resource exhaustion. Update the same resources section for the container in manifests/0000_20_crd-compatibility-checker_08_deployment.yaml by adding limits.cpu and limits.memory (e.g., cpu: "100m" and memory: "128Mi" or values appropriate for the app) alongside the existing requests so both requests and limits are defined for the container.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@manifests/0000_20_crd-compatibility-checker_08_deployment.yaml`:
- Around line 38-87: Add an explicit securityContext to the container spec for
the container named compatibility-requirements-controllers: set runAsNonRoot:
true, readOnlyRootFilesystem: true, allowPrivilegeEscalation: false, and
configure capabilities to drop ["ALL"] (and only add any specific capabilities
if truly required). Update the container block that contains
ports/volumeMounts/readinessProbe/livenessProbe to include this securityContext
so the manifest no longer relies solely on the pod SCC annotation.
---
Nitpick comments:
In `@manifests/0000_20_crd-compatibility-checker_08_deployment.yaml`:
- Around line 76-79: The container resource spec currently only sets requests
(cpu: 10m, memory: 50Mi) in the resources block; add corresponding resource
limits to prevent resource exhaustion. Update the same resources section for the
container in manifests/0000_20_crd-compatibility-checker_08_deployment.yaml by
adding limits.cpu and limits.memory (e.g., cpu: "100m" and memory: "128Mi" or
values appropriate for the app) alongside the existing requests so both requests
and limits are defined for the container.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 75630441-0604-4f2c-9c0c-02f159d02830
📒 Files selected for processing (35)
manifests/0000_20_cluster-api-tls-config_role.yamlmanifests/0000_20_crd-compatibility-checker_00_namespace.yamlmanifests/0000_20_crd-compatibility-checker_02_service_account.yamlmanifests/0000_20_crd-compatibility-checker_03_rbac_roles.yamlmanifests/0000_20_crd-compatibility-checker_04_rbac_bindings.yamlmanifests/0000_20_crd-compatibility-checker_05_metrics-service.yamlmanifests/0000_20_crd-compatibility-checker_07_webhook-service.yamlmanifests/0000_20_crd-compatibility-checker_08_deployment.yamlmanifests/0000_20_crd-compatibility-checker_09_allow-egress-operators.yamlmanifests/0000_20_crd-compatibility-checker_10_allow-ingress-to-webhook.yamlmanifests/0000_30_cluster-api-installer_00_namespace.yamlmanifests/0000_30_cluster-api-installer_00_tombstones.yamlmanifests/0000_30_cluster-api-installer_01_metrics-service.yamlmanifests/0000_30_cluster-api-installer_01_serviceaccount.yamlmanifests/0000_30_cluster-api-installer_02_clusterrole.yamlmanifests/0000_30_cluster-api-installer_03_clusterrolebinding.yamlmanifests/0000_30_cluster-api-installer_05_deployment.yamlmanifests/0000_30_cluster-api-installer_06_clusterapi.yamlmanifests/0000_30_cluster-api_00_namespace.yamlmanifests/0000_30_cluster-api_00_tombstones-4.22-tpnu.yamlmanifests/0000_30_cluster-api_01_credentials-request.yamlmanifests/0000_30_cluster-api_02_service_account.yamlmanifests/0000_30_cluster-api_02_webhook-service.yamlmanifests/0000_30_cluster-api_03_rbac_roles.yamlmanifests/0000_30_cluster-api_04_rbac_bindings.yamlmanifests/0000_30_cluster-api_10_metrics-service.yamlmanifests/0000_30_cluster-api_10_webhooks.yamlmanifests/0000_30_cluster-api_11_deployment.yamlmanifests/0000_30_cluster-api_12_clusteroperator.yamlmanifests/0000_30_cluster-api_13_allow-ingress-to-metrics-controllers.yamlmanifests/0000_30_cluster-api_14_allow-ingress-to-metrics-operators.yamlmanifests/0000_30_cluster-api_15_allow-egress-controllers.yamlmanifests/0000_30_cluster-api_16_allow-egress-operators.yamlmanifests/0000_30_cluster-api_17_default-deny.yamlmanifests/0000_30_cluster-api_18_allow-ingress-to-webhook.yaml
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
| release.openshift.io/feature-gate: "ClusterAPIMachineManagement" | ||
| capability.openshift.io/name: ClusterAPI |
There was a problem hiding this comment.
Suggested change
| capability.openshift.io/name: ClusterAPI | |
| capability.openshift.io/name: CompatibilityRequirements |
This ClusterRole is also used by the CompatibilityRequirements operator (see system:openshift:compatibility-requirements-read-tls-configuration)
miyadav
changed the title
Member
Author
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
mdbooth
reviewed
Jun 26, 2026
Contributor
There was a problem hiding this comment.
This file looks like a rebase error? We shouldn't be adding this.
Member
Author
There was a problem hiding this comment.
yeah rebased and pushed again , seems like the rebase miss resulted in annotations not being added as well which is also done.
…ilityRequirements is enabled,hence updated
…anifest by installer
Contributor
|
@miyadav: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifests changes , annoations added for capability to be identified by CVO . ( linked PR )
WIP - OCPCLOUD-3368
/hold
Generated by - claude-opus-4-6(2.1.169)
Summary by CodeRabbit