NE-2131: Migrate dualstack e2e tests from openshift/origin to tests-extension by lihongan · Pull Request #1412 · openshift/cluster-ingress-operator

lihongan · 2026-04-07T08:05:10Z

Add a lightweight CLI test framework (framework.go) that replicates key
exutil.CLI functionality without depending on k8s.io/kubernetes or
openshift/origin. The framework provides:

OAuth-first user authentication with ServiceAccount impersonation
fallback when User/OAuth APIs are unavailable
ProjectRequest-first namespace provisioning with plain Namespace
fallback, including pod security labels and cleanup
Cached typed client accessors (AdminKubeClient, KubeClient,
AdminConfigClient, AdminOperatorClient, RouteClient, etc.)
oc CLI wrapper with method chaining (AsAdmin/Run/Args/Execute/Output)
Automatic BeforeEach/AfterEach registration for project setup and
teardown

Shared helper functions are split into separate files:

test/util.go: generic utilities (exec pod, DNS resolution, curl checks)
test/ingress_util.go: ingress/route helpers (shard deploy, route
creation, admission wait, router log dump)
test/dualstack.go: test cases and dualstack-specific helpers

Migrate the dual-stack e2e tests (NLB and Classic LB) using this
framework, replacing ~70 lines of manual client setup per test with
a single NewCLI() call.

coderabbitai · 2026-04-07T08:05:22Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 971f6009-9183-4d65-a94a-0f0d38377983

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-04-07T08:11:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lihongan · 2026-04-07T09:07:34Z

/testwith pull-ci-openshift-installer-release-4.22-e2e-aws-ovn-dualstack-ipv4-primary-techpreview /testwith pull-ci-openshift-installer-release-4.22-e2e-aws-ovn-dualstack-ipv6-primary-techpreview

openshift-ci · 2026-04-07T09:07:38Z

@lihongan, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: pull-ci-openshift-installer-release-4.22-e2e-aws-ovn-dualstack-ipv4-primary-techpreview

lihongan · 2026-04-07T13:14:41Z

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer#10467

Add a lightweight CLI test framework (framework.go) that replicates key exutil.CLI functionality without depending on k8s.io/kubernetes or openshift/origin. The framework provides: - OAuth-first user authentication with ServiceAccount impersonation fallback when User/OAuth APIs are unavailable - ProjectRequest-first namespace provisioning with plain Namespace fallback, including pod security labels and cleanup - Cached typed client accessors (AdminKubeClient, KubeClient, AdminConfigClient, AdminOperatorClient, RouteClient, etc.) - oc CLI wrapper with method chaining (AsAdmin/Run/Args/Execute/Output) - Automatic BeforeEach/AfterEach registration for project setup and teardown Shared helper functions are split into separate files: - test/util.go: generic utilities (exec pod, DNS resolution, curl checks) - test/ingress_util.go: ingress/route helpers (shard deploy, route creation, admission wait, router log dump) - test/dualstack.go: test cases and dualstack-specific helpers Migrate the dual-stack e2e tests (NLB and Classic LB) using this framework, replacing ~70 lines of manual client setup per test with a single NewCLI() call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

lihongan · 2026-04-08T10:07:08Z

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer#10467 openshift/origin#30968

openshift-ci-robot · 2026-04-08T11:14:28Z

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add a lightweight CLI test framework (framework.go) that replicates key
exutil.CLI functionality without depending on k8s.io/kubernetes or
openshift/origin. The framework provides:

OAuth-first user authentication with ServiceAccount impersonation
fallback when User/OAuth APIs are unavailable

ProjectRequest-first namespace provisioning with plain Namespace
fallback, including pod security labels and cleanup

Cached typed client accessors (AdminKubeClient, KubeClient,
AdminConfigClient, AdminOperatorClient, RouteClient, etc.)

oc CLI wrapper with method chaining (AsAdmin/Run/Args/Execute/Output)

Automatic BeforeEach/AfterEach registration for project setup and
teardown

Shared helper functions are split into separate files:

test/util.go: generic utilities (exec pod, DNS resolution, curl checks)

test/ingress_util.go: ingress/route helpers (shard deploy, route
creation, admission wait, router log dump)

test/dualstack.go: test cases and dualstack-specific helpers

Migrate the dual-stack e2e tests (NLB and Classic LB) using this
framework, replacing ~70 lines of manual client setup per test with
a single NewCLI() call.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-08T13:45:19Z

@lihongan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn	`c1f5410`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-hypershift	`c1f5410`	link	true	`/test e2e-hypershift`
ci/prow/e2e-aws-operator-techpreview	`c1f5410`	link	false	`/test e2e-aws-operator-techpreview`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rikatz · 2026-04-08T14:33:37Z

I can see the migrated tests were executed and passed correctly

lihongan · 2026-04-09T01:43:34Z

Yes, so far there is no periodic job for AWS dual-stack TechPreview, and we just need to run the installer presubmit to check the two migrated tests.

Other failing e2e jobs are unrelated to the change, let me retest them

lihongan · 2026-04-09T01:44:04Z

/retest-required

openshift-ci · 2026-04-09T01:44:41Z

@lihongan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lihongan · 2026-04-09T02:39:04Z

/close

openshift-ci · 2026-04-09T02:39:21Z

@lihongan: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2026

openshift-ci Bot requested review from gcs278 and rfredette April 7, 2026 08:10

This was referenced Apr 7, 2026

NE-2131: Remove dualstack e2e tests migrated to cluster-ingress-operator openshift/origin#30968

Closed

WIP: test only openshift/installer#10467

Closed

lihongan force-pushed the migrate-dualstack-tests branch from b96c623 to c1f5410 Compare April 8, 2026 10:03

lihongan changed the title ~~WIP: Migrate dualstack e2e tests from openshift/origin to tests-extension~~ NE-2131: Migrate dualstack e2e tests from openshift/origin to tests-extension Apr 8, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2026

openshift-ci Bot closed this Apr 9, 2026

Conversation

lihongan commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Apr 7, 2026

Uh oh!

lihongan commented Apr 7, 2026

Uh oh!

openshift-ci Bot commented Apr 7, 2026

Uh oh!

lihongan commented Apr 7, 2026

Uh oh!

lihongan commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Apr 8, 2026

Uh oh!

rikatz commented Apr 8, 2026

Uh oh!

lihongan commented Apr 9, 2026

Uh oh!

lihongan commented Apr 9, 2026

Uh oh!

openshift-ci Bot commented Apr 9, 2026

Uh oh!

lihongan commented Apr 9, 2026

Uh oh!

openshift-ci Bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lihongan commented Apr 7, 2026 •

edited

Loading

coderabbitai Bot commented Apr 7, 2026 •

edited

Loading

openshift-ci-robot commented Apr 8, 2026 •

edited by openshift-ci Bot

Loading