Skip to content

[release-4.19] OSSM-10865: set trustBundleName in Istio global values#1419

Open
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1288-to-release-4.19
Open

[release-4.19] OSSM-10865: set trustBundleName in Istio global values#1419
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1288-to-release-4.19

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #1288

/assign rhamini3

skriss added 2 commits April 16, 2026 17:43
Sets trustBundleName in order to customize the
name of the configmap containing the CA cert so
it doesn't clash with a standalone OSSM instance.

Follow-up to openshift#1243.

Signed-off-by: Steve Kriss <skriss@redhat.com>
Signed-off-by: Steve Kriss <skriss@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 16, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OSSM-10865

Details

In response to this:

This is an automated cherry-pick of #1288

/assign rhamini3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c3f2049-467d-4f5b-8958-080e514a0c3a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bentito and candita April 16, 2026 17:44
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign candita for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 16, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 15bd5e4 link true /test e2e-aws-ovn
ci/prow/e2e-azure-ovn 15bd5e4 link false /test e2e-azure-ovn
ci/prow/unit 15bd5e4 link true /test unit
ci/prow/e2e-hypershift 15bd5e4 link true /test e2e-hypershift
ci/prow/images 15bd5e4 link true /test images
ci/prow/e2e-aws-ovn-upgrade 15bd5e4 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-serial 15bd5e4 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-operator 15bd5e4 link true /test e2e-aws-operator
ci/prow/hypershift-e2e-aks 15bd5e4 link true /test hypershift-e2e-aks
ci/prow/e2e-azure-operator 15bd5e4 link true /test e2e-azure-operator
ci/prow/e2e-gcp-operator 15bd5e4 link true /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Miciah
Copy link
Copy Markdown
Contributor

Miciah commented Apr 21, 2026

ci/prow/unit failed because of a build failure:

 pkg/operator/controller/gatewayclass/istio.go:169:6: unknown field TrustBundleName in struct literal of type "github.com/istio-ecosystem/sail-operator/api/v1".GlobalConfig 

We'll need a vendor bump to get the updated Go type definition.

@Miciah
Copy link
Copy Markdown
Contributor

Miciah commented May 1, 2026

Bumping to openshift-service-mesh/sail-operator@30be832 requires bumping to Go 1.24 and k8s.io 1.33. That could be problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants