[release-4.21] OCPBUGS-84834: Bump GWAPI CRDs to v1.4.1 OSSM 3.3.1 and Istio v1.28.5#1444
[release-4.21] OCPBUGS-84834: Bump GWAPI CRDs to v1.4.1 OSSM 3.3.1 and Istio v1.28.5#1444rhamini3 wants to merge 1 commit into
Conversation
|
@rhamini3: This pull request references Jira Issue OCPBUGS-84834, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/jira refresh |
|
@rhamini3: This pull request references Jira Issue OCPBUGS-84834, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-gatewayapi-conformance |
|
/retest |
|
/retest-required |
|
/test e2e-vsphere-static-metallb-gatewayapi-conformance |
|
Marking as verified since the bump is successful and gatewayAPI objects are created successfully /verified by @mjoseph |
|
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/test e2e-aws-ovn-hypershift-conformance |
|
I'll take a look |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-aws-gatewayapi-conformance |
|
/retest-required |
|
/testwith openshift/origin/release-4.21/e2e-gcp-ovn-upgrade openshift/origin#31232 |
|
added a csv check just to prove that upgrades aren't working in openshift/origin#31232 |
|
/testwith openshift/origin/release-4.21/e2e-gcp-ovn-upgrade openshift/origin#31232 |
|
/test e2e-aws-gatewayapi-conformance |
|
/test e2e-aws-gatewayapi-conformance |
|
/testwith openshift/origin/release-4.21/e2e-gcp-ovn-upgrade openshift/origin#31232 |
|
@rhamini3 we should be safe to proceed with this now that NoOLM has been backported to 4.21. Let me re-kick all of the tests: |
|
/test ? |
|
Important not to forget about these: /test e2e-vsphere-static-metallb-operator-gwapi |
|
/retest-required |
|
|
gcs278
left a comment
There was a problem hiding this comment.
Looking good @rhamini3 - CI is looking good and I think we are close to merging. One comment and could I get you to add some other housekeeping stuff:
- Pre-pend
[release-4.21]to the Github PR title - not sure if it's a requirement, but it helps identify this as a 4.21 backport - Document links that this manual backport of #1406, #1343, and #1396 in the PR Description. It's a combination of all 3. It'd be good to document which PRs are being pulled back so we have a clear trail.
There was a problem hiding this comment.
Did we need to backport pkg/manifests/manifests_test.go too? That was added in #1343 (side note: github diff is broken for that PR..), but you'd want to add this right 10e14fd#diff-b388a528a3665a46f4dfa8eb4a8c02de116acb8f85e4611f12f11dc337d7f7b5?
There was a problem hiding this comment.
ah yes, thanks for catching that
|
@rhamini3: This pull request references Jira Issue OCPBUGS-84834, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-gatewayapi-conformance |
|
/jira refresh |
|
@gcs278: This pull request references Jira Issue OCPBUGS-84834, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test hypershift-e2e-aks |
|
@rhamini3: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
This PR is bumping OSSM and Istio to the latest z-stream version to target CVE fixes.
This manual backport is a combination of #1406, #1343, and #1396 . These are the PRs containing the GWAPI CRD and OSSM bumps from the 4.22 release