Bump GWAPI CRDs to v1.4.1 OSSM 3.3.1 and Istio v1.28.5#1455
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-aws-gatewayapi-conformance |
|
/retest |
|
/retest |
Thealisyed
left a comment
Thealisyed
left a comment
There was a problem hiding this comment.
Another small nit, few yaml files are missing the newline at the end btw...
@coderabbitai maybe you can try and preemptively answer my questions? 👀
| if [[ "$BUNDLE_VERSION" = "v1.3.0" ]]; then | ||
| echo "Cherry-picking fix for CoreDNS deployment image tag shortname issue in v1.3.0" | ||
| git fetch origin 7f612b97fec9edd3aa32d193a4e9b4c3161ed09a | ||
| git cherry-pick 7f612b97fec9edd3aa32d193a4e9b4c3161ed09a |
There was a problem hiding this comment.
So the conformance tests will run against 1.4.1 right? How does this work then if bundle version is 1.3.0?
There was a problem hiding this comment.
the bundle version is picked up by BUNDLE_VERSION=$(oc get crds gateways.gateway.networking.k8s.io -ojson | jq -r '.metadata.annotations."gateway.networking.k8s.io/bundle-version"') so it should get the CRD version with this change pointing to 1.4.1
Hey, which files are you referring to? All the changed files are showing a new line on my end |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get the list of changed files in the PR
gh pr view 1455 --repo openshift/cluster-ingress-operator --json files --jq '.files[].path' | grep -E '\.yaml$|\.yml$'Length of output: 758 🏁 Script executed: #!/bin/bash
# Check each changed YAML file for trailing newline
for f in $(gh pr view 1455 --repo openshift/cluster-ingress-operator --json files --jq '.files[].path' | grep -E '\.yaml$|\.yml$'); do
echo "=== $f ==="
# Check last byte of file
last_char=$(tail -c 1 "$f" | xxd | head -1)
echo "Last byte: $last_char"
# Also show last line
tail -1 "$f" | cat -A
doneLength of output: 1554 🏁 Script executed: #!/bin/bash
# Get the diff to see which YAML files were modified and check for \No newline at end of file
gh pr diff 1455 --repo openshift/cluster-ingress-operator | grep -E '(^\+\+\+|No newline at end of file|\.yaml|\.yml)'Length of output: 4007
These are likely inherited from the upstream CRD sources (GWAPI/OSSM/Istio) as-is. If your editor is showing a newline, it may be auto-adding one on display — but the actual file bytes don't have a trailing tail -c 1 pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml | od -cA quick fix would be to run: for f in \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_grpcroutes.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml; do
echo "" >> "$f"
done |
|
@coderabbitai can you check if the new line has been added now? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check the current PR diff for the 5 YAML files to see if "No newline at end of file" still appears
gh pr diff 1455 --repo openshift/cluster-ingress-operator | grep -E '(No newline at end of file|gateway\.networking\.k8s\.io_)'Length of output: 2683 🏁 Script executed: #!/bin/bash
# Also verify by checking the last character of each file directly
for f in \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_grpcroutes.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml \
pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml; do
echo "=== $f ==="
tail -c 1 "$f" | od -c | head -1
doneLength of output: 1230
Fixed ✅ (trailing newline now present):
Still missing trailing newline ❌:
You can fix both remaining files with: echo "" >> pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml
echo "" >> pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_backendtlspolicies.yaml |
|
@coderabbitai check once more |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check current PR diff for "No newline at end of file" markers
gh pr diff 1455 --repo openshift/cluster-ingress-operator | grep -E '(No newline at end of file|gateway\.networking\.k8s\.io_)'Length of output: 2590
All 6 YAML files in this PR now have proper trailing newlines. |
|
@rhamini3: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @gcs278 |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Bumping the GWAPI CRDs to v1.4.1 OSSM 3.3.1 and Istio v1.28.5 to target CVE fixes