OCPBUGS-90616: Add GRPCRoute to Gateway API e2e CRD test coverage

[Thealisyed]

Summary

• Add grpcroutes.gateway.networking.k8s.io to the crdNames list in gateway_api_test.go so that existing e2e tests (CRD existence, lifecycle, VAP protection) also cover GRPCRoute

The buildGWAPICRDFromName switch already has a grpcroutes case, so no other changes are needed.

[openshift-ci-robot]

@Thealisyed: This pull request references Jira Issue OCPBUGS-90616, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Add grpcroutes.gateway.networking.k8s.io to the crdNames list in gateway_api_test.go so that existing e2e tests (CRD existence, lifecycle, VAP protection) also cover GRPCRoute

The buildGWAPICRDFromName switch already has a grpcroutes case, so no other changes are needed.

Bug

https://issues.redhat.com/browse/OCPBUGS-90616

Test plan

• Verify go vet -tags e2e ./test/e2e/... passes (confirmed locally)
• CI e2e: testGatewayAPIResources verifies GRPCRoute CRD existence and lifecycle
• CI e2e: testGatewayAPIResourcesProtection verifies VAP blocks deletion of GRPCRoute CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9f75d87a-1aa0-41aa-bbc9-52c2bb1ed810

📥 Commits

Reviewing files that changed from the base of the PR and between da0931c and a5c99e2.

📒 Files selected for processing (1)

• test/e2e/gateway_api_test.go

---

📝 Walkthrough

Walkthrough

The Gateway API e2e test file is updated to include grpcroutes.gateway.networking.k8s.io in the crdNames slice. This slice enumerates the expected Gateway API CRDs and is used by tests that verify CRD existence and CRD recreation after deletion.

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Ote Binary Stdout Contract	❌ Error	test/e2e/operator_test.go TestMain uses fmt.Printf to stdout for setup errors, violating the JSON-on-stdout contract.	Redirect those messages to os.Stderr (or a stderr logger) before any JSON output; keep stdout reserved for openshift-tests communication.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding GRPCRoute to Gateway API e2e CRD coverage.
Description check	✅ Passed	The description is directly related and correctly explains the CRD list update and its test coverage impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only the CRD list changed; all test titles in the file are static literals or table names, with no dynamic suffixes or generated values.
Test Structure And Quality	✅ Passed	PASS: The change only extends an existing CRD list; no new It blocks or waits were added, and the shared helper already supports grpcroutes with existing cleanup/timeout patterns.
Microshift Test Compatibility	✅ Passed	PASS: The PR only adds GRPCRoute to an existing CRD list; it adds no new Ginkgo tests or MicroShift-unsupported APIs/features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only adds grpcroutes to an existing CRD list; affected tests are API-level, and existing SNO handling already adjusts HPA min replicas.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only adds e2e Gateway API test coverage; I found no node selectors, anti-affinity, spread constraints, tolerations, or topology-aware scheduling code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The change only adds GRPCRoute to an existing CRD list; no new Ginkgo tests, IPv4-only logic, or external connectivity was introduced.
No-Weak-Crypto	✅ Passed	Touched file only adds a CRD name string; no weak crypto APIs, custom crypto, or secret comparisons appear.
Container-Privileges	✅ Passed	Only an e2e test CRD name list changed; no manifests or container securityContext fields with privileged settings were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	Only a CRD name was added to an e2e test list; no new logging or sensitive-data output was introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[Thealisyed]

/jira refresh

[openshift-ci-robot]

@Thealisyed: This pull request references Jira Issue OCPBUGS-90616, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rfredette for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Thealisyed]

input images failure

/retest

[openshift-ci]

@Thealisyed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance	a5c99e2	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-gcp-operator	a5c99e2	link	true	/test e2e-gcp-operator
ci/prow/e2e-aws-ovn	a5c99e2	link	true	/test e2e-aws-ovn
ci/prow/e2e-hypershift	a5c99e2	link	true	/test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.