fix: skip duplicate Analysis stage in approve & upgrade flow

When an ApprovalPolicy auto-approves the Analysis stage, clicking
"Approve & upgrade" would fail with a duplicate key error because
the stage was unconditionally added again. Now checks if the Analysis
stage already exists before calling approveStage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jrangelramos

src/components/update-plan/DecisionActions.tsx

@@ -44,8 +44,7 @@ const DecisionActions: React.FC<DecisionActionsProps> = ({ proposal, clusterVers
     [approvals, proposal.metadata?.name, proposal.metadata?.namespace],
   );
 
-  const { approveStage, denyStage, error, clearError, inProgress } =
-    useApprovalActions(approval);
+  const { approveStage, denyStage, error, clearError, inProgress } = useApprovalActions(approval);
 
   const [confirmingApprove, setConfirmingApprove] = React.useState(false);
   const [confirmingDeny, setConfirmingDeny] = React.useState(false);
@@ -66,8 +65,11 @@ const DecisionActions: React.FC<DecisionActionsProps> = ({ proposal, clusterVers
       setConfirmingApprove(false);
       setUpgradeError(null);
 
-      const approved = await approveStage('Analysis');
-      if (!approved) return;
+      const alreadyApproved = approval?.spec?.stages?.some((s) => s.type === 'Analysis');
+      if (!alreadyApproved) {
+        const approved = await approveStage('Analysis');
+        if (!approved) return;
+      }
 
       const rawTarget = proposal.metadata?.labels?.[LABELS.targetVersion] ?? '';
       const targetVersion = rawTarget ? unsanitizeVersion(rawTarget) : '';
@@ -109,7 +111,15 @@ const DecisionActions: React.FC<DecisionActionsProps> = ({ proposal, clusterVers
         setConfirmingApprove(false);
       }, CONFIRM_TIMEOUT_MS);
     }
-  }, [confirmingApprove, approveStage, proposal, clusterVersion, history, t]);
+  }, [
+    confirmingApprove,
+    approveStage,
+    approval?.spec?.stages,
+    proposal,
+    clusterVersion,
+    history,
+    t,
+  ]);
 
   const handleDenyClick = React.useCallback(async () => {
     if (confirmingDeny) {