pkg/cvo: Wait until ConfigMap informers have synced

Avoid startup-time "hey, I can't find those ConfigMaps!" complaints
from pkg/risk/adminack by waiting until the informers have
synchronized.

The pkg/cvo Operator type has a cacheSynced that's populated in
Operator.New (with the ClusterVersion, ClusterOperator, and
FeatureGate informers).  cacheSynced goes all the way back to
648d27c (metrics: Report a gauge for when cluster operator
conditions change, 2019-01-31, #107).  But when we added the initial
ConfigMap informer as cmLister back in c147732 (metrics: add
cluster_installer series, 2019-06-26, #213) we didn't add that
informer to cacheSynced.  And when I added cmManagedInformer in
d18deee (pkg/cvo: Separate ConfigMap informer for
openshift-config-managed, 2020-08-21, #441), I didn't add that
informer to cacheSynced.  None of these earlier commits explain why
the ConfigMap informers were not included in cacheSynced, so I'm
assuming that was oversight, and catching up now.

There is a risk that the ConfigMap informers fail to synchronize
quickly, but I'm having trouble imagining a situation where that would
happen but the ClusterVersion and ClusterOperator informers wouldn't
also fail to synchronize.  And either way, we don't serve metrics
while we wait on this cache synchronization, so the critical
ClusterVersionOperatorDown alert will be firing within 10 minutes, and
the responding system administrators can sort out whatever was giving
the cache-sync logic trouble.

Author: wking

pkg/cvo/cvo.go

@@ -296,7 +296,9 @@ func New(
 
 	optr.proxyLister = proxyInformer.Lister()
 	optr.cmConfigLister = cmConfigInformer.Lister().ConfigMaps(internal.ConfigNamespace)
+	optr.cacheSynced = append(optr.cacheSynced, cmConfigInformer.Informer().HasSynced)
 	optr.cmConfigManagedLister = cmConfigManagedInformer.Lister().ConfigMaps(internal.ConfigManagedNamespace)
+	optr.cacheSynced = append(optr.cacheSynced, cmConfigManagedInformer.Informer().HasSynced)
 
 	optr.featureGateLister = featureGateInformer.Lister()
 	optr.cacheSynced = append(optr.cacheSynced, featureGateInformer.Informer().HasSynced)

pkg/risk/adminack/adminack.go

@@ -37,14 +37,21 @@ type adminAck struct {
 	currentVersion   func() configv1.Release
 	adminGatesLister listerscorev1.ConfigMapNamespaceLister
 	adminAcksLister  listerscorev1.ConfigMapNamespaceLister
+	hasSynced        func() bool
 	lastSeen         []configv1.ConditionalUpdateRisk
 }
 
 // New returns a new update-risk source, tracking administrator acknowledgements.
 func New(name string, currentVersion func() configv1.Release, adminGatesInformer, adminAcksInformer informerscorev1.ConfigMapInformer, changeCallback func()) risk.Source {
 	adminGatesLister := adminGatesInformer.Lister().ConfigMaps(internal.ConfigManagedNamespace)
 	adminAcksLister := adminAcksInformer.Lister().ConfigMaps(internal.ConfigNamespace)
-	source := &adminAck{name: name, currentVersion: currentVersion, adminGatesLister: adminGatesLister, adminAcksLister: adminAcksLister}
+	source := &adminAck{
+		name: name,
+		currentVersion: currentVersion,
+		adminGatesLister: adminGatesLister,
+		adminAcksLister: adminAcksLister,
+		hasSynced: func() bool { return adminGatesInformer.Informer().HasSynced() && adminAcksInformer.Informer().HasSynced() },
+	}
 	adminGatesInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
 		AddFunc:    func(_ interface{}) { source.eventHandler(changeCallback) },
 		UpdateFunc: func(_, _ interface{}) { source.eventHandler(changeCallback) },
@@ -102,6 +109,10 @@ func (a *adminAck) risks() ([]configv1.ConditionalUpdateRisk, semver.Version, er
 		}}, version, err
 	}
 
+	if !a.hasSynced() {
+		return nil, version, nil
+	}
+
 	var gateCm *corev1.ConfigMap
 	if gateCm, err = a.adminGatesLister.Get(internal.AdminGatesConfigMap); err != nil {
 		return []configv1.ConditionalUpdateRisk{{