Skip to content

OTA-1966: AGENTS: Drop 'Deploying CVO with Lightspeed Proposals' section#1414

Open
wking wants to merge 1 commit into
openshift:mainfrom
wking:drop-agents-section-on-lightspeed-proposals
Open

OTA-1966: AGENTS: Drop 'Deploying CVO with Lightspeed Proposals' section#1414
wking wants to merge 1 commit into
openshift:mainfrom
wking:drop-agents-section-on-lightspeed-proposals

Conversation

@wking

@wking wking commented Jun 26, 2026

Copy link
Copy Markdown
Member

We grew this recently in b0e4c90 (#1395). But I don't think we need it.

The proposal controller is gated behind TechPreviewNoUpgrade. To test on a Default feature set cluster...

But folks can test on a tech-preview cluster, and I don't see a need to have folks edit and recompile the cluster-version operator to test on Default-feature-set clusters, when we have official docs on how to set your non-production cluster TechPreviewNoUpgrade.

Build and push the skills image...

But we have official build of the skills image by both ART and CI:

$ oc -n ocp get -o json imagestream 5.0-art-latest | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image'
2026-06-19T02:09:51Z sha256:3df589bb38baa9ba5ee08e48707585b7a9a90c8e37958c761420804284034d57
2026-06-17T23:09:07Z sha256:c0a98a27549db71c5fc319eadbabe0549f9f467cef0eadec683999685cd30b8f
2026-06-15T21:27:00Z sha256:c69acc6ee37d2e1b898bc0ef9999412837e2234b6bae30ad0e6e3ef2f35e3091
$ oc -n ocp get -o json imagestream 5.0 | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image'
2026-06-10T17:53:31Z sha256:0c07886422894f138c40de3f9b85e76d374781f5ed0883d738466ecc41874de8
2026-06-02T13:28:31Z sha256:fad8159b2909f408837e9de2388cc5b946dca97a191dde44fae14694ee23b6ea
2026-05-28T20:13:04Z sha256:f683f957e7bfaa37578462f16932fbf67846b6e8b1b6f25841b539738a72fc62

and we'll soon be wiring those up to be included in the OpenShift release payload. Which will mean that folks who want to excercise custom skills image content will get that on presubmits in https://github.com/openshift/agentic-skills pulls, and Cluster Bot can generate new payloads which combine open agentic-skills pull requests with other open pull requests, and all the usual things.

Apply the prompt ConfigMap...

When enabled (e.g. in a TechPreviewNoUpgrade standalone cluster), the cluster-version operator will apply the cluster-update-advisory-prompt ConfigMap (and the other manifests associated with this functionality) automatically. There's no need for users to manually apply those manifests.

Summary by CodeRabbit

  • Documentation
    • Removed the “Deploying CVO with Lightspeed Proposals (Dev)” section from the contributor guide.
    • Simplified the documented setup by omitting several local deployment and environment configuration steps.

We grew this recently in b0e4c90 (pkg/readiness: Add readiness
checks and wire into proposal controller, 2026-05-27, openshift#1395).  But I
don't think we need it.

> The proposal controller is gated behind `TechPreviewNoUpgrade`. To
> test on a Default feature set cluster...

But folks can test on a tech-preview cluster, and I don't see a need
to have folks edit and recompile the cluster-version operator to test
on Default-feature-set clusters, when we have official docs on how to
set your non-production cluster TechPreviewNoUpgrade [1].

> Build and push the skills image...

But we have official build of the skills image by both ART and CI:

  $ oc -n ocp get -o json imagestream 5.0-art-latest | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image'
  2026-06-19T02:09:51Z sha256:3df589bb38baa9ba5ee08e48707585b7a9a90c8e37958c761420804284034d57
  2026-06-17T23:09:07Z sha256:c0a98a27549db71c5fc319eadbabe0549f9f467cef0eadec683999685cd30b8f
  2026-06-15T21:27:00Z sha256:c69acc6ee37d2e1b898bc0ef9999412837e2234b6bae30ad0e6e3ef2f35e3091
  $ oc -n ocp get -o json imagestream 5.0 | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image'
  2026-06-10T17:53:31Z sha256:0c07886422894f138c40de3f9b85e76d374781f5ed0883d738466ecc41874de8
  2026-06-02T13:28:31Z sha256:fad8159b2909f408837e9de2388cc5b946dca97a191dde44fae14694ee23b6ea
  2026-05-28T20:13:04Z sha256:f683f957e7bfaa37578462f16932fbf67846b6e8b1b6f25841b539738a72fc62

and we'll soon be wiring those up to be included in the OpenShift
release payload.  Which will mean that folks who want to excercise
custom skills image content will get that on presubmits in
https://github.com/openshift/agentic-skills pulls, and Cluster Bot can
generate new payloads which combine open agentic-skills pull requests
with other open pull requests, and all the usual things.

> Apply the prompt ConfigMap...

When enabled (e.g. in a TechPreviewNoUpgrade standalone cluster), the
cluster-version operator will apply the cluster-update-advisory-prompt
ConfigMap (and the other manifests associated with this functionality)
automatically.  There's no need for users to manually apply those
manifests.

[1]: https://docs.redhat.com/en/documentation/openshift_container_platform/4.22/html/postinstallation_configuration/post-install-cluster-tasks#post-install-tp-tasks
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@wking: This pull request references OTA-1966 which is a valid jira issue.

Details

In response to this:

We grew this recently in b0e4c90 (#1395). But I don't think we need it.

The proposal controller is gated behind TechPreviewNoUpgrade. To test on a Default feature set cluster...

But folks can test on a tech-preview cluster, and I don't see a need to have folks edit and recompile the cluster-version operator to test on Default-feature-set clusters, when we have official docs on how to set your non-production cluster TechPreviewNoUpgrade.

Build and push the skills image...

But we have official build of the skills image by both ART and CI:

$ oc -n ocp get -o json imagestream 5.0-art-latest | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image'
2026-06-19T02:09:51Z sha256:3df589bb38baa9ba5ee08e48707585b7a9a90c8e37958c761420804284034d57
2026-06-17T23:09:07Z sha256:c0a98a27549db71c5fc319eadbabe0549f9f467cef0eadec683999685cd30b8f
2026-06-15T21:27:00Z sha256:c69acc6ee37d2e1b898bc0ef9999412837e2234b6bae30ad0e6e3ef2f35e3091
$ oc -n ocp get -o json imagestream 5.0 | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image'
2026-06-10T17:53:31Z sha256:0c07886422894f138c40de3f9b85e76d374781f5ed0883d738466ecc41874de8
2026-06-02T13:28:31Z sha256:fad8159b2909f408837e9de2388cc5b946dca97a191dde44fae14694ee23b6ea
2026-05-28T20:13:04Z sha256:f683f957e7bfaa37578462f16932fbf67846b6e8b1b6f25841b539738a72fc62

and we'll soon be wiring those up to be included in the OpenShift release payload. Which will mean that folks who want to excercise custom skills image content will get that on presubmits in https://github.com/openshift/agentic-skills pulls, and Cluster Bot can generate new payloads which combine open agentic-skills pull requests with other open pull requests, and all the usual things.

Apply the prompt ConfigMap...

When enabled (e.g. in a TechPreviewNoUpgrade standalone cluster), the cluster-version operator will apply the cluster-update-advisory-prompt ConfigMap (and the other manifests associated with this functionality) automatically. There's no need for users to manually apply those manifests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 17fe14a6-0a57-43e5-b197-b18b54f191e0

📥 Commits

Reviewing files that changed from the base of the PR and between dd0a841 and 7d60901.

📒 Files selected for processing (1)
  • AGENTS.md
💤 Files with no reviewable changes (1)
  • AGENTS.md

Walkthrough

AGENTS.md removes the “Deploying CVO with Lightspeed Proposals (Dev)” section and its associated deployment and cleanup instructions.

Changes

Cohort / File(s) Summary
AGENTS.md cleanup
AGENTS.md
Removed the Lightspeed Proposals deployment guidance section and all related steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing the Deploying CVO with Lightspeed Proposals section from AGENTS.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR only drops docs in AGENTS.md; no test files or Ginkgo titles were changed.
Test Structure And Quality ✅ Passed Only AGENTS.md changed; no Ginkgo tests or cluster-interaction code were modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed Docs-only AGENTS.md removal; no new Ginkgo tests or test code were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only AGENTS.md docs were removed; no Ginkgo tests or SNO-sensitive code were added or changed.
Topology-Aware Scheduling Compatibility ✅ Passed Only AGENTS.md was changed; the diff removes docs and adds no manifests/controllers/scheduling logic.
Ote Binary Stdout Contract ✅ Passed Docs-only PR removes AGENTS guidance; OTE entrypoint remains unchanged and has no stdout writes in main/setup, so contract unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Docs-only AGENTS.md removal; no new Ginkgo tests or network-sensitive code were added.
No-Weak-Crypto ✅ Passed PR only removes AGENTS.md docs; no weak-crypto code, custom crypto, or secret comparisons were added in the changed content.
Container-Privileges ✅ Passed This PR only removes docs in AGENTS.md; no container/K8s manifests or security-context fields were changed.
No-Sensitive-Data-In-Logs ✅ Passed The only touched doc section contains generic commands and image digests, with no passwords, tokens, PII, or internal/customer data exposed.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants