Skip to content

fix(deps): update module gopkg.in/yaml.v2 to v3#582

Open
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/gopkg.in-yaml.v2-3.x
Open

fix(deps): update module gopkg.in/yaml.v2 to v3#582
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/gopkg.in-yaml.v2-3.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
gopkg.in/yaml.v2 v2.4.0v3.0.1 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

go-yaml/yaml (gopkg.in/yaml.v2)

v3.0.1

Compare Source

v3.0.0

Compare Source


Configuration

📅 Schedule: (in timezone UTC)

  • Branch creation
    • Between 02:00 AM and 04:59 AM, Monday through Friday (* 2-4 * * 1-5)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux red-hat-konflux Bot added area/dependency Issues or PRs related to dependency changes major-update manual-review-required ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Walkthrough

This PR migrates the YAML library dependency from gopkg.in/yaml.v2 to gopkg.in/yaml.v3 across the codebase. Import statements are updated in controllers/secret_controller.go, its test file, pkg/types/alertmanagerconfig.go, and test/e2e/utils/utils.go, with go.mod updated accordingly, retaining yaml.v2 as an indirect dependency.

Changes

YAML dependency migration

Layer / File(s) Summary
Dependency declaration update
go.mod
Direct requirement changes from gopkg.in/yaml.v2 v2.4.0 to gopkg.in/yaml.v3 v3.0.1; yaml.v2 v2.4.0 is added back as an indirect dependency.
Source file import updates
controllers/secret_controller.go, pkg/types/alertmanagerconfig.go
YAML imports switch to yaml.v3, changing the implementation backing existing Marshal/Unmarshal calls for namespace config and Alertmanager config handling.
Test and e2e utility import updates
controllers/secret_controller_test.go, test/e2e/utils/utils.go
YAML imports switch to yaml.v3 in test and e2e utility code, changing the implementation backing YAML parsing in tests.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related PRs: None found

Suggested labels: dependencies, go

Suggested reviewers: None identified

🐰 Hopping through imports, swift and spry,
v2 to v3, waving goodbye,
Marshal and parse with a newer might,
go.mod tidied up just right,
A carrot for clean YAML delight! 🥕

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were changed; the touched test file only uses static table-driven names and no dynamic title construction.
Test Structure And Quality ✅ Passed PASS: The PR only swaps yaml v2→v3 imports/dependency; touched test files are plain testing helpers, with no Ginkgo specs, cluster ops, or timeout/assertion-pattern changes.
Microshift Test Compatibility ✅ Passed This is a dependency-only update; the touched test file is a helper and no new Ginkgo e2e tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only updates YAML imports/deps; no new or modified Ginkgo e2e specs appear in the diff, and the changed test file has no Ginkgo nodes.
Topology-Aware Scheduling Compatibility ✅ Passed Only yaml.v2→v3 import/dependency updates were changed; no pod specs, replicas, affinity, selectors, or topology-aware scheduling logic were added.
Ote Binary Stdout Contract ✅ Passed Diff only swaps yaml v2→v3 imports and has no main/init/TestMain/suite setup or stdout writes in touched files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the diff only changes YAML imports/helpers and contains no IPv4 assumptions or external-network calls.
No-Weak-Crypto ✅ Passed Diff only swaps yaml.v2 to yaml.v3; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or unsafe comparisons found.
Container-Privileges ✅ Passed Only YAML dependency/import updates changed; no privileged:true, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation:true was added.
No-Sensitive-Data-In-Logs ✅ Passed Patch only updates yaml imports/dependency versions; no logging changes or new sensitive data exposure were introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the dependency upgrade from gopkg.in/yaml.v2 to v3.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/gopkg.in-yaml.v2-3.x

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from smarthall and xiaoyu74 June 26, 2026 04:23
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign bmeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.61%. Comparing base (95b8d9a) to head (9a951e6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files           8        8           
  Lines        1124     1124           
=======================================
  Hits          760      760           
  Misses        330      330           
  Partials       34       34           
Files with missing lines Coverage Δ
controllers/secret_controller.go 88.36% <ø> (ø)
pkg/types/alertmanagerconfig.go 52.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed Jul 8, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jul 8, 2026
@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch July 8, 2026 00:11
@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed fix(deps): update module gopkg.in/yaml.v2 to v3 Jul 8, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jul 8, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch 2 times, most recently from 0426349 to 0bef794 Compare July 8, 2026 04:12
@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed Jul 12, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jul 12, 2026
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed fix(deps): update module gopkg.in/yaml.v2 to v3 Jul 13, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jul 13, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch 2 times, most recently from 0bef794 to 9a951e6 Compare July 13, 2026 04:19
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@red-hat-konflux[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 9a951e6 link true /test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes major-update manual-review-required ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants