fix(oidc): fix OIDCClientSecretGet condition

devguyio · devguyio · commit 868d0b7955ed · 2025-09-05T13:22:21.000+02:00
set the OIDCClientSecretGet condition when client secrets
don't exist in the openshift-config namespace instead of
the openshift-console namespace.

Signed-off-by: Ahmed Abdalla &lt;aabdelre@redhat.com&gt;
diff --git a/pkg/console/controllers/oidcsetup/oidcsetup.go b/pkg/console/controllers/oidcsetup/oidcsetup.go
@@ -200,7 +200,7 @@ func (c *oidcSetupController) syncAuthTypeOIDC(ctx context.Context, authnConfig
 		return nil
 	}
 
-	clientSecret, err := c.targetNSSecretsLister.Secrets(api.TargetNamespace).Get("console-oauth-config")
+	clientSecret, err := c.targetNSSecretsLister.Secrets(api.OpenShiftConfigNamespace).Get(clientConfig.ClientSecret.Name)
 	if err != nil {
 		c.authStatusHandler.Degraded("OIDCClientSecretGet", err.Error())
 		return err

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ func (c *oidcSetupController) syncAuthTypeOIDC(ctx context.Context, authnConfig`
`200`	`200`	`return nil`
`201`	`201`	`}`
`202`	`202`
`203`		`- clientSecret, err := c.targetNSSecretsLister.Secrets(api.TargetNamespace).Get("console-oauth-config")`
	`203`	`+ clientSecret, err := c.targetNSSecretsLister.Secrets(api.OpenShiftConfigNamespace).Get(clientConfig.ClientSecret.Name)`
`204`	`204`	`if err != nil {`
`205`	`205`	`c.authStatusHandler.Degraded("OIDCClientSecretGet", err.Error())`
`206`	`206`	`return err`