Skip to content

Commit 20f10e0

Browse files
committed
NO-JIRA: Merge PR templates
Rename .github/PULL_REQUEST_TEMPLATE/console_pr.md -> .github/PULL_REQUEST_TEMPLATE.md.md and refactor its content: convert HTML headings to concise bold section labels, add Analysis/Root cause, Solution Description, Screenshots/screen recording, Test setup/test cases, and Browser conformance checkboxes, and reorganize reviewer/assignee guidance. Also delete .github/PULL_REQUEST_TEMPLATE/devconsole_pr.md. These changes standardize and expand the PR template to capture testing, design artifacts, and browser conformance information.
1 parent 6a8db8b commit 20f10e0

2 files changed

Lines changed: 20 additions & 37 deletions

File tree

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<h2 id="feature-fix">CONSOLE Features and Fixes:</h2>
1+
**Fixes**: https://redhat.atlassian.net/browse/
22
<!--The pull request title must be prefixed with a Jira issue or Bugzilla bug in order to be merged. For example:
33
For e.g Features: https://issues.redhat.com/browse/CONSOLE-XXXX
44
- CONSOLE-XXXX: <title>
@@ -9,32 +9,38 @@
99
Combos:
1010
- CONSOLE-XXXX, Bug XXXXXXX: <title>-->
1111

12-
<h2 id="solution-description">Solution description</h2>
13-
<!-- Describe your code changes in detail and explain the solution or functionality -->
12+
**Analysis / Root cause**:
13+
<!-- Briefly describe analysis of US/Task or root cause of Defect -->
1414

15-
<h2 id="reviewers-and-assignees">Reviewers and assignees:</h2>
16-
<!--
15+
**Reviewers and assignees:**
16+
<!--
1717
- Tag an OCP console engineer to review the changes.
1818
- If there are visual, content, or interaction changes in the PR, tag "@openshift/team-ux-review"
1919
- If the PR is implementing a story, assign QE, docs, and PX approvers:
2020
Console Approver:
2121
/assign <gh-user>
2222
23-
QE approver:
24-
/assign <gh-user>
25-
2623
Docs approver:
2724
/assign <gh-user>
28-
25+
2926
PX approver:
3027
/assign <gh-user>
3128
-->
3229

33-
<h2 id="test-cases">Test cases:</h2>
34-
<!-- Outline any test cases here -->
30+
**Solution Description**:
31+
<!-- Describe your code changes in detail and explain the solution or functionality -->
32+
33+
**Screenshots / screen recording / design review**:
34+
<!-- Add screenshots or screen recordings for visual changes. Be sure to include before and after videos where relevant -->
35+
36+
**Test setup / test cases:**
37+
<!-- If any setup required to test this PR, mention the details -->
3538

36-
<h2 id="additional-info">Additional info:</h2>
39+
**Additional info:**
3740
<!-- Add any additional info here -->
3841

39-
<h2 id="screenshots">Screen shots / gifs / design review:</h2>
40-
<!-- Add screenshots or gifs for visual changes. Be sure to include before and after where relevant -->
42+
**Browser conformance**:
43+
<!-- To mark tested browsers, use [x] -->
44+
- [ ] Chrome
45+
- [ ] Firefox
46+
- [ ] Safari

.github/PULL_REQUEST_TEMPLATE/devconsole_pr.md

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)