Skip to content

Commit 63e97fa

Browse files
Merge pull request #13487 from lokanandaprabhu/feature/OCPBUGS-26415
OCPBUGS-26415: Application creation fail when manually entering input scaling value in local setup
2 parents 395ac92 + 3473b1a commit 63e97fa

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

frontend/packages/console-shared/src/components/formik-fields/NumberSpinnerField.tsx

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,16 @@ import { RedExclamationCircleIcon } from '../status';
88
import { FieldProps } from './field-types';
99
import { getFieldId } from './field-utils';
1010

11-
const NumberSpinnerField: React.FC<FieldProps> = ({ label, helpText, required, ...props }) => {
11+
interface NumberSpinnerFieldProps extends FieldProps {
12+
setOutputAsIntegerFlag?: boolean;
13+
}
14+
15+
const NumberSpinnerField: React.FC<NumberSpinnerFieldProps> = ({
16+
label,
17+
helpText,
18+
required,
19+
...props
20+
}) => {
1221
const [field, { touched, error }] = useField(props.name);
1322
const { setFieldValue, setFieldTouched } = useFormikContext<FormikValues>();
1423
const fieldId = getFieldId(props.name, 'number-spinner');
@@ -20,9 +29,14 @@ const NumberSpinnerField: React.FC<FieldProps> = ({ label, helpText, required, .
2029
const handleChange: React.ReactEventHandler<HTMLInputElement> = React.useCallback(
2130
(event) => {
2231
field.onChange(event);
23-
setFieldValue(props.name, event.currentTarget.value);
32+
setFieldValue(
33+
props.name,
34+
props?.setOutputAsIntegerFlag
35+
? _.toInteger(event.currentTarget.value)
36+
: event.currentTarget.value,
37+
);
2438
},
25-
[field, props.name, setFieldValue],
39+
[field, props.name, setFieldValue, props?.setOutputAsIntegerFlag],
2640
);
2741

2842
return (

frontend/packages/dev-console/src/components/import/advanced/ScalingSection.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const ScalingSection: React.FC<{ name: string }> = ({ name }) => {
1515
name={name}
1616
label={t('devconsole~Replicas')}
1717
helpText={t('devconsole~The number of instances of your Image.')}
18+
setOutputAsIntegerFlag
1819
/>
1920
</FormSection>
2021
);

0 commit comments

Comments
 (0)