OCPBUGS-26933: Copy response code from proxied plugin requests (#13505)

TheRealJon · web-flow · commit 9fb8cc09cdf8 · 2024-01-17T20:29:06.000Z
* OCPBUGS-26933: Copy response code from proxied plugin requests

* move status code copy after headers copy
diff --git a/pkg/plugins/handlers.go b/pkg/plugins/handlers.go
@@ -176,6 +176,9 @@ func (p *PluginsHandler) proxyPluginRequest(requestURL *url.URL, pluginName stri
 		}
 	}
 
+	// Make sure to copy status code from the plugin service response
+	w.WriteHeader(resp.StatusCode)
+
 	_, err = io.Copy(w, resp.Body)
 	if err != nil {
 		errMsg := fmt.Sprintf("failed sending HTTP response body from %q plugin: %v", pluginName, err)

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,9 @@ func (p PluginsHandler) proxyPluginRequest(requestURL url.URL, pluginName stri`
`176`	`176`	`}`
`177`	`177`	`}`
`178`	`178`
	`179`	`+ // Make sure to copy status code from the plugin service response`
	`180`	`+ w.WriteHeader(resp.StatusCode)`
	`181`	`+`
`179`	`182`	`_, err = io.Copy(w, resp.Body)`
`180`	`183`	`if err != nil {`
`181`	`184`	`errMsg := fmt.Sprintf("failed sending HTTP response body from %q plugin: %v", pluginName, err)`